[GitHub] [iceberg] samredai commented on pull request #3714: Types literals all in one primitives pr

[GitBox <gi...@apache.org>]

samredai commented on pull request #3714:
URL: https://github.com/apache/iceberg/pull/3714#issuecomment-991962318


   @rdblue that's my bad, I suggested splitting out the primitives and generics since the primitives don't use any of the metaclass logic in the original PR. I'm still learning the right chunk size, would something like the below work better where each line item is a single PR and they're opened in this sequence?
   
   1. Converting instances to classes in types.py
   2. Primitives:
     a. Allowing types to be instantiated with a value (combining literals with types)
     b. Byte casting and hashing
     c. Conversions between types
     d. Comparisons between types
   3. Generics:
     a. Allowing types to be instantiated with a value, (this would include some of the metaclass logic)
     b. Byte casting and hashing
     c. Conversions between types
     d. Comparisons between types
   
   @CircArgs let me know if I've missed any features in the original PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org