You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by keval bhatt <ke...@freestoneinfotech.com> on 2016/06/22 13:29:29 UTC
Review Request 49084: ATLAS-584 : Integrate CSRF prevention filter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49084/
-----------------------------------------------------------
Review request for atlas, Gautam Borad, Madhan Neethiraj, Shwetha GS, and Hemanth Yamijala.
Bugs: ATLAS-584
https://issues.apache.org/jira/browse/ATLAS-584
Repository: atlas
Description
-------
Atlas needs to provide protection for CSRF protection. Need to add CSRF prevention headers to all API calls from UI.
Diffs
-----
dashboardv2/public/js/collection/BaseCollection.js 0c148ac
dashboardv2/public/js/main.js 95f64a1
dashboardv2/public/js/models/BaseModel.js da96d04
dashboardv2/public/js/utils/CommonViewFunction.js ffffa1c
dashboardv2/public/js/views/business_catalog/BusinessCatalogHeader.js 8fa436c
dashboardv2/public/js/views/site/Header.js 467cbf5
distro/src/conf/atlas-application.properties cc0e4c1
webapp/src/main/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 3a46068
webapp/src/main/resources/spring-security.xml c21a644
webapp/src/test/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilterTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/49084/diff/
Testing
-------
Manual basic testing done for crud operation of Tags,Terms and Taxonomy from UI.
Ran mvn clean install.
Thanks,
keval bhatt
Re: Review Request 49084: ATLAS-584 : Integrate CSRF prevention filter
Posted by keval bhatt <ke...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49084/
-----------------------------------------------------------
(Updated July 6, 2016, 7:20 a.m.)
Review request for atlas, Gautam Borad, Madhan Neethiraj, Shwetha GS, and Hemanth Yamijala.
Changes
-------
Handled Madhan's comment
Bugs: ATLAS-584
https://issues.apache.org/jira/browse/ATLAS-584
Repository: atlas
Description
-------
Atlas needs to provide protection for CSRF protection. Need to add CSRF prevention headers to all API calls from UI.
Diffs (updated)
-----
dashboardv2/public/js/collection/BaseCollection.js 0c148ac
dashboardv2/public/js/main.js 95f64a1
dashboardv2/public/js/models/BaseModel.js da96d04
dashboardv2/public/js/utils/CommonViewFunction.js ffffa1c
dashboardv2/public/js/views/business_catalog/BusinessCatalogHeader.js 8fa436c
dashboardv2/public/js/views/site/Header.js 467cbf5
distro/src/conf/atlas-application.properties 79a4982
webapp/src/main/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 3a46068
webapp/src/main/resources/spring-security.xml c21a644
webapp/src/test/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilterTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/49084/diff/
Testing
-------
Manual basic testing done for crud operation of Tags,Terms and Taxonomy from UI.
Ran mvn clean install.
Thanks,
keval bhatt
Re: Review Request 49084: ATLAS-584 : Integrate CSRF prevention filter
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49084/#review140957
-----------------------------------------------------------
Fix it, then Ship it!
webapp/src/main/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilter.java (line 75)
<https://reviews.apache.org/r/49084/#comment206335>
Replace '+e.getMessage()' with ', e' so that the error log will include the stack.
- Madhan Neethiraj
On June 27, 2016, 5:23 a.m., keval bhatt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49084/
> -----------------------------------------------------------
>
> (Updated June 27, 2016, 5:23 a.m.)
>
>
> Review request for atlas, Gautam Borad, Madhan Neethiraj, Shwetha GS, and Hemanth Yamijala.
>
>
> Bugs: ATLAS-584
> https://issues.apache.org/jira/browse/ATLAS-584
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Atlas needs to provide protection for CSRF protection. Need to add CSRF prevention headers to all API calls from UI.
>
>
> Diffs
> -----
>
> dashboardv2/public/js/collection/BaseCollection.js 0c148ac
> dashboardv2/public/js/main.js 95f64a1
> dashboardv2/public/js/models/BaseModel.js da96d04
> dashboardv2/public/js/utils/CommonViewFunction.js ffffa1c
> dashboardv2/public/js/views/business_catalog/BusinessCatalogHeader.js 8fa436c
> dashboardv2/public/js/views/site/Header.js 467cbf5
> distro/src/conf/atlas-application.properties 79a4982
> webapp/src/main/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilter.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 3a46068
> webapp/src/main/resources/spring-security.xml c21a644
> webapp/src/test/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilterTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/49084/diff/
>
>
> Testing
> -------
>
> Manual basic testing done for crud operation of Tags,Terms and Taxonomy from UI.
>
> Ran mvn clean install.
>
>
> Thanks,
>
> keval bhatt
>
>
Re: Review Request 49084: ATLAS-584 : Integrate CSRF prevention filter
Posted by keval bhatt <ke...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49084/
-----------------------------------------------------------
(Updated June 27, 2016, 5:23 a.m.)
Review request for atlas, Gautam Borad, Madhan Neethiraj, Shwetha GS, and Hemanth Yamijala.
Changes
-------
Added error handling in new patch
Bugs: ATLAS-584
https://issues.apache.org/jira/browse/ATLAS-584
Repository: atlas
Description
-------
Atlas needs to provide protection for CSRF protection. Need to add CSRF prevention headers to all API calls from UI.
Diffs (updated)
-----
dashboardv2/public/js/collection/BaseCollection.js 0c148ac
dashboardv2/public/js/main.js 95f64a1
dashboardv2/public/js/models/BaseModel.js da96d04
dashboardv2/public/js/utils/CommonViewFunction.js ffffa1c
dashboardv2/public/js/views/business_catalog/BusinessCatalogHeader.js 8fa436c
dashboardv2/public/js/views/site/Header.js 467cbf5
distro/src/conf/atlas-application.properties 79a4982
webapp/src/main/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilter.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 3a46068
webapp/src/main/resources/spring-security.xml c21a644
webapp/src/test/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilterTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/49084/diff/
Testing
-------
Manual basic testing done for crud operation of Tags,Terms and Taxonomy from UI.
Ran mvn clean install.
Thanks,
keval bhatt