You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/05/09 00:06:32 UTC
[GitHub] [fineract] vorburger opened a new pull request #851: improve SchedulerJobsTest.testDateFormat() by introducing Awaitility
vorburger opened a new pull request #851:
URL: https://github.com/apache/fineract/pull/851
This recently introduced new test (FINERACT-926) would locally pass, but
then fail on the next run, because another test in the same class would
modify job state to be inactive. It now sets the first jobs state as it
requires it to be, and properly awaits the expected outcome.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #851: improve SchedulerJobsTest.testDateFormat() by introducing Awaitility
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #851:
URL: https://github.com/apache/fineract/pull/851#issuecomment-626189594
> Yeah I just reviewed this. Looks good to me. I reviewed it seems solid to me.
Thanks! I've self merged based on this. Feel free to help with more code reviews... :smile: appreciate it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] maektwain commented on pull request #851: improve SchedulerJobsTest.testDateFormat() by introducing Awaitility
Posted by GitBox <gi...@apache.org>.
maektwain commented on pull request #851:
URL: https://github.com/apache/fineract/pull/851#issuecomment-626134685
Yeah I just reviewed this. Looks good to me. I reviewed it seems solid to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #851: improve SchedulerJobsTest.testDateFormat() by introducing Awaitility
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #851:
URL: https://github.com/apache/fineract/pull/851#issuecomment-626070863
@maektwain does this LGTY? Anyone else interested in reviewing this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org