You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jim Apple (Code Review)" <ge...@cloudera.org> on 2016/11/28 14:29:36 UTC
[Impala-ASF-CR] IMPALA-4543: Properly escape ignored tests subdirectories.
Jim Apple has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5242
Change subject: IMPALA-4543: Properly escape ignored tests subdirectories.
......................................................................
IMPALA-4543: Properly escape ignored tests subdirectories.
In the shell, double-quoted strings are not very close to "raw"
strings; double quotes end the string, but parameter expansion is also
performed forstrings like "${FOO}". To pass strings from Python to the
shell, I have replaced double quotes with single quotes and escaped
the single quote characters in the strings.
While I am here, add better logging in TestExecutor.run_tests to make
errors like this easier to diagnose.
Change-Id: I006eb559ec5f5b5b0379997fab945116dfc7e8d7
---
M tests/run-tests.py
1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/5242/1
--
To view, visit http://gerrit.cloudera.org:8080/5242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I006eb559ec5f5b5b0379997fab945116dfc7e8d7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
[Impala-ASF-CR] IMPALA-4543: Properly escape ignored tests subdirectories.
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change.
Change subject: IMPALA-4543: Properly escape ignored tests subdirectories.
......................................................................
Patch Set 1:
(2 comments)
Just wondering why we started hitting that ? Why isn't it showing up in other Jenkins jobs ?
http://gerrit.cloudera.org:8080/#/c/5242/1/tests/run-tests.py
File tests/run-tests.py:
PS1, Line 68: print >> sys.stderr, "run_tests arguments:", args
sys.stderr.write('Unexpected exception with pytest %s' % args)
PS1, Line 144: '\''
Is this supposed to be \' instead ?
--
To view, visit http://gerrit.cloudera.org:8080/5242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I006eb559ec5f5b5b0379997fab945116dfc7e8d7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4543: Properly escape ignored tests subdirectories.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4543: Properly escape ignored tests subdirectories.
......................................................................
Patch Set 3:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/57/
--
To view, visit http://gerrit.cloudera.org:8080/5242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I006eb559ec5f5b5b0379997fab945116dfc7e8d7
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4543: Properly escape ignored tests subdirectories.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4543: Properly escape ignored tests subdirectories.
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I006eb559ec5f5b5b0379997fab945116dfc7e8d7
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4543: Properly escape ignored tests subdirectories.
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change.
Change subject: IMPALA-4543: Properly escape ignored tests subdirectories.
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5242/2/tests/run-tests.py
File tests/run-tests.py:
PS2, Line 144: d.replace("'", "'\''")
Would be nice to add a comment about the complication with single and double quotes in bash.
--
To view, visit http://gerrit.cloudera.org:8080/5242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I006eb559ec5f5b5b0379997fab945116dfc7e8d7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4543: Properly escape ignored tests subdirectories.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4543: Properly escape ignored tests subdirectories.
......................................................................
IMPALA-4543: Properly escape ignored tests subdirectories.
In the shell, double-quoted strings are not very close to "raw"
strings; double quotes end the string, but parameter expansion is also
performed forstrings like "${FOO}". To pass strings from Python to the
shell, I have replaced double quotes with single quotes and escaped
the single quote characters in the strings.
While I am here, add better logging in TestExecutor.run_tests to make
errors like this easier to diagnose.
Change-Id: I006eb559ec5f5b5b0379997fab945116dfc7e8d7
Reviewed-on: http://gerrit.cloudera.org:8080/5242
Reviewed-by: Jim Apple <jb...@apache.org>
Tested-by: Impala Public Jenkins
---
M tests/run-tests.py
1 file changed, 11 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Jim Apple: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/5242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I006eb559ec5f5b5b0379997fab945116dfc7e8d7
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-4543: Properly escape ignored tests subdirectories.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-4543: Properly escape ignored tests subdirectories.
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
carry +2
http://gerrit.cloudera.org:8080/#/c/5242/2/tests/run-tests.py
File tests/run-tests.py:
PS2, Line 144: , single quotes cannot
> Would be nice to add a comment about the complication with single and doub
Done
--
To view, visit http://gerrit.cloudera.org:8080/5242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I006eb559ec5f5b5b0379997fab945116dfc7e8d7
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4543: Properly escape ignored tests subdirectories.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has uploaded a new patch set (#2).
Change subject: IMPALA-4543: Properly escape ignored tests subdirectories.
......................................................................
IMPALA-4543: Properly escape ignored tests subdirectories.
In the shell, double-quoted strings are not very close to "raw"
strings; double quotes end the string, but parameter expansion is also
performed forstrings like "${FOO}". To pass strings from Python to the
shell, I have replaced double quotes with single quotes and escaped
the single quote characters in the strings.
While I am here, add better logging in TestExecutor.run_tests to make
errors like this easier to diagnose.
Change-Id: I006eb559ec5f5b5b0379997fab945116dfc7e8d7
---
M tests/run-tests.py
1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/5242/2
--
To view, visit http://gerrit.cloudera.org:8080/5242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I006eb559ec5f5b5b0379997fab945116dfc7e8d7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-4543: Properly escape ignored tests subdirectories.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Hello Michael Ho,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5242
to look at the new patch set (#3).
Change subject: IMPALA-4543: Properly escape ignored tests subdirectories.
......................................................................
IMPALA-4543: Properly escape ignored tests subdirectories.
In the shell, double-quoted strings are not very close to "raw"
strings; double quotes end the string, but parameter expansion is also
performed forstrings like "${FOO}". To pass strings from Python to the
shell, I have replaced double quotes with single quotes and escaped
the single quote characters in the strings.
While I am here, add better logging in TestExecutor.run_tests to make
errors like this easier to diagnose.
Change-Id: I006eb559ec5f5b5b0379997fab945116dfc7e8d7
---
M tests/run-tests.py
1 file changed, 11 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/5242/3
--
To view, visit http://gerrit.cloudera.org:8080/5242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I006eb559ec5f5b5b0379997fab945116dfc7e8d7
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-4543: Properly escape ignored tests subdirectories.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-4543: Properly escape ignored tests subdirectories.
......................................................................
Patch Set 1:
(2 comments)
> (2 comments)
>
> Just wondering why we started hitting that ? Why isn't it showing
> up in other Jenkins jobs ?
I wish I knew. It hasn't showed up for me in my other Jenkins testing, or on my local machine. However, this handling is a mistake in any case, so this can hopefully downgrade the priority of this issue for me.
http://gerrit.cloudera.org:8080/#/c/5242/1/tests/run-tests.py
File tests/run-tests.py:
PS1, Line 68: print >> sys.stderr, "run_tests arguments:", args
> sys.stderr.write('Unexpected exception with pytest %s' % args)
Done, using the format style recommended by https://docs.python.org/2/library/string.html
PS1, Line 144: '\''
> Is this supposed to be \' instead ?
In bash, in single-quoted strings, single quotes cannot appear - not even escaped! Instead, one must close the string, insert a literal single-quote (escaped, so bash doesn't think you're starting a new string), then start your single-quoted string again.
--
To view, visit http://gerrit.cloudera.org:8080/5242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I006eb559ec5f5b5b0379997fab945116dfc7e8d7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: Yes