You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/05/23 08:24:59 UTC
[GitHub] [hudi] yanenze opened a new pull request, #5661: [HUDI-4139] improvement for flink sink operators so we can easily identify the table which write to hudi
yanenze opened a new pull request, #5661:
URL: https://github.com/apache/hudi/pull/5661
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanenze commented on a diff in pull request #5661: [HUDI-4139] improvement for flink sink operators so we can easily identify the table which write to hudi
Posted by GitBox <gi...@apache.org>.
yanenze commented on code in PR #5661:
URL: https://github.com/apache/hudi/pull/5661#discussion_r888627316
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/Pipelines.java:
##########
@@ -137,7 +137,7 @@ public static DataStreamSink<Object> bulkInsert(Configuration conf, RowType rowT
SortOperatorGen sortOperatorGen = new SortOperatorGen(rowType, partitionFields);
// sort by partition keys
dataStream = dataStream
- .transform("partition_key_sorter",
+ .transform("partition_key_sorter" + ":" + conf.getString(FlinkOptions.TABLE_NAME),
TypeInformation.of(RowData.class),
Review Comment:
i have created a new PR in https://github.com/apache/hudi/pull/5744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5661: [HUDI-4139] improvement for flink sink operators so we can easily identify the table which write to hudi
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5661:
URL: https://github.com/apache/hudi/pull/5661#issuecomment-1134564956
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "20b918eee4bc084a1808d9ed56b22e5ae2047b39",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8852",
"triggerID" : "20b918eee4bc084a1808d9ed56b22e5ae2047b39",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 20b918eee4bc084a1808d9ed56b22e5ae2047b39 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8852)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5661: [HUDI-4139] improvement for flink sink operators so we can easily identify the table which write to hudi
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5661:
URL: https://github.com/apache/hudi/pull/5661#issuecomment-1134368119
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "20b918eee4bc084a1808d9ed56b22e5ae2047b39",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "20b918eee4bc084a1808d9ed56b22e5ae2047b39",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 20b918eee4bc084a1808d9ed56b22e5ae2047b39 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanenze closed pull request #5661: [HUDI-4139] improvement for flink sink operators so we can easily identify the table which write to hudi
Posted by GitBox <gi...@apache.org>.
yanenze closed pull request #5661: [HUDI-4139] improvement for flink sink operators so we can easily identify the table which write to hudi
URL: https://github.com/apache/hudi/pull/5661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanenze closed pull request #5661: [HUDI-4139] improvement for flink sink operators so we can easily identify the table which write to hudi
Posted by GitBox <gi...@apache.org>.
yanenze closed pull request #5661: [HUDI-4139] improvement for flink sink operators so we can easily identify the table which write to hudi
URL: https://github.com/apache/hudi/pull/5661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanenze commented on a diff in pull request #5661: [HUDI-4139] improvement for flink sink operators so we can easily identify the table which write to hudi
Posted by GitBox <gi...@apache.org>.
yanenze commented on code in PR #5661:
URL: https://github.com/apache/hudi/pull/5661#discussion_r888627316
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/Pipelines.java:
##########
@@ -137,7 +137,7 @@ public static DataStreamSink<Object> bulkInsert(Configuration conf, RowType rowT
SortOperatorGen sortOperatorGen = new SortOperatorGen(rowType, partitionFields);
// sort by partition keys
dataStream = dataStream
- .transform("partition_key_sorter",
+ .transform("partition_key_sorter" + ":" + conf.getString(FlinkOptions.TABLE_NAME),
TypeInformation.of(RowData.class),
Review Comment:
i have create a new PR in https://github.com/apache/hudi/pull/5744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #5661: [HUDI-4139] improvement for flink sink operators so we can easily identify the table which write to hudi
Posted by GitBox <gi...@apache.org>.
danny0405 commented on code in PR #5661:
URL: https://github.com/apache/hudi/pull/5661#discussion_r885153742
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/Pipelines.java:
##########
@@ -137,7 +137,7 @@ public static DataStreamSink<Object> bulkInsert(Configuration conf, RowType rowT
SortOperatorGen sortOperatorGen = new SortOperatorGen(rowType, partitionFields);
// sort by partition keys
dataStream = dataStream
- .transform("partition_key_sorter",
+ .transform("partition_key_sorter" + ":" + conf.getString(FlinkOptions.TABLE_NAME),
TypeInformation.of(RowData.class),
Review Comment:
Maybe only the write op with table name is enough, for e.g
- bucket_bulk_insert
- hoodie_bulk_insert_write
- hoodie_append_write
- bucket_write
- stream_write
And we can extract a common util method here like
`writeOpIdentifier(String, Configuration)`
for generating operator name with table suffix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanenze commented on a diff in pull request #5661: [HUDI-4139] improvement for flink sink operators so we can easily identify the table which write to hudi
Posted by GitBox <gi...@apache.org>.
yanenze commented on code in PR #5661:
URL: https://github.com/apache/hudi/pull/5661#discussion_r885156736
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/Pipelines.java:
##########
@@ -137,7 +137,7 @@ public static DataStreamSink<Object> bulkInsert(Configuration conf, RowType rowT
SortOperatorGen sortOperatorGen = new SortOperatorGen(rowType, partitionFields);
// sort by partition keys
dataStream = dataStream
- .transform("partition_key_sorter",
+ .transform("partition_key_sorter" + ":" + conf.getString(FlinkOptions.TABLE_NAME),
TypeInformation.of(RowData.class),
Review Comment:
right , i will try to amend it with your suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5661: [HUDI-4139] improvement for flink sink operators so we can easily identify the table which write to hudi
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5661:
URL: https://github.com/apache/hudi/pull/5661#issuecomment-1134372484
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "20b918eee4bc084a1808d9ed56b22e5ae2047b39",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8852",
"triggerID" : "20b918eee4bc084a1808d9ed56b22e5ae2047b39",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 20b918eee4bc084a1808d9ed56b22e5ae2047b39 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8852)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org