You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "SzyWilliam (via GitHub)" <gi...@apache.org> on 2023/09/05 02:09:21 UTC
[GitHub] [iotdb] SzyWilliam opened a new pull request, #11036: [RatisConsensus] use warn_and_return to enable cluster restart when log corruption can be ignored
SzyWilliam opened a new pull request, #11036:
URL: https://github.com/apache/iotdb/pull/11036
See the details in https://issues.apache.org/jira/browse/RATIS-1879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] OneSizeFitsQuorum commented on a diff in pull request #11036: [RatisConsensus] use warn_and_return to enable cluster restart when log corruption can be ignored
Posted by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>.
OneSizeFitsQuorum commented on code in PR #11036:
URL: https://github.com/apache/iotdb/pull/11036#discussion_r1315319551
##########
iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/ratis/utils/Utils.java:
##########
@@ -292,5 +292,8 @@ public static void initRatisConfig(RaftProperties properties, RatisConfig config
RaftServerConfigKeys.setSleepDeviationThreshold(
properties, config.getUtils().getSleepDeviationThresholdMs());
+
+ RaftServerConfigKeys.Log.setCorruptionPolicy(
Review Comment:
Move to line 279?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SzyWilliam commented on a diff in pull request #11036: [RatisConsensus] use warn_and_return to enable cluster restart when log corruption can be ignored
Posted by "SzyWilliam (via GitHub)" <gi...@apache.org>.
SzyWilliam commented on code in PR #11036:
URL: https://github.com/apache/iotdb/pull/11036#discussion_r1315326375
##########
iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/ratis/utils/Utils.java:
##########
@@ -292,5 +292,8 @@ public static void initRatisConfig(RaftProperties properties, RatisConfig config
RaftServerConfigKeys.setSleepDeviationThreshold(
properties, config.getUtils().getSleepDeviationThresholdMs());
+
+ RaftServerConfigKeys.Log.setCorruptionPolicy(
Review Comment:
Sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #11036: [RatisConsensus] use warn_and_return to enable cluster restart when log corruption can be ignored
Posted by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>.
OneSizeFitsQuorum merged PR #11036:
URL: https://github.com/apache/iotdb/pull/11036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org