[GitHub] [incubator-hudi] yanghua commented on a change in pull request #1372: [HUDI-652] Decouple HoodieReadClient and AbstractHoodieClient to break the inheritance chain

[GitBox <gi...@apache.org>]

yanghua commented on a change in pull request #1372: [HUDI-652] Decouple HoodieReadClient and AbstractHoodieClient to break the inheritance chain
URL: https://github.com/apache/incubator-hudi/pull/1372#discussion_r387729779
 
 

 ##########
 File path: hudi-client/src/main/java/org/apache/hudi/client/HoodieReadClient.java
 ##########
 @@ -144,6 +163,43 @@ private void assertSqlContext() {
     }
   }
 
+  private synchronized void startEmbeddedServerView() {
 
 Review comment:
   My original thought, the first step is to decouple the inheritance chain. I did not change any logic so that I would not touch anything about the key things. Then I will try to remove some unnecessary logic.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services