You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Jean-Frederic <jf...@gmail.com> on 2007/05/10 13:32:43 UTC

Re: svn commit: r536456 - /tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml

On Wed, 2007-05-09 at 19:58 +0900, Takayuki Kaneko wrote:
> Hi,
> 
> IMO, you should arrenge the document like this.
> -    default) corresponds to <strong>%h %l %u %t "%r" %s %b"</strong>.</p>
> +    default) corresponds to <strong>%h %l %u %t "%r" %s %b</strong>.</p>
> 
> "common" pattern is defined at org.apache.catalina.valves.Constant
>         public static final String COMMON_PATTERN = "%h %l %u %t \"%r\" %s %b";
> 
> Double quotations are needed because %r would have white spaces.

The \" doesn't work... The server.xml can't be parsed ;-(

Cheers

Jean-Frederic

> 
> Regards,
> 
> -Takayuki
> 
> On 5/9/07, jfclere@apache.org <jf...@apache.org> wrote:
> > Author: jfclere
> > Date: Wed May  9 01:14:37 2007
> > New Revision: 536456
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=536456
> > Log:
> > Arrange the default value of pattern.
> >
> > Modified:
> >     tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml
> >
> > Modified: tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml
> > URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml?view=diff&rev=536456&r1=536455&r2=536456
> > ==============================================================================
> > --- tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml (original)
> > +++ tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml Wed May  9 01:14:37 2007
> > @@ -179,7 +179,7 @@
> >
> >
> >      <p>The shorthand pattern name <code>common</code> (which is also the
> > -    default) corresponds to <strong>%h %l %u %t "%r" %s %b"</strong>.</p>
> > +    default) corresponds to <strong>"%h %l %u %t %r %s %b"</strong>.</p>
> >
> >      <p>The shorthand pattern name <code>combined</code> appends the
> >      values of the <code>Referer</code> and <code>User-Agent</code> headers,
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> > For additional commands, e-mail: dev-help@tomcat.apache.org
> >
> >
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r536456 - /tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml

Posted by Jean-Frederic <jf...@gmail.com>.
On Thu, 2007-05-10 at 20:56 +0900, Takayuki Kaneko wrote:
> I tried both alternatives. They worked correctly.

Yep... I will use the single quotes.

Cheers

Jean-Frederic

> 
> Regards,
> 
> -Takayuki
> 
> On 5/10/07, Tim Funk <fu...@joedog.org> wrote:
> > Alternatives -
> > 1: wrap in single quotes
> > '%h %l %u %t "%r" %s %b'
> >
> > 2: Use &#34; (didn't try this)
> > "%h %l %u %t &#34;%r&#34; %s %b"
> >
> >
> > -Tim
> >
> > Jean-Frederic wrote:
> > > On Wed, 2007-05-09 at 19:58 +0900, Takayuki Kaneko wrote:
> > >> Hi,
> > >>
> > >> IMO, you should arrenge the document like this.
> > >> -    default) corresponds to <strong>%h %l %u %t "%r" %s %b"</strong>.</p>
> > >> +    default) corresponds to <strong>%h %l %u %t "%r" %s %b</strong>.</p>
> > >>
> > >> "common" pattern is defined at org.apache.catalina.valves.Constant
> > >>         public static final String COMMON_PATTERN = "%h %l %u %t \"%r\" %s %b";
> > >>
> > >> Double quotations are needed because %r would have white spaces.
> > >
> > > The \" doesn't work... The server.xml can't be parsed ;-(
> > >
> > > Cheers
> > >
> > > Jean-Frederic
> > >
> > >> Regards,
> > >>
> > >> -Takayuki
> > >>
> > >> On 5/9/07, jfclere@apache.org <jf...@apache.org> wrote:
> > >>> Author: jfclere
> > >>> Date: Wed May  9 01:14:37 2007
> > >>> New Revision: 536456
> > >>>
> > >>> URL: http://svn.apache.org/viewvc?view=rev&rev=536456
> > >>> Log:
> > >>> Arrange the default value of pattern.
> > >>>
> > >>> Modified:
> > >>>     tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml
> > >>>
> > >>> Modified: tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml
> > >>> URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml?view=diff&rev=536456&r1=536455&r2=536456
> > >>> ==============================================================================
> > >>> --- tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml (original)
> > >>> +++ tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml Wed May  9 01:14:37 2007
> > >>> @@ -179,7 +179,7 @@
> > >>>
> > >>>
> > >>>      <p>The shorthand pattern name <code>common</code> (which is also the
> > >>> -    default) corresponds to <strong>%h %l %u %t "%r" %s %b"</strong>.</p>
> > >>> +    default) corresponds to <strong>"%h %l %u %t %r %s %b"</strong>.</p>
> > >>>
> > >>>      <p>The shorthand pattern name <code>combined</code> appends the
> > >>>      values of the <code>Referer</code> and <code>User-Agent</code> headers,
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> > For additional commands, e-mail: dev-help@tomcat.apache.org
> >
> >
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r536456 - /tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml

Posted by Takayuki Kaneko <ka...@gmail.com>.
I tried both alternatives. They worked correctly.

Regards,

-Takayuki

On 5/10/07, Tim Funk <fu...@joedog.org> wrote:
> Alternatives -
> 1: wrap in single quotes
> '%h %l %u %t "%r" %s %b'
>
> 2: Use &#34; (didn't try this)
> "%h %l %u %t &#34;%r&#34; %s %b"
>
>
> -Tim
>
> Jean-Frederic wrote:
> > On Wed, 2007-05-09 at 19:58 +0900, Takayuki Kaneko wrote:
> >> Hi,
> >>
> >> IMO, you should arrenge the document like this.
> >> -    default) corresponds to <strong>%h %l %u %t "%r" %s %b"</strong>.</p>
> >> +    default) corresponds to <strong>%h %l %u %t "%r" %s %b</strong>.</p>
> >>
> >> "common" pattern is defined at org.apache.catalina.valves.Constant
> >>         public static final String COMMON_PATTERN = "%h %l %u %t \"%r\" %s %b";
> >>
> >> Double quotations are needed because %r would have white spaces.
> >
> > The \" doesn't work... The server.xml can't be parsed ;-(
> >
> > Cheers
> >
> > Jean-Frederic
> >
> >> Regards,
> >>
> >> -Takayuki
> >>
> >> On 5/9/07, jfclere@apache.org <jf...@apache.org> wrote:
> >>> Author: jfclere
> >>> Date: Wed May  9 01:14:37 2007
> >>> New Revision: 536456
> >>>
> >>> URL: http://svn.apache.org/viewvc?view=rev&rev=536456
> >>> Log:
> >>> Arrange the default value of pattern.
> >>>
> >>> Modified:
> >>>     tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml
> >>>
> >>> Modified: tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml
> >>> URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml?view=diff&rev=536456&r1=536455&r2=536456
> >>> ==============================================================================
> >>> --- tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml (original)
> >>> +++ tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml Wed May  9 01:14:37 2007
> >>> @@ -179,7 +179,7 @@
> >>>
> >>>
> >>>      <p>The shorthand pattern name <code>common</code> (which is also the
> >>> -    default) corresponds to <strong>%h %l %u %t "%r" %s %b"</strong>.</p>
> >>> +    default) corresponds to <strong>"%h %l %u %t %r %s %b"</strong>.</p>
> >>>
> >>>      <p>The shorthand pattern name <code>combined</code> appends the
> >>>      values of the <code>Referer</code> and <code>User-Agent</code> headers,
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r536456 - /tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml

Posted by Tim Funk <fu...@joedog.org>.
Alternatives -
1: wrap in single quotes
'%h %l %u %t "%r" %s %b'

2: Use &#34; (didn't try this)
"%h %l %u %t &#34;%r&#34; %s %b"


-Tim

Jean-Frederic wrote:
> On Wed, 2007-05-09 at 19:58 +0900, Takayuki Kaneko wrote:
>> Hi,
>>
>> IMO, you should arrenge the document like this.
>> -    default) corresponds to <strong>%h %l %u %t "%r" %s %b"</strong>.</p>
>> +    default) corresponds to <strong>%h %l %u %t "%r" %s %b</strong>.</p>
>>
>> "common" pattern is defined at org.apache.catalina.valves.Constant
>>         public static final String COMMON_PATTERN = "%h %l %u %t \"%r\" %s %b";
>>
>> Double quotations are needed because %r would have white spaces.
> 
> The \" doesn't work... The server.xml can't be parsed ;-(
> 
> Cheers
> 
> Jean-Frederic
> 
>> Regards,
>>
>> -Takayuki
>>
>> On 5/9/07, jfclere@apache.org <jf...@apache.org> wrote:
>>> Author: jfclere
>>> Date: Wed May  9 01:14:37 2007
>>> New Revision: 536456
>>>
>>> URL: http://svn.apache.org/viewvc?view=rev&rev=536456
>>> Log:
>>> Arrange the default value of pattern.
>>>
>>> Modified:
>>>     tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml
>>>
>>> Modified: tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml
>>> URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml?view=diff&rev=536456&r1=536455&r2=536456
>>> ==============================================================================
>>> --- tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml (original)
>>> +++ tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml Wed May  9 01:14:37 2007
>>> @@ -179,7 +179,7 @@
>>>
>>>
>>>      <p>The shorthand pattern name <code>common</code> (which is also the
>>> -    default) corresponds to <strong>%h %l %u %t "%r" %s %b"</strong>.</p>
>>> +    default) corresponds to <strong>"%h %l %u %t %r %s %b"</strong>.</p>
>>>
>>>      <p>The shorthand pattern name <code>combined</code> appends the
>>>      values of the <code>Referer</code> and <code>User-Agent</code> headers,


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org