You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sammy Yu (JIRA)" <ji...@apache.org> on 2009/08/06 02:37:14 UTC
[jira] Created: (CASSANDRA-346) Improve the speed of
RandomPartitioner comparator which will help flushing of BMT and compaction
Improve the speed of RandomPartitioner comparator which will help flushing of BMT and compaction
------------------------------------------------------------------------------------------------
Key: CASSANDRA-346
URL: https://issues.apache.org/jira/browse/CASSANDRA-346
Project: Cassandra
Issue Type: Improvement
Affects Versions: 0.4
Reporter: Sammy Yu
Assignee: Sammy Yu
Fix For: 0.4
During our BMT import we found that the flushing process couldn't keep up with the incoming data. One of the bottlenecks was due to the sorting of decorated keys.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-346) Improve the speed of
RandomPartitioner comparator which will help flushing of BMT and compaction
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739847#action_12739847 ]
Jonathan Ellis commented on CASSANDRA-346:
------------------------------------------
is this the final patch version? i'm unclear from irc if goffinet had more changes planned
> Improve the speed of RandomPartitioner comparator which will help flushing of BMT and compaction
> ------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-346
> URL: https://issues.apache.org/jira/browse/CASSANDRA-346
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.4
> Reporter: Sammy Yu
> Assignee: Sammy Yu
> Fix For: 0.4
>
> Attachments: 0001-Improved-RP-s-comparator-performance-to-help-BMT-imp.patch
>
>
> During our BMT import we found that the flushing process couldn't keep up with the incoming data. One of the bottlenecks was due to the sorting of decorated keys.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-346) Improve the speed of
RandomPartitioner comparator which will help flushing of BMT and compaction
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-346:
-------------------------------------
Attachment: 346-2.patch
I suggest the attached -- skipping the 2nd nextToken call when unnecessary should be slightly faster.
> Improve the speed of RandomPartitioner comparator which will help flushing of BMT and compaction
> ------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-346
> URL: https://issues.apache.org/jira/browse/CASSANDRA-346
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.4
> Reporter: Sammy Yu
> Assignee: Sammy Yu
> Fix For: 0.4
>
> Attachments: 0001-Improved-RP-s-comparator-performance-to-help-BMT-imp.patch, 346-2.patch
>
>
> During our BMT import we found that the flushing process couldn't keep up with the incoming data. One of the bottlenecks was due to the sorting of decorated keys.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-346) Improve the speed of
RandomPartitioner comparator which will help flushing of BMT and compaction
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740042#action_12740042 ]
Hudson commented on CASSANDRA-346:
----------------------------------
Integrated in Cassandra #159 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/159/])
Improve the speed of RandomPartitioner comparator. patch by Sammy Yu; reviewed by jbellis for
> Improve the speed of RandomPartitioner comparator which will help flushing of BMT and compaction
> ------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-346
> URL: https://issues.apache.org/jira/browse/CASSANDRA-346
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.4
> Reporter: Sammy Yu
> Assignee: Sammy Yu
> Fix For: 0.4
>
> Attachments: 0001-Improved-RP-s-comparator-performance-to-help-BMT-imp.patch, 346-2.patch
>
>
> During our BMT import we found that the flushing process couldn't keep up with the incoming data. One of the bottlenecks was due to the sorting of decorated keys.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-346) Improve the speed of
RandomPartitioner comparator which will help flushing of BMT and compaction
Posted by "Sammy Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sammy Yu updated CASSANDRA-346:
-------------------------------
Attachment: 0001-Improved-RP-s-comparator-performance-to-help-BMT-imp.patch
Use StringTokenizer which doesn't involve slower regex.
> Improve the speed of RandomPartitioner comparator which will help flushing of BMT and compaction
> ------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-346
> URL: https://issues.apache.org/jira/browse/CASSANDRA-346
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.4
> Reporter: Sammy Yu
> Assignee: Sammy Yu
> Fix For: 0.4
>
> Attachments: 0001-Improved-RP-s-comparator-performance-to-help-BMT-imp.patch
>
>
> During our BMT import we found that the flushing process couldn't keep up with the incoming data. One of the bottlenecks was due to the sorting of decorated keys.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-346) Improve the speed of
RandomPartitioner comparator which will help flushing of BMT and compaction
Posted by "Sammy Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739867#action_12739867 ]
Sammy Yu commented on CASSANDRA-346:
------------------------------------
Looks good! 346-2.patch makes it even better.
> Improve the speed of RandomPartitioner comparator which will help flushing of BMT and compaction
> ------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-346
> URL: https://issues.apache.org/jira/browse/CASSANDRA-346
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.4
> Reporter: Sammy Yu
> Assignee: Sammy Yu
> Fix For: 0.4
>
> Attachments: 0001-Improved-RP-s-comparator-performance-to-help-BMT-imp.patch, 346-2.patch
>
>
> During our BMT import we found that the flushing process couldn't keep up with the incoming data. One of the bottlenecks was due to the sorting of decorated keys.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-346) Improve the speed of
RandomPartitioner comparator which will help flushing of BMT and compaction
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Greene updated CASSANDRA-346:
-------------------------------------
Component/s: Core
> Improve the speed of RandomPartitioner comparator which will help flushing of BMT and compaction
> ------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-346
> URL: https://issues.apache.org/jira/browse/CASSANDRA-346
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.4
> Reporter: Sammy Yu
> Assignee: Sammy Yu
> Fix For: 0.4
>
> Attachments: 0001-Improved-RP-s-comparator-performance-to-help-BMT-imp.patch, 346-2.patch
>
>
> During our BMT import we found that the flushing process couldn't keep up with the incoming data. One of the bottlenecks was due to the sorting of decorated keys.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.