[GitHub] [spark] wangyum commented on a change in pull request #34070: [SPARK-36840][SQL] Support DPP if there is no selective predicate on the filtering side

[GitBox <gi...@apache.org>]

wangyum commented on a change in pull request #34070:
URL: https://github.com/apache/spark/pull/34070#discussion_r753606004



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/dynamicpruning/PartitionPruning.scala
##########
@@ -225,16 +230,6 @@ object PartitionPruning extends Rule[LogicalPlan] with PredicateHelper with Join
     }.isDefined
   }
 
-  /**
-   * To be able to prune partitions on a join key, the filtering side needs to
-   * meet the following requirements:
-   *   (1) it can not be a stream
-   *   (2) it needs to contain a selective predicate used for filtering

Review comment:
       Base on another case https://github.com/apache/spark/pull/34070#issuecomment-973893038. May be we can support DPP if filtering side rows less than 1000(`spark.sql.optimizer.dynamicPartitionPruning.filteringSideThreshold`).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org