You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/07 12:32:38 UTC
[jira] [Commented] (BEAM-1635) TypeError in AfterWatermark class's
__repr__ method
[ https://issues.apache.org/jira/browse/BEAM-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15899364#comment-15899364 ]
ASF GitHub Bot commented on BEAM-1635:
--------------------------------------
GitHub user tibkiss opened a pull request:
https://github.com/apache/beam/pull/2178
[BEAM-1635] TypeError in AfterWatermark class's __repr__ method
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tibkiss/beam BEAM-1635
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2178.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2178
----
commit 0ff1ec9504c0427f9fd7e150660db1b687647110
Author: Tibor Kiss <ti...@gmail.com>
Date: 2017-03-07T12:00:24Z
[BEAM-1635] TypeError in AfterWatermark class's __repr__ method
----
> TypeError in AfterWatermark class's __repr__ method
> ---------------------------------------------------
>
> Key: BEAM-1635
> URL: https://issues.apache.org/jira/browse/BEAM-1635
> Project: Beam
> Issue Type: Bug
> Components: sdk-py
> Reporter: Tibor Kiss
> Assignee: Tibor Kiss
>
> Found through PyCharm code inspector:
> AfterWatermark class in trigger.py implements {{__repr__}} method to create string representation of the object.
> Due to a typo in list append a TypeError can occur:
> {code}
> if self.late:
> qualifiers.append('late=%s', self.late)
> {code}
> Fix is trivial: replace comma by percent to achieve string format operation.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)