You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/03/01 00:35:05 UTC

[GitHub] [apisix] tokers commented on a change in pull request #3700: fix: validate plugins configuration of `plugin_config` via incremental sync

tokers commented on a change in pull request #3700:
URL: https://github.com/apache/apisix/pull/3700#discussion_r584389602



##########
File path: t/node/plugin-configs.t
##########
@@ -123,3 +123,38 @@ qr/conf_version: \d+#\d/
 qr/conf_version: \d+#1
 conf_version: \d+#2
 /
+
+
+
+=== TEST 2: validated plugins configuration via incremental sync

Review comment:
       You may add some test cases that written some malformed data to etcd and detect the error log in APISIX.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org