You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "David Jencks (JIRA)" <ji...@apache.org> on 2010/08/05 07:45:15 UTC
[jira] Created: (OPENEJB-1322) BundleFinderFactory needs a better
way to filter scans
BundleFinderFactory needs a better way to filter scans
------------------------------------------------------
Key: OPENEJB-1322
URL: https://issues.apache.org/jira/browse/OPENEJB-1322
Project: OpenEJB
Issue Type: Bug
Components: osgi
Affects Versions: 3.2
Reporter: David Jencks
Assignee: David Jencks
Fix For: 3.2
BundleFinderFactory needs to be able to look at anything in the bundle classpath of a single module such as a war but needs to be able to look in only one module at a time in an ear where everything is mushed together into one bundle. I'm not sure there is currently enough information in DeploymentModule to adequately do this.
Right now we need to look at all of a war file with ejbs inside. I've hacked up something that doesn't install a filter if the jarLocation ends in ".war".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENEJB-1322) BundleFinderFactory needs a better
way to filter scans
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895558#action_12895558 ]
David Jencks commented on OPENEJB-1322:
---------------------------------------
rev 982477.
> BundleFinderFactory needs a better way to filter scans
> ------------------------------------------------------
>
> Key: OPENEJB-1322
> URL: https://issues.apache.org/jira/browse/OPENEJB-1322
> Project: OpenEJB
> Issue Type: Bug
> Components: osgi
> Affects Versions: 3.2
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: 3.2
>
>
> BundleFinderFactory needs to be able to look at anything in the bundle classpath of a single module such as a war but needs to be able to look in only one module at a time in an ear where everything is mushed together into one bundle. I'm not sure there is currently enough information in DeploymentModule to adequately do this.
> Right now we need to look at all of a war file with ejbs inside. I've hacked up something that doesn't install a filter if the jarLocation ends in ".war".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENEJB-1322) BundleFinderFactory needs a better
way to filter scans
Posted by "Ivan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916068#action_12916068 ]
Ivan commented on OPENEJB-1322:
-------------------------------
For a single ejb application, how about updating the codes to :
boolean useLocation = location != null
&& !location.isEmpty()
&& !module.getJarLocation().endsWith(".war")
&& !module.getJarLocation().endsWith(".jar");
Thanks.
> BundleFinderFactory needs a better way to filter scans
> ------------------------------------------------------
>
> Key: OPENEJB-1322
> URL: https://issues.apache.org/jira/browse/OPENEJB-1322
> Project: OpenEJB
> Issue Type: Bug
> Components: osgi
> Affects Versions: 3.2
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: 3.2
>
>
> BundleFinderFactory needs to be able to look at anything in the bundle classpath of a single module such as a war but needs to be able to look in only one module at a time in an ear where everything is mushed together into one bundle. I'm not sure there is currently enough information in DeploymentModule to adequately do this.
> Right now we need to look at all of a war file with ejbs inside. I've hacked up something that doesn't install a filter if the jarLocation ends in ".war".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENEJB-1322) BundleFinderFactory needs a better
way to filter scans
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916083#action_12916083 ]
David Jencks commented on OPENEJB-1322:
---------------------------------------
I haven't looked at the context of this code snippet but this looks reasonable to me.... especially if it works :-)
thanks
david jencks
> BundleFinderFactory needs a better way to filter scans
> ------------------------------------------------------
>
> Key: OPENEJB-1322
> URL: https://issues.apache.org/jira/browse/OPENEJB-1322
> Project: OpenEJB
> Issue Type: Bug
> Components: osgi
> Affects Versions: 3.2
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: 3.2
>
>
> BundleFinderFactory needs to be able to look at anything in the bundle classpath of a single module such as a war but needs to be able to look in only one module at a time in an ear where everything is mushed together into one bundle. I'm not sure there is currently enough information in DeploymentModule to adequately do this.
> Right now we need to look at all of a war file with ejbs inside. I've hacked up something that doesn't install a filter if the jarLocation ends in ".war".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.