[jira] [Commented] (FLINK-27487) KafkaMetricWrappers do incorrect cast

["Arseniy Tashoyan (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-27487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17560852#comment-17560852 ] 

Arseniy Tashoyan commented on FLINK-27487:
------------------------------------------

Hi [~fpaul]
Should we apply the same fix to KafkaMetricWrapper?
https://github.com/apache/flink/blob/dfdf7afb047d1b8af581883bf208e4d8a30a116f/flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/metrics/KafkaMetricWrapper.java#L35

> KafkaMetricWrappers do incorrect cast
> -------------------------------------
>
>                 Key: FLINK-27487
>                 URL: https://issues.apache.org/jira/browse/FLINK-27487
>             Project: Flink
>          Issue Type: Bug
>          Components: Connectors / Kafka, Runtime / Metrics
>    Affects Versions: 1.15.0
>            Reporter: Chesnay Schepler
>            Assignee: Fabian Paul
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.16.0, 1.15.1
>
>
> In FLINK-24765 the kafka metric wrappers that bridge kafka metrics into our metric system were migrated from the deprecated {{KafkaMetric#value}} to {{#metricValue}}.
> This migration was done incorrectly. It was assumed that #metricValue behaves similar to #value in that it always returns a double, but this is not the case, as they may also return longs or strings.
> This results in these metrics throwing exceptions, which generally breaks the reporter mechanism completely.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)