You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/02 14:35:30 UTC
[GitHub] [pulsar] congbobo184 commented on a change in pull request #8750: [Transaction] Transaction timeout implementation.
congbobo184 commented on a change in pull request #8750:
URL: https://github.com/apache/pulsar/pull/8750#discussion_r534214172
##########
File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/PositionImpl.java
##########
@@ -129,6 +129,20 @@ public boolean equals(Object obj) {
return false;
}
+ public static PositionImpl convertStringToPosition(String positionString) {
+ if (positionString == null) {
+ throw new NullPointerException();
+ } else {
+ String[] strings = positionString.split(":");
+ if (strings.length != 2) {
+ throw new IndexOutOfBoundsException();
Review comment:
sure, it is a good idea!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org