You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Szehon Ho <sz...@cloudera.com> on 2014/06/27 10:02:29 UTC

Review Request 23124: HIVE-7291: Refactor TestParser to understand test-property file

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23124/
-----------------------------------------------------------

Review request for hive and Brock Noland.


Bugs: HIVE-7291
    https://issues.apache.org/jira/browse/HIVE-7291


Repository: hive-git


Description
-------

Add some new properties:

qFileTests.propertyFiles.${propertyFileName}=${propertyFilePath}

The testparser will look into ${propertyFilePath} and populate list of {propertyName,propertyValue}

If any qtest group specifies ${propertyFileName}.${propertyName}, it will substitute that propertyName by the propertyValue in the corresponding propertyFile.


Diffs
-----

  testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestParser.java 3155f08 
  testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestTestParser.java 35680b4 

Diff: https://reviews.apache.org/r/23124/diff/


Testing
-------

Added a unit test.  Also did manual testing on the current trunk-mr2.properties to verify.


Thanks,

Szehon Ho


Re: Review Request 23124: HIVE-7291: Refactor TestParser to understand test-property file

Posted by Szehon Ho <sz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23124/
-----------------------------------------------------------

(Updated July 1, 2014, 2 a.m.)


Review request for hive and Brock Noland.


Changes
-------

Throwing the exception.


Bugs: HIVE-7291
    https://issues.apache.org/jira/browse/HIVE-7291


Repository: hive-git


Description
-------

Add some new properties:

qFileTests.propertyFiles.${propertyFileName}=${propertyFilePath}

The testparser will look into ${propertyFilePath} and populate list of {propertyName,propertyValue}

If any qtest group specifies ${propertyFileName}.${propertyName}, it will substitute that propertyName by the propertyValue in the corresponding propertyFile.

Also before {excluded} was exclusive from {included}.  But I'm changing that for qtest so its easier to disable tests in ptest framework in emergency.  (Before we hard-coded the tests in the {included} group and could change at will, but now this list is shared with the main build so we no longer can change at will).


Diffs (updated)
-----

  testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestParser.java 3155f08 
  testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestTestParser.java 35680b4 

Diff: https://reviews.apache.org/r/23124/diff/


Testing
-------

Added a unit test.  Also did manual testing on the current trunk-mr2.properties to verify.


Thanks,

Szehon Ho


Re: Review Request 23124: HIVE-7291: Refactor TestParser to understand test-property file

Posted by Szehon Ho <sz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23124/
-----------------------------------------------------------

(Updated July 1, 2014, 1:39 a.m.)


Review request for hive and Brock Noland.


Changes
-------

One minor refactoring, for printing the stack trace.


Bugs: HIVE-7291
    https://issues.apache.org/jira/browse/HIVE-7291


Repository: hive-git


Description
-------

Add some new properties:

qFileTests.propertyFiles.${propertyFileName}=${propertyFilePath}

The testparser will look into ${propertyFilePath} and populate list of {propertyName,propertyValue}

If any qtest group specifies ${propertyFileName}.${propertyName}, it will substitute that propertyName by the propertyValue in the corresponding propertyFile.

Also before {excluded} was exclusive from {included}.  But I'm changing that for qtest so its easier to disable tests in ptest framework in emergency.  (Before we hard-coded the tests in the {included} group and could change at will, but now this list is shared with the main build so we no longer can change at will).


Diffs (updated)
-----

  testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestParser.java 3155f08 
  testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestTestParser.java 35680b4 

Diff: https://reviews.apache.org/r/23124/diff/


Testing
-------

Added a unit test.  Also did manual testing on the current trunk-mr2.properties to verify.


Thanks,

Szehon Ho


Re: Review Request 23124: HIVE-7291: Refactor TestParser to understand test-property file

Posted by Szehon Ho <sz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23124/
-----------------------------------------------------------

(Updated July 1, 2014, 1:31 a.m.)


Review request for hive and Brock Noland.


Changes
-------

Addressed review comments


Bugs: HIVE-7291
    https://issues.apache.org/jira/browse/HIVE-7291


Repository: hive-git


Description
-------

Add some new properties:

qFileTests.propertyFiles.${propertyFileName}=${propertyFilePath}

The testparser will look into ${propertyFilePath} and populate list of {propertyName,propertyValue}

If any qtest group specifies ${propertyFileName}.${propertyName}, it will substitute that propertyName by the propertyValue in the corresponding propertyFile.

Also before {excluded} was exclusive from {included}.  But I'm changing that for qtest so its easier to disable tests in ptest framework in emergency.  (Before we hard-coded the tests in the {included} group and could change at will, but now this list is shared with the main build so we no longer can change at will).


Diffs (updated)
-----

  testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestParser.java 3155f08 
  testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestTestParser.java 35680b4 

Diff: https://reviews.apache.org/r/23124/diff/


Testing
-------

Added a unit test.  Also did manual testing on the current trunk-mr2.properties to verify.


Thanks,

Szehon Ho


Re: Review Request 23124: HIVE-7291: Refactor TestParser to understand test-property file

Posted by Szehon Ho <sz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23124/
-----------------------------------------------------------

(Updated June 27, 2014, 8:06 a.m.)


Review request for hive and Brock Noland.


Bugs: HIVE-7291
    https://issues.apache.org/jira/browse/HIVE-7291


Repository: hive-git


Description (updated)
-------

Add some new properties:

qFileTests.propertyFiles.${propertyFileName}=${propertyFilePath}

The testparser will look into ${propertyFilePath} and populate list of {propertyName,propertyValue}

If any qtest group specifies ${propertyFileName}.${propertyName}, it will substitute that propertyName by the propertyValue in the corresponding propertyFile.

Also before {excluded} was exclusive from {included}.  But I'm changing that for qtest so its easier to disable tests in ptest framework in emergency.  (Before we hard-coded the tests in the {included} group and could change at will, but now this list is shared with the main build so we no longer can change at will).


Diffs
-----

  testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestParser.java 3155f08 
  testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestTestParser.java 35680b4 

Diff: https://reviews.apache.org/r/23124/diff/


Testing
-------

Added a unit test.  Also did manual testing on the current trunk-mr2.properties to verify.


Thanks,

Szehon Ho