You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Thiago H. de Paula Figueiredo (Commented) (JIRA)" <ji...@apache.org> on 2012/02/10 14:02:59 UTC
[jira] [Commented] (TAP5-1843) Allow all of the properties of the
Messages services to be accessed
[ https://issues.apache.org/jira/browse/TAP5-1843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205425#comment-13205425 ]
Thiago H. de Paula Figueiredo commented on TAP5-1843:
-----------------------------------------------------
Hi, Omar!
I don't think your patch will be accepted because it returns the map itself. This is a break of encapsulation and information hiding. Instead, we could have a method that returns a collection of all the keys.
> Allow all of the properties of the Messages services to be accessed
> -------------------------------------------------------------------
>
> Key: TAP5-1843
> URL: https://issues.apache.org/jira/browse/TAP5-1843
> Project: Tapestry 5
> Issue Type: New Feature
> Affects Versions: 5.3.2, 5.2.6
> Reporter: Omar Carvajal
> Priority: Minor
> Attachments: messagesGetAll.patch
>
>
> There are cases in which the properties Map of the Messages service should be public.
> For example, the message catalog needs to be serialized and sent back to the browser.
> I am including a patch that implements the "getAll" method in the Messages service.
> It applies correctly on Tapestry 5.2.6 and 5.3.2.
> Here is a discussion of this in the mailing list:
> http://tapestry.1045711.n5.nabble.com/Serialize-Messages-td5463756.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira