You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by viirya <gi...@git.apache.org> on 2018/04/22 14:03:49 UTC

[GitHub] spark pull request #21107: [SPARK-24044][PYTHON] Explicitly print out skippe...

Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21107#discussion_r183237963
  
    --- Diff: python/run-tests.py ---
    @@ -281,6 +262,12 @@ def process_queue(task_queue):
         total_duration = time.time() - start_time
         LOGGER.info("Tests passed in %i seconds", total_duration)
     
    +    for key, lines in sorted(SKIPPED_TESTS.items()):
    +        pyspark_python, test_name = key
    +        LOGGER.info("\nSkipped tests in %s with %s:" % (test_name, pyspark_python))
    --- End diff --
    
    Will it be too verbose to print all skipped tests? An option is to record them into LOG_FILE only. No strong preference here.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org