You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/15 19:54:41 UTC
[GitHub] [pulsar-client-go] zzzming opened a new pull request, #792: [issue 791] allow to add at least one message on batch builder
zzzming opened a new pull request, #792:
URL: https://github.com/apache/pulsar-client-go/pull/792
<--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
*(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
Fixes #791
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
### Modifications
When batching is disabled, the producer resulted in the error [unable to add message to batch]
The problem is the batch builder cannot garantee a single message to be added. When a single message size is over the default batch message size (128KB), the message cannot be added to the batch. Thus, it fails the Add to batch operation and no message can be sent.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
### Documentation
- Does this pull request introduce a new feature? ( no)
- If yes, how is the feature documented? (not applicable)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] freeznet merged pull request #792: [issue 791] allow to add at least one message on batch builder
Posted by GitBox <gi...@apache.org>.
freeznet merged PR #792:
URL: https://github.com/apache/pulsar-client-go/pull/792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] zzzming commented on pull request #792: [issue 791] allow to add at least one message on batch builder
Posted by GitBox <gi...@apache.org>.
zzzming commented on PR #792:
URL: https://github.com/apache/pulsar-client-go/pull/792#issuecomment-1163496974
@wolfstudy Can you help to merge this? This is a bug fix. Since 0.8.0, anyone who disables batching would not be able to send a message that is over 128KB payload (that is the default batching size).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org