You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2016/12/31 15:53:02 UTC

svn commit: r1776785 - in /jmeter/trunk/src/core/org/apache/jmeter/functions/util: ArgumentDecoder.java ArgumentEncoder.java

Author: pmouawad
Date: Sat Dec 31 15:53:02 2016
New Revision: 1776785

URL: http://svn.apache.org/viewvc?rev=1776785&view=rev
Log:
Sonar : fix squid:S00115 "Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'"

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/functions/util/ArgumentDecoder.java
    jmeter/trunk/src/core/org/apache/jmeter/functions/util/ArgumentEncoder.java

Modified: jmeter/trunk/src/core/org/apache/jmeter/functions/util/ArgumentDecoder.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/functions/util/ArgumentDecoder.java?rev=1776785&r1=1776784&r2=1776785&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/functions/util/ArgumentDecoder.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/functions/util/ArgumentDecoder.java Sat Dec 31 15:53:02 2016
@@ -26,11 +26,11 @@ import org.apache.oro.text.perl.Perl5Uti
 public final class ArgumentDecoder {
     private static final Perl5Util util = new Perl5Util();
 
-    private static final String expression = "s#[\\\\](.)#$1#g"; // $NON-NLS-1$
+    private static final String REGULAR_EXPRESSION = "s#[\\\\](.)#$1#g"; // $NON-NLS-1$
 
-// TODO does not appear to be used
+    // TODO does not appear to be used
     public static String decode(String s) {
-        return util.substitute(expression, s);
+        return util.substitute(REGULAR_EXPRESSION, s);
     }
 
     /**

Modified: jmeter/trunk/src/core/org/apache/jmeter/functions/util/ArgumentEncoder.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/functions/util/ArgumentEncoder.java?rev=1776785&r1=1776784&r2=1776785&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/functions/util/ArgumentEncoder.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/functions/util/ArgumentEncoder.java Sat Dec 31 15:53:02 2016
@@ -26,11 +26,11 @@ import org.apache.oro.text.perl.Perl5Uti
 public final class ArgumentEncoder {
     private static final Perl5Util util = new Perl5Util();
 
-    private static final String expression = "s#([${}(),\\\\])#\\$1#g";
+    private static final String REGULAR_EXPRESSION = "s#([${}(),\\\\])#\\$1#g";
 
     // TODO does not appear to be used
     public static String encode(String s) {
-        return util.substitute(expression, s);
+        return util.substitute(REGULAR_EXPRESSION, s);
     }
 
     /**