You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/21 17:33:09 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #842: build.yml: Remove -G from cibuild.sh command line
xiaoxiang781216 opened a new pull request #842:
URL: https://github.com/apache/incubator-nuttx/pull/842
Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on issue #842: build.yml: Remove -G from cibuild.sh command line
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #842:
URL: https://github.com/apache/incubator-nuttx/pull/842#issuecomment-617457783
> I think the point here was to improve the speed of the build by using git instead? Or are we just wanting to do this to test the distclean?
Should this be merged? You asked a question that has not been answered. Note that I have already merged #841 which is referenced by this PR. Is there any dependency?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] liuguo09 commented on pull request #842: [DON't MERGE]build.yml: Remove -G from cibuild.sh command line
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on pull request #842:
URL: https://github.com/apache/incubator-nuttx/pull/842#issuecomment-620375854
https://github.com/apache/incubator-nuttx-apps/pull/213 fixes the sim:unionfs check build failure. Once merged, re-run this PR check build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #842: [DON't MERGE]build.yml: Remove -G from cibuild.sh command line
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #842:
URL: https://github.com/apache/incubator-nuttx/pull/842#discussion_r415758519
##########
File path: tools/testbuild.sh
##########
@@ -234,6 +234,10 @@ function build {
fail=1
fi
+ # Ensure HOST config restore after refresh
+
+ ./tools/sethost.sh
Review comment:
Let's move into tools/refresh.sh
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #842: build.yml: Remove -G from cibuild.sh command line
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #842:
URL: https://github.com/apache/incubator-nuttx/pull/842#issuecomment-617526043
> Any idea why the build failed. It seems unrelated.
I will rebase and check again. It suppose more error will find after #841.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #842: [DON't MERGE]build.yml: Remove -G from cibuild.sh command line
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #842:
URL: https://github.com/apache/incubator-nuttx/pull/842#discussion_r415809164
##########
File path: tools/refresh.sh
##########
@@ -33,6 +33,7 @@
#
WD=`test -d ${0%/*} && cd ${0%/*}; pwd`
+TOPDIR="${WD}/.."
Review comment:
don't need, could use: ./tools/sethost.sh
##########
File path: tools/refresh.sh
##########
@@ -285,15 +286,17 @@ for CONFIG in ${CONFIGS}; do
# Restore any previous .config and Make.defs files
+ if [ -e SAVEMake.defs ]; then
+ mv SAVEMake.defs Make.defs || \
+ { echo "ERROR: Failed to move SAVEMake.defs to Make.defs"; exit 1; }
+ fi
+
if [ -e SAVEconfig ]; then
mv SAVEconfig .config || \
{ echo "ERROR: Failed to move SAVEconfig to .config"; exit 1; }
+ ${TOPDIR}/tools/sethost.sh 1>/dev/null
Review comment:
Should we change like other place:
if [ "X${debug}" = "Xy" ]; then
tools/sethost.sh V=1
else
tools/sethost.sh 1>/dev/null
fi
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on issue #842: build.yml: Remove -G from cibuild.sh command line
Posted by GitBox <gi...@apache.org>.
btashton commented on issue #842:
URL: https://github.com/apache/incubator-nuttx/pull/842#issuecomment-617518808
Any idea why the build failed. It seems unrelated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #842: build.yml: Remove -G from cibuild.sh command line
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #842:
URL: https://github.com/apache/incubator-nuttx/pull/842#issuecomment-621971635
> @xiaoxiang781216 Looks like this added almost 15min to the build times for macOS. Do you think there are improvements we can make to distclean to help with the performance? If it is IO bound maybe building on a RAM disk would help? https://gist.github.com/htr3n/344f06ba2bb20b1056d7d5570fe7f596
Yes, we can try both RAM disk and ccache to improve the performance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #842: build.yml: Remove -G from cibuild.sh command line
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #842:
URL: https://github.com/apache/incubator-nuttx/pull/842#issuecomment-617507669
> I think the point here was to improve the speed of the build by using git instead? Or are we just wanting to do this to test the distclean?
Yes, git clean can improve the speed a little bit, but the correction is more important than the speed. Most people never check whether the repo is in the clean state after "make distclean". This patch can ensure developer remember it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #842: build.yml: Remove -G from cibuild.sh command line
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #842:
URL: https://github.com/apache/incubator-nuttx/pull/842#issuecomment-620980632
Does anyone have any feedback? I want to enable the more check before the end of day.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] liuguo09 commented on a change in pull request #842: build.yml: Remove -G from cibuild.sh command line
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on a change in pull request #842:
URL: https://github.com/apache/incubator-nuttx/pull/842#discussion_r416359476
##########
File path: libs/libnx/nxfonts/Makefile.sources
##########
@@ -325,3 +325,4 @@ clean:
distclean: clean
$(call DELFILE, nxfonts_convert_*bpp.c)
$(call DELFILE, nxfonts_bitmaps_*.c)
+ $(call DELFILE, nxfonts_tom-thumb-4x6.c)
Review comment:
ok, done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #842: build.yml: Remove -G from cibuild.sh command line
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #842:
URL: https://github.com/apache/incubator-nuttx/pull/842#issuecomment-617505718
> > I think the point here was to improve the speed of the build by using git instead? Or are we just wanting to do this to test the distclean?
>
> Should this be merged? You asked a question that has not been answered. Note that I have already merged #841 which is referenced by this PR. Is there any dependency?
#841 add the distclean/clean check but not enable, This PR enable that check, so it isn't a big issue that we just merge #841,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on issue #842: build.yml: Remove -G from cibuild.sh command line
Posted by GitBox <gi...@apache.org>.
btashton commented on issue #842:
URL: https://github.com/apache/incubator-nuttx/pull/842#issuecomment-617517264
Ok. I'm just worried that we are going to hit an issue where our CI is taking too long. So trying to make sure the little things that are in every build don't add up.
In this case I guess it's probably worth the extra now that we are checking that distclean works correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #842: build.yml: Remove -G from cibuild.sh command line
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #842:
URL: https://github.com/apache/incubator-nuttx/pull/842#issuecomment-617307331
work with https://github.com/apache/incubator-nuttx/pull/841 to find the residuum of distclean/clean
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #842: build.yml: Remove -G from cibuild.sh command line
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #842:
URL: https://github.com/apache/incubator-nuttx/pull/842#discussion_r416351130
##########
File path: libs/libnx/nxfonts/Makefile.sources
##########
@@ -325,3 +325,4 @@ clean:
distclean: clean
$(call DELFILE, nxfonts_convert_*bpp.c)
$(call DELFILE, nxfonts_bitmaps_*.c)
+ $(call DELFILE, nxfonts_tom-thumb-4x6.c)
Review comment:
let's change the generated file to nxfonts_bitmaps_tom-thumb-4x6.c like other font?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #842: build.yml: Remove -G from cibuild.sh command line
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #842:
URL: https://github.com/apache/incubator-nuttx/pull/842#issuecomment-620485147
LGMT, can any body help review the chagne and merge?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #842: build.yml: Remove -G from cibuild.sh command line
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #842:
URL: https://github.com/apache/incubator-nuttx/pull/842#issuecomment-621639798
@xiaoxiang781216 Looks like this added almost 15min to the build times for macOS. Do you think there are improvements we can make to distclean to help with the performance? If it is IO bound maybe building on a RAM disk would help? https://gist.github.com/htr3n/344f06ba2bb20b1056d7d5570fe7f596
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on issue #842: build.yml: Remove -G from cibuild.sh command line
Posted by GitBox <gi...@apache.org>.
btashton commented on issue #842:
URL: https://github.com/apache/incubator-nuttx/pull/842#issuecomment-617317765
I think the point here was to improve the speed of the build by using git instead? Or are we just wanting to do this to test the distclean?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org