You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/07 01:18:29 UTC

[GitHub] [pulsar] Shoothzj opened a new issue #11936: Forget to call Sendcallback on a branch of closeAsync

Shoothzj opened a new issue #11936:
URL: https://github.com/apache/pulsar/issues/11936


   In #11906 , it fixed the update of memory usage, but still one branch of `closeAsync` doesn't call callback too.
   
   But this seems hard to write an unit test. This needs during the producer close, the broker is ready, and there are still remaining pending messages.
   
   Any idea for how to add tests? 
   
   @codelipenghui @merlimat @michaeljmarshall 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Shoothzj commented on issue #11936: Forget to call Sendcallback on a branch of closeAsync

Posted by GitBox <gi...@apache.org>.
Shoothzj commented on issue #11936:
URL: https://github.com/apache/pulsar/issues/11936#issuecomment-914088386


   > @Shoothzj You can create a method for handling the close producer response, then you can call it directly. If the code is untestable, we should make it testable.
   
   Thanks a lot for your help, I found the way to add test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on issue #11936: Forget to call Sendcallback on a branch of closeAsync

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on issue #11936:
URL: https://github.com/apache/pulsar/issues/11936#issuecomment-913979367


   @Shoothzj You can create a method for handling the close producer response, then you can call it directly. If the code is untestable, we should make it testable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Shoothzj commented on issue #11936: Forget to call Sendcallback on a branch of closeAsync

Posted by GitBox <gi...@apache.org>.
Shoothzj commented on issue #11936:
URL: https://github.com/apache/pulsar/issues/11936#issuecomment-913961421


   > @Shoothzj Maybe we can disable the channel auto_read at the broker side for simulating the messages pending in the queue.
   
   But we still need a close success resp from broker side. How ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on issue #11936: Forget to call Sendcallback on a branch of closeAsync

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on issue #11936:
URL: https://github.com/apache/pulsar/issues/11936#issuecomment-913952115


   @Shoothzj Maybe we can disable the channel auto_read at the broker side for simulating the messages pending in the queue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat closed issue #11936: Forget to call Sendcallback on a branch of closeAsync

Posted by GitBox <gi...@apache.org>.
merlimat closed issue #11936:
URL: https://github.com/apache/pulsar/issues/11936


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org