[jira] [Commented] (OFBIZ-5578) Quick Ship Entire Order Never Shipping

["Darrell Donati (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-5578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14032505#comment-14032505 ] 

Darrell Donati commented on OFBIZ-5578:
---------------------------------------

Hi Jacques,

Thanks for reviewing my submission.

I checked out fresh copies of: trunk, and 12.04 and did NOT apply the provided patch. Using the same products and quantities that you mention, I am able to reproduce the same error you were getting using the Order Manager application, and quick ship functionality within the Order View page. As I am able to reproduce in both fresh copies of: 12.04 and trunk, this leads me to believe this error is caused by some other issue/configuration, and not the provided patch.

I believe that I didn't encounter this error initially, as I have accounting disabled, and the error appears to be related to the accounting module.

Thanks,
Darrell

> Quick Ship Entire Order Never Shipping
> --------------------------------------
>
>                 Key: OFBIZ-5578
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5578
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk, Release Branch 12.04
>            Reporter: Darrell Donati
>            Assignee: Jacopo Cappellato
>             Fix For: SVN trunk, Release Branch 12.04
>
>         Attachments: OFBIZ-5578-Quick Ship Entire Order Never Shipping.log, ShipmentServices.xml.patch
>
>
> The quickShipEntireOrder in ShipmentServices.xml takes in an optional field called "setPackedOnly". This check for setPackedOnly was added to 'createShipmentForFacilityAndShipGroup' in r1139346. QuickShipEntireOrder also calls the 'createShipmentForFacilityAndShipGroup' simple method, but setPackedOnly is never set in the context before making the call, meaning that setPackedOnly is always empty when it's checked in the method. 
> Additionally, the check on setPackedOnly is written such that if setPackedOnly is NOT empty, the status is taken to SHIPPED. Instead, it makes sense for it to be taken to SHIPPED status when setPackedOnly IS empty (see 'setShipmentStatusPackedAndShipped' Line 1719).
> See my original thread on the ML here: http://ofbiz.135035.n4.nabble.com/Quick-Ship-Order-Status-Service-td4648696.html



--
This message was sent by Atlassian JIRA
(v6.2#6252)