You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "vladimirg-db (via GitHub)" <gi...@apache.org> on 2024/10/15 09:54:11 UTC
[PR] [SPARK-49974][SQL] Move resolveRelations(...) out of the Analyzer.scala [spark]
vladimirg-db opened a new pull request, #48475:
URL: https://github.com/apache/spark/pull/48475
### What changes were proposed in this pull request?
Move resolveRelation(...) and some of its dependencies out to a separate class, because it's reasonably self-contained.
### Why are the changes needed?
Analyzer.scala is 4K+ lines long, so it makes sense to gradually split it.
### Does this PR introduce _any_ user-facing change?
No, just the code is moved to a separate class.
### How was this patch tested?
Existing tests.
### Was this patch authored or co-authored using generative AI tooling?
copilot.vim.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49974][SQL] Move resolveRelations(...) out of the Analyzer.scala [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #48475:
URL: https://github.com/apache/spark/pull/48475#issuecomment-2413901041
+1, LGTM. Merging to master.
Thank you, @vladimirg-db.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49974][SQL] Move resolveRelations(...) out of the Analyzer.scala [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #48475: [SPARK-49974][SQL] Move resolveRelations(...) out of the Analyzer.scala
URL: https://github.com/apache/spark/pull/48475
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org