You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/08 04:11:52 UTC
[GitHub] [arrow] anthonylouisbsb opened a new pull request #10477: ARROW-13002: [C++] Add a check for the utf8proc's version in CMake
anthonylouisbsb opened a new pull request #10477:
URL: https://github.com/apache/arrow/pull/10477
It adds a function in CMake to retrieve the used version of the `utf8proc` library and sets a required version to be used by CMake.
The PR complements the [10468](https://github.com/apache/arrow/pull/10468) one, that fixed the bug related to broken builds in Ubuntu 18.04
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] anthonylouisbsb commented on pull request #10477: ARROW-13002: [C++] Add a check for the utf8proc's version in CMake
Posted by GitBox <gi...@apache.org>.
anthonylouisbsb commented on pull request #10477:
URL: https://github.com/apache/arrow/pull/10477#issuecomment-856445141
@kou I applied all suggestions you made.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #10477: ARROW-13002: [C++] Add a check for the utf8proc's version in CMake
Posted by GitBox <gi...@apache.org>.
kou closed pull request #10477:
URL: https://github.com/apache/arrow/pull/10477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10477: ARROW-13002: [C++] Add a check for the utf8proc's version in CMake
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10477:
URL: https://github.com/apache/arrow/pull/10477#issuecomment-856425321
Revision: e3386d8c07f3c50d40c78f6e1f0b0cdfd8157e8f
Submitted crossbow builds: [ursacomputing/crossbow @ actions-483](https://github.com/ursacomputing/crossbow/branches/all?query=actions-483)
|Task|Status|
|----|------|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-483-github-test-ubuntu-18.04-cpp)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-483-github-test-ubuntu-18.04-cpp-static)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #10477: ARROW-13002: [C++] Add a check for the utf8proc's version in CMake
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #10477:
URL: https://github.com/apache/arrow/pull/10477#discussion_r647134079
##########
File path: cpp/cmake_modules/Findutf8proc.cmake
##########
@@ -15,6 +15,36 @@
# specific language governing permissions and limitations
# under the License.
+function(extract_utf8proc_version)
+ if(utf8proc_INCLUDE_DIR)
+ file(READ "${utf8proc_INCLUDE_DIR}/utf8proc.h" UTF8PROC_H_CONTENT)
+
+ string(REGEX MATCH "#define UTF8PROC_VERSION_MAJOR [0-9]+"
+ UTF8PROC_MAJOR_VERSION_DEFINITION "${UTF8PROC_H_CONTENT}")
+ string(REGEX MATCH "#define UTF8PROC_VERSION_MINOR [0-9]+"
+ UTF8PROC_MINOR_VERSION_DEFINITION "${UTF8PROC_H_CONTENT}")
+ string(REGEX MATCH "#define UTF8PROC_VERSION_PATCH [0-9]+"
+ UTF8PROC_PATCH_VERSION_DEFINITION "${UTF8PROC_H_CONTENT}")
+
+ string(REGEX MATCH " [0-9.]+" UTF8PROC_MAJOR_VERSION
+ "${UTF8PROC_MAJOR_VERSION_DEFINITION}")
+ string(REGEX MATCH " [0-9.]+" UTF8PROC_MINOR_VERSION
+ "${UTF8PROC_MINOR_VERSION_DEFINITION}")
+ string(REGEX MATCH " [0-9.]+" UTF8PROC_PATCH_VERSION
+ "${UTF8PROC_PATCH_VERSION_DEFINITION}")
+
+ string(STRIP "${UTF8PROC_MAJOR_VERSION}" UTF8PROC_MAJOR_VERSION)
+ string(STRIP "${UTF8PROC_MINOR_VERSION}" UTF8PROC_MINOR_VERSION)
+ string(STRIP "${UTF8PROC_PATCH_VERSION}" UTF8PROC_PATCH_VERSION)
Review comment:
Can we simplify them?
```suggestion
string(REGEX MATCH "[0-9.]+" UTF8PROC_MAJOR_VERSION
"${UTF8PROC_MAJOR_VERSION_DEFINITION}")
string(REGEX MATCH "[0-9.]+" UTF8PROC_MINOR_VERSION
"${UTF8PROC_MINOR_VERSION_DEFINITION}")
string(REGEX MATCH "[0-9.]+" UTF8PROC_PATCH_VERSION
"${UTF8PROC_PATCH_VERSION_DEFINITION}")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] anthonylouisbsb commented on pull request #10477: ARROW-13002: [C++] Add a check for the utf8proc's version in CMake
Posted by GitBox <gi...@apache.org>.
anthonylouisbsb commented on pull request #10477:
URL: https://github.com/apache/arrow/pull/10477#issuecomment-856425026
@github-actions crossbow submit test-ubuntu-18.04-cpp-static test-ubuntu-18.04-cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] anthonylouisbsb commented on a change in pull request #10477: ARROW-13002: [C++] Add a check for the utf8proc's version in CMake
Posted by GitBox <gi...@apache.org>.
anthonylouisbsb commented on a change in pull request #10477:
URL: https://github.com/apache/arrow/pull/10477#discussion_r647113823
##########
File path: cpp/cmake_modules/Findutf8proc.cmake
##########
@@ -15,6 +15,31 @@
# specific language governing permissions and limitations
# under the License.
+function(EXTRACT_UTF8PROC_VERSION)
+ if(utf8proc_INCLUDE_DIR)
+ file(READ "${utf8proc_INCLUDE_DIR}/utf8proc.h" UTF8PROC_H_CONTENT)
+
+ string(REGEX MATCH "#define UTF8PROC_VERSION_MAJOR [0-9]+" UTF8PROC_MAJOR_VERSION_DEFINITION
+ "${UTF8PROC_H_CONTENT}")
+ string(REGEX MATCH "#define UTF8PROC_VERSION_MINOR [0-9]+" UTF8PROC_MINOR_VERSION_DEFINITION
+ "${UTF8PROC_H_CONTENT}")
+ string(REGEX MATCH "#define UTF8PROC_VERSION_PATCH [0-9]+" UTF8PROC_PATCH_VERSION_DEFINITION
+ "${UTF8PROC_H_CONTENT}")
+
+ string(REGEX MATCH " [0-9.]+" UTF8PROC_MAJOR_VERSION "${UTF8PROC_MAJOR_VERSION_DEFINITION}")
+ string(REGEX MATCH " [0-9.]+" UTF8PROC_MINOR_VERSION "${UTF8PROC_MINOR_VERSION_DEFINITION}")
+ string(REGEX MATCH " [0-9.]+" UTF8PROC_PATCH_VERSION "${UTF8PROC_PATCH_VERSION_DEFINITION}")
+
+ string(STRIP "${UTF8PROC_MAJOR_VERSION}" UTF8PROC_MAJOR_VERSION)
+ string(STRIP "${UTF8PROC_MINOR_VERSION}" UTF8PROC_MINOR_VERSION)
+ string(STRIP "${UTF8PROC_PATCH_VERSION}" UTF8PROC_PATCH_VERSION)
+
+ set(UTF8PROC_VERSION "${UTF8PROC_MAJOR_VERSION}.${UTF8PROC_MINOR_VERSION}.${UTF8PROC_PATCH_VERSION}" PARENT_SCOPE)
Review comment:
The suggestion was applied!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] anthonylouisbsb commented on pull request #10477: ARROW-13002: [C++] Add a check for the utf8proc's version in CMake
Posted by GitBox <gi...@apache.org>.
anthonylouisbsb commented on pull request #10477:
URL: https://github.com/apache/arrow/pull/10477#issuecomment-856465929
@kou Thanks for your help! I update my cmake-format version and run the python script. Let check if now it will execute without errors in build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #10477: ARROW-13002: [C++] Add a check for the utf8proc's version in CMake
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #10477:
URL: https://github.com/apache/arrow/pull/10477#issuecomment-856462704
```bash
pip3 uninstall cmake-format
pip3 install 'cmake_format==0.5.2'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] anthonylouisbsb commented on a change in pull request #10477: ARROW-13002: [C++] Add a check for the utf8proc's version in CMake
Posted by GitBox <gi...@apache.org>.
anthonylouisbsb commented on a change in pull request #10477:
URL: https://github.com/apache/arrow/pull/10477#discussion_r647113939
##########
File path: cpp/cmake_modules/Findutf8proc.cmake
##########
@@ -15,6 +15,31 @@
# specific language governing permissions and limitations
# under the License.
+function(EXTRACT_UTF8PROC_VERSION)
Review comment:
The suggestion was applied!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] anthonylouisbsb commented on a change in pull request #10477: ARROW-13002: [C++] Add a check for the utf8proc's version in CMake
Posted by GitBox <gi...@apache.org>.
anthonylouisbsb commented on a change in pull request #10477:
URL: https://github.com/apache/arrow/pull/10477#discussion_r647139642
##########
File path: cpp/cmake_modules/Findutf8proc.cmake
##########
@@ -15,6 +15,36 @@
# specific language governing permissions and limitations
# under the License.
+function(extract_utf8proc_version)
+ if(utf8proc_INCLUDE_DIR)
+ file(READ "${utf8proc_INCLUDE_DIR}/utf8proc.h" UTF8PROC_H_CONTENT)
+
+ string(REGEX MATCH "#define UTF8PROC_VERSION_MAJOR [0-9]+"
+ UTF8PROC_MAJOR_VERSION_DEFINITION "${UTF8PROC_H_CONTENT}")
+ string(REGEX MATCH "#define UTF8PROC_VERSION_MINOR [0-9]+"
+ UTF8PROC_MINOR_VERSION_DEFINITION "${UTF8PROC_H_CONTENT}")
+ string(REGEX MATCH "#define UTF8PROC_VERSION_PATCH [0-9]+"
+ UTF8PROC_PATCH_VERSION_DEFINITION "${UTF8PROC_H_CONTENT}")
+
+ string(REGEX MATCH " [0-9.]+" UTF8PROC_MAJOR_VERSION
+ "${UTF8PROC_MAJOR_VERSION_DEFINITION}")
+ string(REGEX MATCH " [0-9.]+" UTF8PROC_MINOR_VERSION
+ "${UTF8PROC_MINOR_VERSION_DEFINITION}")
+ string(REGEX MATCH " [0-9.]+" UTF8PROC_PATCH_VERSION
+ "${UTF8PROC_PATCH_VERSION_DEFINITION}")
+
+ string(STRIP "${UTF8PROC_MAJOR_VERSION}" UTF8PROC_MAJOR_VERSION)
+ string(STRIP "${UTF8PROC_MINOR_VERSION}" UTF8PROC_MINOR_VERSION)
+ string(STRIP "${UTF8PROC_PATCH_VERSION}" UTF8PROC_PATCH_VERSION)
Review comment:
@kou I tried that approach, but it retrieved the 8 in `UTF8PROC` that is at [line's start](https://github.com/JuliaStrings/utf8proc/blob/462093b3924c7491defc67fda4bc7a27baf9b088/utf8proc.h#L72)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] anthonylouisbsb commented on a change in pull request #10477: ARROW-13002: [C++] Add a check for the utf8proc's version in CMake
Posted by GitBox <gi...@apache.org>.
anthonylouisbsb commented on a change in pull request #10477:
URL: https://github.com/apache/arrow/pull/10477#discussion_r647150205
##########
File path: cpp/cmake_modules/Findutf8proc.cmake
##########
@@ -15,6 +15,36 @@
# specific language governing permissions and limitations
# under the License.
+function(extract_utf8proc_version)
+ if(utf8proc_INCLUDE_DIR)
+ file(READ "${utf8proc_INCLUDE_DIR}/utf8proc.h" UTF8PROC_H_CONTENT)
+
+ string(REGEX MATCH "#define UTF8PROC_VERSION_MAJOR [0-9]+"
+ UTF8PROC_MAJOR_VERSION_DEFINITION "${UTF8PROC_H_CONTENT}")
+ string(REGEX MATCH "#define UTF8PROC_VERSION_MINOR [0-9]+"
+ UTF8PROC_MINOR_VERSION_DEFINITION "${UTF8PROC_H_CONTENT}")
+ string(REGEX MATCH "#define UTF8PROC_VERSION_PATCH [0-9]+"
+ UTF8PROC_PATCH_VERSION_DEFINITION "${UTF8PROC_H_CONTENT}")
+
+ string(REGEX MATCH " [0-9.]+" UTF8PROC_MAJOR_VERSION
+ "${UTF8PROC_MAJOR_VERSION_DEFINITION}")
+ string(REGEX MATCH " [0-9.]+" UTF8PROC_MINOR_VERSION
+ "${UTF8PROC_MINOR_VERSION_DEFINITION}")
+ string(REGEX MATCH " [0-9.]+" UTF8PROC_PATCH_VERSION
+ "${UTF8PROC_PATCH_VERSION_DEFINITION}")
+
+ string(STRIP "${UTF8PROC_MAJOR_VERSION}" UTF8PROC_MAJOR_VERSION)
+ string(STRIP "${UTF8PROC_MINOR_VERSION}" UTF8PROC_MINOR_VERSION)
+ string(STRIP "${UTF8PROC_PATCH_VERSION}" UTF8PROC_PATCH_VERSION)
Review comment:
It looks fine, I applied the suggested change. It is recognizing the version correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #10477: ARROW-13002: [C++] Add a check for the utf8proc's version in CMake
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #10477:
URL: https://github.com/apache/arrow/pull/10477#issuecomment-856453000
Could you fix CMake format error by `python3 run-cmake-format.py` with cmake-format 0.5.2?
Or could you enable "Allow edits by maintainers" for this pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] anthonylouisbsb commented on pull request #10477: ARROW-13002: [C++] Add a check for the utf8proc's version in CMake
Posted by GitBox <gi...@apache.org>.
anthonylouisbsb commented on pull request #10477:
URL: https://github.com/apache/arrow/pull/10477#issuecomment-856459960
@kou The option to allow the maintainers to edit is not being shown in this PR, I think it is because our fork is from an organization.
I ran the `run-cmake-format.py`, but the error is still appearing. I will try to update the `cmake-format` dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #10477: ARROW-13002: [C++] Add a check for the utf8proc's version in CMake
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #10477:
URL: https://github.com/apache/arrow/pull/10477#discussion_r647103927
##########
File path: cpp/cmake_modules/Findutf8proc.cmake
##########
@@ -15,6 +15,31 @@
# specific language governing permissions and limitations
# under the License.
+function(EXTRACT_UTF8PROC_VERSION)
+ if(utf8proc_INCLUDE_DIR)
+ file(READ "${utf8proc_INCLUDE_DIR}/utf8proc.h" UTF8PROC_H_CONTENT)
+
+ string(REGEX MATCH "#define UTF8PROC_VERSION_MAJOR [0-9]+" UTF8PROC_MAJOR_VERSION_DEFINITION
+ "${UTF8PROC_H_CONTENT}")
+ string(REGEX MATCH "#define UTF8PROC_VERSION_MINOR [0-9]+" UTF8PROC_MINOR_VERSION_DEFINITION
+ "${UTF8PROC_H_CONTENT}")
+ string(REGEX MATCH "#define UTF8PROC_VERSION_PATCH [0-9]+" UTF8PROC_PATCH_VERSION_DEFINITION
+ "${UTF8PROC_H_CONTENT}")
+
+ string(REGEX MATCH " [0-9.]+" UTF8PROC_MAJOR_VERSION "${UTF8PROC_MAJOR_VERSION_DEFINITION}")
+ string(REGEX MATCH " [0-9.]+" UTF8PROC_MINOR_VERSION "${UTF8PROC_MINOR_VERSION_DEFINITION}")
+ string(REGEX MATCH " [0-9.]+" UTF8PROC_PATCH_VERSION "${UTF8PROC_PATCH_VERSION_DEFINITION}")
+
+ string(STRIP "${UTF8PROC_MAJOR_VERSION}" UTF8PROC_MAJOR_VERSION)
+ string(STRIP "${UTF8PROC_MINOR_VERSION}" UTF8PROC_MINOR_VERSION)
+ string(STRIP "${UTF8PROC_PATCH_VERSION}" UTF8PROC_PATCH_VERSION)
+
+ set(UTF8PROC_VERSION "${UTF8PROC_MAJOR_VERSION}.${UTF8PROC_MINOR_VERSION}.${UTF8PROC_PATCH_VERSION}" PARENT_SCOPE)
Review comment:
Could you use `utf8proc_` prefix for variable that is exported because this package's name is `utf8proc`?
```suggestion
set(utf8proc_VERSION "${UTF8PROC_MAJOR_VERSION}.${UTF8PROC_MINOR_VERSION}.${UTF8PROC_PATCH_VERSION}" PARENT_SCOPE)
```
##########
File path: cpp/cmake_modules/Findutf8proc.cmake
##########
@@ -15,6 +15,31 @@
# specific language governing permissions and limitations
# under the License.
+function(EXTRACT_UTF8PROC_VERSION)
Review comment:
Could you use lower case because we use lower case for function call?
```suggestion
function(extract_utf8proc_version)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] anthonylouisbsb commented on pull request #10477: ARROW-13002: [C++] Add a check for the utf8proc's version in CMake
Posted by GitBox <gi...@apache.org>.
anthonylouisbsb commented on pull request #10477:
URL: https://github.com/apache/arrow/pull/10477#issuecomment-856444386
@github-actions crossbow submit test-ubuntu-18.04-cpp-static test-ubuntu-18.04-cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #10477: ARROW-13002: [C++] Add a check for the utf8proc's version in CMake
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #10477:
URL: https://github.com/apache/arrow/pull/10477#issuecomment-856461023
I think that you didn't use cmake-format 0.5.2. Could you confirm your cmake-format version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10477: ARROW-13002: [C++] Add a check for the utf8proc's version in CMake
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10477:
URL: https://github.com/apache/arrow/pull/10477#issuecomment-856423992
https://issues.apache.org/jira/browse/ARROW-13002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #10477: ARROW-13002: [C++] Add a check for the utf8proc's version in CMake
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #10477:
URL: https://github.com/apache/arrow/pull/10477#discussion_r647144533
##########
File path: cpp/cmake_modules/Findutf8proc.cmake
##########
@@ -15,6 +15,36 @@
# specific language governing permissions and limitations
# under the License.
+function(extract_utf8proc_version)
+ if(utf8proc_INCLUDE_DIR)
+ file(READ "${utf8proc_INCLUDE_DIR}/utf8proc.h" UTF8PROC_H_CONTENT)
+
+ string(REGEX MATCH "#define UTF8PROC_VERSION_MAJOR [0-9]+"
+ UTF8PROC_MAJOR_VERSION_DEFINITION "${UTF8PROC_H_CONTENT}")
+ string(REGEX MATCH "#define UTF8PROC_VERSION_MINOR [0-9]+"
+ UTF8PROC_MINOR_VERSION_DEFINITION "${UTF8PROC_H_CONTENT}")
+ string(REGEX MATCH "#define UTF8PROC_VERSION_PATCH [0-9]+"
+ UTF8PROC_PATCH_VERSION_DEFINITION "${UTF8PROC_H_CONTENT}")
+
+ string(REGEX MATCH " [0-9.]+" UTF8PROC_MAJOR_VERSION
+ "${UTF8PROC_MAJOR_VERSION_DEFINITION}")
+ string(REGEX MATCH " [0-9.]+" UTF8PROC_MINOR_VERSION
+ "${UTF8PROC_MINOR_VERSION_DEFINITION}")
+ string(REGEX MATCH " [0-9.]+" UTF8PROC_PATCH_VERSION
+ "${UTF8PROC_PATCH_VERSION_DEFINITION}")
+
+ string(STRIP "${UTF8PROC_MAJOR_VERSION}" UTF8PROC_MAJOR_VERSION)
+ string(STRIP "${UTF8PROC_MINOR_VERSION}" UTF8PROC_MINOR_VERSION)
+ string(STRIP "${UTF8PROC_PATCH_VERSION}" UTF8PROC_PATCH_VERSION)
Review comment:
Ah, OK. How about this?
```suggestion
string(REGEX MATCH "[0-9]+$" UTF8PROC_MAJOR_VERSION
"${UTF8PROC_MAJOR_VERSION_DEFINITION}")
string(REGEX MATCH "[0-9]+$" UTF8PROC_MINOR_VERSION
"${UTF8PROC_MINOR_VERSION_DEFINITION}")
string(REGEX MATCH "[0-9]+$" UTF8PROC_PATCH_VERSION
"${UTF8PROC_PATCH_VERSION_DEFINITION}")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] anthonylouisbsb commented on pull request #10477: ARROW-13002: [C++] Add a check for the utf8proc's version in CMake
Posted by GitBox <gi...@apache.org>.
anthonylouisbsb commented on pull request #10477:
URL: https://github.com/apache/arrow/pull/10477#issuecomment-856461783
@kou Here is the cmake-format version:
```shell
$ cmake-format -v
$ 0.6.13
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10477: ARROW-13002: [C++] Add a check for the utf8proc's version in CMake
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10477:
URL: https://github.com/apache/arrow/pull/10477#issuecomment-856444778
Revision: 9f059ea22ffe0e60875275bd8699bd69c8344673
Submitted crossbow builds: [ursacomputing/crossbow @ actions-484](https://github.com/ursacomputing/crossbow/branches/all?query=actions-484)
|Task|Status|
|----|------|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-484-github-test-ubuntu-18.04-cpp)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-484-github-test-ubuntu-18.04-cpp-static)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #10477: ARROW-13002: [C++] Add a check for the utf8proc's version in CMake
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #10477:
URL: https://github.com/apache/arrow/pull/10477#issuecomment-856448346
@github-actions autotune
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org