You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "markap14 (via GitHub)" <gi...@apache.org> on 2023/09/28 13:35:21 UTC

[GitHub] [nifi] markap14 opened a new pull request, #7806: NIFI-12142: Deleted many methods, classes, and references that were d…

markap14 opened a new pull request, #7806:
URL: https://github.com/apache/nifi/pull/7806

   …eprecated.
   
   <!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
   <!-- contributor license agreements.  See the NOTICE file distributed with -->
   <!-- this work for additional information regarding copyright ownership. -->
   <!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
   <!-- (the "License"); you may not use this file except in compliance with -->
   <!-- the License.  You may obtain a copy of the License at -->
   <!--     http://www.apache.org/licenses/LICENSE-2.0 -->
   <!-- Unless required by applicable law or agreed to in writing, software -->
   <!-- distributed under the License is distributed on an "AS IS" BASIS, -->
   <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
   <!-- See the License for the specific language governing permissions and -->
   <!-- limitations under the License. -->
   
   # Summary
   
   [NIFI-00000](https://issues.apache.org/jira/browse/NIFI-00000)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [ ] Pull Request based on current revision of the `main` branch
   - [ ] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
     - [ ] JDK 21
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] markap14 commented on a diff in pull request #7806: NIFI-12142: Deleted many methods, classes, and references that were d…

Posted by "markap14 (via GitHub)" <gi...@apache.org>.
markap14 commented on code in PR #7806:
URL: https://github.com/apache/nifi/pull/7806#discussion_r1340332144


##########
nifi-nar-bundles/nifi-extension-utils/nifi-dbcp-base/src/main/java/org/apache/nifi/dbcp/utils/DefaultDataSourceValues.java:
##########
@@ -31,35 +29,28 @@ public Long getLongValue() {
         }
     },
     MAX_TOTAL_CONNECTIONS("8"),
+
     /**
      * Copied from {@link GenericObjectPoolConfig#DEFAULT_MIN_IDLE} in Commons-DBCP 2.7.0
      */
     MIN_IDLE("0"),
+
     /**
      * Copied from {@link GenericObjectPoolConfig#DEFAULT_MAX_IDLE} in Commons-DBCP 2.7.0
      */
     MAX_IDLE("8"),
-    /**

Review Comment:
   I don't know why they were copied. I tried to avoid changing any logic that I wasn't 100% confident about. The ones that were removed, I believe, referenced deprecated methods. I used IntelliJ to just find any and all deprecated references and went through them 1-by-1, addressing. I made some other trivial updates that IntelliJ recommended as well, but largely didn't change anything else.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] joewitt commented on pull request #7806: NIFI-12142: Deleted many methods, classes, and references that were d…

Posted by "joewitt (via GitHub)" <gi...@apache.org>.
joewitt commented on PR #7806:
URL: https://github.com/apache/nifi/pull/7806#issuecomment-1739549106

   Should I comment on the fact that literally everything failed due to contrib check or you got that ;) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] joewitt commented on pull request #7806: NIFI-12142: Deleted many methods, classes, and references that were d…

Posted by "joewitt (via GitHub)" <gi...@apache.org>.
joewitt commented on PR #7806:
URL: https://github.com/apache/nifi/pull/7806#issuecomment-1739528311

   the reordered import changes are a bit brutal in terms of signal to noise ratio.  Fixable?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] joewitt commented on a diff in pull request #7806: NIFI-12142: Deleted many methods, classes, and references that were d…

Posted by "joewitt (via GitHub)" <gi...@apache.org>.
joewitt commented on code in PR #7806:
URL: https://github.com/apache/nifi/pull/7806#discussion_r1340296356


##########
nifi-nar-bundles/nifi-extension-utils/nifi-dbcp-base/src/main/java/org/apache/nifi/dbcp/utils/DefaultDataSourceValues.java:
##########
@@ -31,35 +29,28 @@ public Long getLongValue() {
         }
     },
     MAX_TOTAL_CONNECTIONS("8"),
+
     /**
      * Copied from {@link GenericObjectPoolConfig#DEFAULT_MIN_IDLE} in Commons-DBCP 2.7.0
      */
     MIN_IDLE("0"),
+
     /**
      * Copied from {@link GenericObjectPoolConfig#DEFAULT_MAX_IDLE} in Commons-DBCP 2.7.0
      */
     MAX_IDLE("8"),
-    /**

Review Comment:
   Whey remove several of these Javadoc statements but not all of them?   Do we know why we're copying the code/values here from the stated library and not instead just referring to these values from the library itself?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] joewitt commented on pull request #7806: NIFI-12142: Deleted many methods, classes, and references that were d…

Posted by "joewitt (via GitHub)" <gi...@apache.org>.
joewitt commented on PR #7806:
URL: https://github.com/apache/nifi/pull/7806#issuecomment-1739642303

   full clean build with contrib check all good.  nifi starts up and does its thing as normal.  will let CI run then happy to merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] markap14 commented on pull request #7806: NIFI-12142: Deleted many methods, classes, and references that were d…

Posted by "markap14 (via GitHub)" <gi...@apache.org>.
markap14 commented on PR #7806:
URL: https://github.com/apache/nifi/pull/7806#issuecomment-1739543935

   > the reordered import changes are a bit brutal in terms of signal to noise ratio. Fixable?
   
   Well, that is disappointing :( I am on a new laptop, and I guess I didn't get all of my IntelliJ settings mapped over. Just updated my settings so that it properly organizes the imports in the future. Unfortunately I am not sure how it can be fixed at this point without a massive amount of effort, searching through each modified file and manually opening it and organizing imports. We could, perhaps, in a follow-on PR, issue an "Organize Imports" in IntelliJ at the root level so that we have them all in the desired order...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] asfgit closed pull request #7806: NIFI-12142: Deleted many methods, classes, and references that were d…

Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #7806: NIFI-12142: Deleted many methods, classes, and references that were d…
URL: https://github.com/apache/nifi/pull/7806


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org