Re: cvs commit: apache-2.0/src/lib/apr/network_io/unix networkio.hsockaddr.c

[Ben Laurie <be...@algroup.co.uk>]

Greg Stein wrote:
> 
> On Fri, 21 Jan 2000, Jim Jagielski wrote:
> > Greg Stein wrote:
> > >
> > > If I understand correctly, this means we have three versions here:
> > >
> > > 1) HAVE_NETINET_IN_H, defined by Apache; for use by all Apache code
> > > 2) HAVE_NETINET_IN_H, defined by APR; for use "internally" by APR
> > > 3) APR_HAVE_NETINET_IN_H, defined by APR; for private use by the APR
> > >    public header files
> > >
> > > Can't we combine (2) and (3) by eliminating all uses of (2)? In other
> > > words, the APR code uses #if APR_HAVE_NETINET_IN_H throughout.
> > >
> >
> > We could also generate a simple filter that takes the APR_FOO header
> > macros and does thusly:
> >
> >     #define APR_FOO 1     ->    #define FOO
> >     #define APR_FOO 0     ->    #undef FOO
> 
> Per a followup email from Ryan, macros (2) and (3) have different
> semantics. Therefore, we cannot combine them, and we require all three
> macros.

Eh? What different semantics? I think I missed something!

Cheers,

Ben.

--
SECURE HOSTING AT THE BUNKER! http://www.thebunker.net/hosting.htm

http://www.apache-ssl.org/ben.html

"My grandfather once told me that there are two kinds of people: those
who work and those who take the credit. He told me to try to be in the
first group; there was less competition there."
     - Indira Gandhi