You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cordova.apache.org by 16BITBoy <gi...@git.apache.org> on 2014/06/13 17:37:32 UTC

[GitHub] cordova-lib pull request: Update hooks-README.md

GitHub user 16BITBoy opened a pull request:

    https://github.com/apache/cordova-lib/pull/28

    Update hooks-README.md

    I think letting know to users of Windows that a shebang line is expected at the start of their non bat scripts is a good idea, since its not typical for Windows users to write shebangs. I found out myself not knowing how to make my python and node.js scripts to work as hooks until I read cordova-lib\src\cordova\hooker.js line 77, function extractSheBangInterpreter.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/16BITBoy/cordova-lib patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/28.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #28
    
----
commit ddb01a6b24772fafc4aec96a7392dd5a68e827ca
Author: A.Perez <ap...@gmail.com>
Date:   2014-06-13T15:30:36Z

    Update hooks-README.md
    
    I think letting know to users of Windows that a shebang line is expected at the start of their non bat scripts is a good idea. I found out myself not knowing how to make my python and node.js scripts to work as hooks until I read cordova-lib\src\cordova\hooker.js line 77, function extractSheBangInterpreter.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-lib pull request: Update hooks-README.md

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-lib/pull/28


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-lib pull request: Update hooks-README.md

Posted by 16BITBoy <gi...@git.apache.org>.

Github user 16BITBoy commented on the pull request:

    https://github.com/apache/cordova-lib/pull/28#issuecomment-46031100
  
    Ok, I've fixed the typo, also rephrased the sentence inside the brackets, and removed the redundant one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-lib pull request: Update hooks-README.md

Posted by kamrik <gi...@git.apache.org>.

Github user kamrik commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/28#discussion_r13758029

--- Diff: cordova-lib/templates/hooks-README.md ---
@@ -81,3 +80,7 @@ cross-platform. Some good examples are shown here:

[http://devgirl.org/2013/11/12/three-hooks-your-cordovaphonegap-project-needs/](http://devgirl.org/2013/11/12/three-hooks-your-cordovaphonegap-project-needs/)

+Also, note that even if you are working on Windows, and in case your hook scripts aren't bat files (which is recomended for use the code in a non-windows operating system) Cordova CLI will expect a shebang line as the first line for it to know the interpreter it needs to use to launch the script, if the script is not a bat file. The shebang line should match the following example:
--- End diff --

Thanks for adding to the README, this sis a good point to mention here. Some minor comments:
1. This needs rephrasing: "... which is recomended for use the code in a non-windows operating system ..."
2. recomMended (missing m)
3. Redundant repeat that doesn't sound good "in case your hook script aren't bat files" .... "if the script is not a bat file"

---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---