You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/02/06 00:54:22 UTC

[GitHub] [tvm] tqchen commented on a change in pull request #7417: [FIX,CMAKE] Only compile runtime files once

tqchen commented on a change in pull request #7417:
URL: https://github.com/apache/tvm/pull/7417#discussion_r571326553



##########
File path: CMakeLists.txt
##########
@@ -371,10 +371,10 @@ endif()
 
 add_lib_info(${CMAKE_CURRENT_LIST_DIR}/src/support/libinfo.cc)
 
-add_library(tvm_objs OBJECT ${COMPILER_SRCS} ${RUNTIME_SRCS})

Review comment:
       decoupling runtime source from`tvm_objs` might require cross check other locations that refers to it. 
   
   e.g. https://github.com/apache/tvm/blob/main/CMakeLists.txt#L396 
   
   So that the runtime source and compiler part build with the same flag




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org