[jira] [Commented] (HADOOP-8549) Allow other implementation's of java.util.Map in MapWritable

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-8549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13405817#comment-13405817 ] 

Hadoop QA commented on HADOOP-8549:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12534668/HADOOP-8549.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified test files.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.ha.TestZKFailoverController
                  org.apache.hadoop.io.file.tfile.TestTFileByteArrays
                  org.apache.hadoop.io.file.tfile.TestTFileJClassComparatorByteArrays

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1164//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1164//console

This message is automatically generated.
                
> Allow other implementation's of java.util.Map in MapWritable
> ------------------------------------------------------------
>
>                 Key: HADOOP-8549
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8549
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: io
>    Affects Versions: 2.0.0-alpha
>            Reporter: madhukara phatak
>            Assignee: madhukara phatak
>            Priority: Minor
>         Attachments: HADOOP-8549.patch
>
>
> Current implementation of MapWritable uses HashMap as Map implementation. But in some of the use cases we need other implementations of Map like LinkedHashMap,SortedMap.This jira changes visibility of 'instance' in MapWritable from private to protected which allows us to inject custom Map implementation through sub classing MapWritable  .  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira