You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by se...@apache.org on 2010/05/11 22:29:48 UTC
svn commit: r943279 -
/httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/
Author: sebb
Date: Tue May 11 20:29:47 2010
New Revision: 943279
URL: http://svn.apache.org/viewvc?rev=943279&view=rev
Log:
Make constants final
Modified:
httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/DoNotTestProtocolRequirements.java
httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/TestCacheEntry.java
httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/TestCacheEntryUpdater.java
httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/TestCachingHttpClient.java
httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/TestProtocolDeviations.java
httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/TestProtocolRequirements.java
Modified: httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/DoNotTestProtocolRequirements.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/DoNotTestProtocolRequirements.java?rev=943279&r1=943278&r2=943279&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/DoNotTestProtocolRequirements.java (original)
+++ httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/DoNotTestProtocolRequirements.java Tue May 11 20:29:47 2010
@@ -54,10 +54,10 @@ import org.junit.Test;
public class DoNotTestProtocolRequirements {
- private static ProtocolVersion HTTP_1_1 = new ProtocolVersion("HTTP", 1, 1);
+ private static final ProtocolVersion HTTP_1_1 = new ProtocolVersion("HTTP", 1, 1);
- private static int MAX_BYTES = 1024;
- private static int MAX_ENTRIES = 100;
+ private static final int MAX_BYTES = 1024;
+ private static final int MAX_ENTRIES = 100;
private HttpHost host;
private HttpEntity mockEntity;
Modified: httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/TestCacheEntry.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/TestCacheEntry.java?rev=943279&r1=943278&r2=943279&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/TestCacheEntry.java (original)
+++ httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/TestCacheEntry.java Tue May 11 20:29:47 2010
@@ -40,7 +40,7 @@ import org.junit.Test;
public class TestCacheEntry {
- private static ProtocolVersion HTTP_1_1 = new ProtocolVersion("HTTP",1,1);
+ private static final ProtocolVersion HTTP_1_1 = new ProtocolVersion("HTTP",1,1);
@Test
public void testGetHeadersReturnsCorrectHeaders() {
Modified: httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/TestCacheEntryUpdater.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/TestCacheEntryUpdater.java?rev=943279&r1=943278&r2=943279&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/TestCacheEntryUpdater.java (original)
+++ httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/TestCacheEntryUpdater.java Tue May 11 20:29:47 2010
@@ -47,7 +47,7 @@ import org.junit.Test;
public class TestCacheEntryUpdater {
- private static ProtocolVersion HTTP_1_1 = new ProtocolVersion("HTTP", 1, 1);
+ private static final ProtocolVersion HTTP_1_1 = new ProtocolVersion("HTTP", 1, 1);
private HttpResponse mockResponse;
Modified: httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/TestCachingHttpClient.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/TestCachingHttpClient.java?rev=943279&r1=943278&r2=943279&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/TestCachingHttpClient.java (original)
+++ httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/TestCachingHttpClient.java Tue May 11 20:29:47 2010
@@ -67,7 +67,7 @@ import org.junit.Test;
public class TestCachingHttpClient {
- private static ProtocolVersion HTTP_1_1 = new ProtocolVersion("HTTP",1,1);
+ private static final ProtocolVersion HTTP_1_1 = new ProtocolVersion("HTTP",1,1);
private static final String GET_CURRENT_DATE = "getCurrentDate";
Modified: httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/TestProtocolDeviations.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/TestProtocolDeviations.java?rev=943279&r1=943278&r2=943279&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/TestProtocolDeviations.java (original)
+++ httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/TestProtocolDeviations.java Tue May 11 20:29:47 2010
@@ -69,8 +69,8 @@ public class TestProtocolDeviations {
private static ProtocolVersion HTTP_1_1 = new ProtocolVersion("HTTP", 1, 1);
- private static int MAX_BYTES = 1024;
- private static int MAX_ENTRIES = 100;
+ private static final int MAX_BYTES = 1024;
+ private static final int MAX_ENTRIES = 100;
private int entityLength = 128;
private HttpHost host;
Modified: httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/TestProtocolRequirements.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/TestProtocolRequirements.java?rev=943279&r1=943278&r2=943279&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/TestProtocolRequirements.java (original)
+++ httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/TestProtocolRequirements.java Tue May 11 20:29:47 2010
@@ -70,10 +70,10 @@ import org.junit.Test;
*/
public class TestProtocolRequirements {
- private static ProtocolVersion HTTP_1_1 = new ProtocolVersion("HTTP", 1, 1);
+ private static final ProtocolVersion HTTP_1_1 = new ProtocolVersion("HTTP", 1, 1);
- private static int MAX_BYTES = 1024;
- private static int MAX_ENTRIES = 100;
+ private static final int MAX_BYTES = 1024;
+ private static final int MAX_ENTRIES = 100;
private int entityLength = 128;
private HttpHost host;