You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Willdotwhite (via GitHub)" <gi...@apache.org> on 2023/06/04 13:46:58 UTC
[GitHub] [solr] Willdotwhite opened a new pull request, #1688: SOLR-16820: Allow semVer style collection names (amongst others)
Willdotwhite opened a new pull request, #1688:
URL: https://github.com/apache/solr/pull/1688
# Description
The previous collection name validation didn't match the validation used in the CreateCollectionAPI, so it was possible to create a collection name (e.g. `foobar-1.2.3`) that wouldn't pass validation at this stage via the `PackageTool` deploy/undeploy commands.
# Solution
Use the existing `SolrIdentifierValidator::validateCollectionName` method and regex to ensure consistency of collection names going forwards.
# Tests
*Request for guidance please*: I haven't attached any unit tests to this PR yet. The `PackageTool` at the head of this workflow doesn't have any existing automated tests that I can find - I'm not sure whether to add a very small scope unit test in the `org.apache.solr.packagemanager` package, or whether that's a bit unhelpful compared to something testing the end-to-end behaviour in `org.apache.solr.cli`, which I'm not sure I'm capable of doing at this stage.
Alternatively, I can upload screenshots of manually-driven tests on my machine if that's a suitable option?
# Concerns / Risks
This PR changes the allowed collection names deployed/undeployed by the `PackageTool`. As discussed on the [PR here](https://issues.apache.org/jira/browse/SOLR-16820) and in [the email thread here](https://lists.apache.org/thread/h7hnksgqwxxl7nkwkhn01r6jn8xjkjjs), the change is mostly widening the allowed options, mitigating the risk of backwards-breaking changes.
That said, *this change _does_ have one backwards-impacting change, which is collections targeted by deploy/undeploy commands can no longer start with a `-` character.*
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #1688: SOLR-16820: Allow semVer style collection names (amongst others)
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #1688:
URL: https://github.com/apache/solr/pull/1688#issuecomment-1584353387
@Willdotwhite how is progress? Any blockers/help you need?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] Willdotwhite commented on a diff in pull request #1688: SOLR-16820: Allow semVer style collection names (amongst others)
Posted by "Willdotwhite (via GitHub)" <gi...@apache.org>.
Willdotwhite commented on code in PR #1688:
URL: https://github.com/apache/solr/pull/1688#discussion_r1217988727
##########
solr/core/src/java/org/apache/solr/packagemanager/PackageUtils.java:
##########
@@ -268,17 +270,8 @@ public static void print(String color, Object message) {
}
public static String[] validateCollections(String collections[]) {
Review Comment:
I can't tell you how badly I wish we had C# LINQ style helpers to just apply to Iterables - something like `.split(/**/).map(/**/).toArray()` would have been **so** much easier to read 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on a diff in pull request #1688: SOLR-16820: Allow semVer style collection names (amongst others)
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on code in PR #1688:
URL: https://github.com/apache/solr/pull/1688#discussion_r1217923953
##########
solr/core/src/java/org/apache/solr/packagemanager/PackageUtils.java:
##########
@@ -268,17 +270,8 @@ public static void print(String color, Object message) {
}
public static String[] validateCollections(String collections[]) {
Review Comment:
Actually, since we have a few places we use it, I think I like the explicit method... Sometimes these stream style metods look a bit too clever!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #1688: SOLR-16820: Allow semVer style collection names (amongst others)
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #1688:
URL: https://github.com/apache/solr/pull/1688#issuecomment-1576604635
i think, once you decide how you want to handle the tests side of this, that it is probably ready for committing ;-)..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] Willdotwhite commented on pull request #1688: SOLR-16820: Allow semVer style collection names (amongst others)
Posted by "Willdotwhite (via GitHub)" <gi...@apache.org>.
Willdotwhite commented on PR #1688:
URL: https://github.com/apache/solr/pull/1688#issuecomment-1591837665
Ahhh, so the current setup of the BATS tests is quite tightly pinned to MacOS/Linux (unsurprisingly), and I'm having a very tough time getting anywhere on the Windows machine I'm using now (regarding the whole unstable OS thing above) 😬
I might have to write the tests blindly on this machine and find a willing volunteer to help me verify/get evidence of them all going green, or something similar. I'll figure out the second half of that puzzle another day 😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] Willdotwhite commented on a diff in pull request #1688: SOLR-16820: Allow semVer style collection names (amongst others)
Posted by "Willdotwhite (via GitHub)" <gi...@apache.org>.
Willdotwhite commented on code in PR #1688:
URL: https://github.com/apache/solr/pull/1688#discussion_r1231377813
##########
solr/packaging/test/test_packages.bats:
##########
@@ -40,9 +40,29 @@ teardown() {
run solr package
refute_output --partial "No Solr nodes are running."
- run solr package -help
+ run solr package help
assert_output --partial "Add a repository to Solr"
run solr package list-available
assert_output --partial "Available packages:"
}
+
+@test "deploying and undeploying of packages" {
+ run solr start -c -Denable.packages=true
+
+ run solr package
+ refute_output --partial "No Solr nodes are running."
+
+ run solr package help
+ assert_output --partial "Bootstraps a previously installed package"
+ assert_output --partial "Undeploys a package from specified collection(s)"
+
+ # Deploy package - the package doesn't need to exist before the collection validation kicks in
+ run solr package deploy PACKAGE_NAME -collections foo-1.2
+ # assert_output --partial "Deployment successful"
Review Comment:
I can't get these working on Windows, so I don't know if there'll be any positive output to assert for (I expect not), but this is here in case it turns out there's something usable in the log output when someone is able to get tests running :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1688: SOLR-16820: Allow semVer style collection names (amongst others)
Posted by "risdenk (via GitHub)" <gi...@apache.org>.
risdenk commented on PR #1688:
URL: https://github.com/apache/solr/pull/1688#issuecomment-1601168627
@epugh merged main into this branch and fixed the CHANGES.txt merge conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] Willdotwhite commented on a diff in pull request #1688: SOLR-16820: Allow semVer style collection names (amongst others)
Posted by "Willdotwhite (via GitHub)" <gi...@apache.org>.
Willdotwhite commented on code in PR #1688:
URL: https://github.com/apache/solr/pull/1688#discussion_r1217711029
##########
solr/core/src/java/org/apache/solr/packagemanager/PackageUtils.java:
##########
@@ -268,17 +270,8 @@ public static void print(String color, Object message) {
}
public static String[] validateCollections(String collections[]) {
Review Comment:
This method is used in two locations, in only one file: the [PackageTool deploy](https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/cli/PackageTool.java#L184) and [PackageTool undeploy](https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/cli/PackageTool.java#L214) methods.
We could remove this method entirely and use something like this inline:
```java
Arrays.stream(cli.getOptionValue("collections").split(","))
.map(SolrIdentifierValidator::validateCollectionName)
.toArray(String[]::new)
```
in both locations, although I sincerely hope there's a slightly shorter approach I've not thought of yet!
We could do something a bit less packed together given that `String[] collections` isn't final, but that'd take a bit more work to make sure it doesn't get a bit lengthy or involve multiple short-lived arrays.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #1688: SOLR-16820: Allow semVer style collection names (amongst others)
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #1688:
URL: https://github.com/apache/solr/pull/1688#issuecomment-1599140583
Looks like one bats test failing... ` not ok 39 deploying and undeploying of packages in 9987ms`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #1688: SOLR-16820: Allow semVer style collection names (amongst others)
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #1688:
URL: https://github.com/apache/solr/pull/1688#issuecomment-1602511534
thank you so MUCH @risdenk for untangling my commits. If couldn't tell, I was getting frustrated ;-). I've run things locally, so going to commit now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] Willdotwhite commented on a diff in pull request #1688: SOLR-16820: Allow semVer style collection names (amongst others)
Posted by "Willdotwhite (via GitHub)" <gi...@apache.org>.
Willdotwhite commented on code in PR #1688:
URL: https://github.com/apache/solr/pull/1688#discussion_r1217711029
##########
solr/core/src/java/org/apache/solr/packagemanager/PackageUtils.java:
##########
@@ -268,17 +270,8 @@ public static void print(String color, Object message) {
}
public static String[] validateCollections(String collections[]) {
Review Comment:
Only in one other file: [PackageTool deploy](https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/cli/PackageTool.java#L184) and [PackageTool undeploy](https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/cli/PackageTool.java#L214).
We could remove this method entirely and use something like this inline:
```java
Arrays.stream(cli.getOptionValue("collections").split(","))
.map(SolrIdentifierValidator::validateCollectionName)
.toArray(String[]::new)
```
in both locations, although I sincerely hope there's a slightly shorter approach I've not thought of yet!
We could do something a bit less packed together given that `String[] collections` isn't final, but that'd take a bit more work to make sure it doesn't get a bit lengthy or involve multiple short-lived arrays.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] Willdotwhite commented on pull request #1688: SOLR-16820: Allow semVer style collection names (amongst others)
Posted by "Willdotwhite (via GitHub)" <gi...@apache.org>.
Willdotwhite commented on PR #1688:
URL: https://github.com/apache/solr/pull/1688#issuecomment-1576674220
> i think, once you decide how you want to handle the tests side of this, that it is probably ready for committing ;-)..
I'll be starting with [the BATS tests](https://lists.apache.org/thread/f6g4t6dloxm1r6yjp9lfh7dwhl2lnrl6) and see how I go from there :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] Willdotwhite commented on pull request #1688: SOLR-16820: Allow semVer style collection names (amongst others)
Posted by "Willdotwhite (via GitHub)" <gi...@apache.org>.
Willdotwhite commented on PR #1688:
URL: https://github.com/apache/solr/pull/1688#issuecomment-1593521954
> @Willdotwhite I'd be happy to test out your Bats tests for you.. If you get something down, even if it's rough, I can probably get it over the finish line.
>
> On an interesting side note, I am in the opposite situation! I have two PR's that change the Solr CLI code, and I need to get them tested on Windows. I'll tag you on those issues if you want to give them a test ;-).
>
> This PR is a nice fix, so let's make sure that challenges in testing don't derail getting it merged soon ;-).
Cheers @epugh , that's a neat solution, thanks for the support! I've taken a quick look at the simpler of the two, will look at the bigger PR when I've got a bit more time to dive into it 👍🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on a diff in pull request #1688: SOLR-16820: Allow semVer style collection names (amongst others)
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on code in PR #1688:
URL: https://github.com/apache/solr/pull/1688#discussion_r1216911634
##########
solr/core/src/java/org/apache/solr/packagemanager/PackageUtils.java:
##########
@@ -268,17 +270,8 @@ public static void print(String color, Object message) {
}
public static String[] validateCollections(String collections[]) {
Review Comment:
out of curisioty, is this method `validateCollections` called from multiple places? If not, maybe best to just eliminate it all together ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #1688: SOLR-16820: Allow semVer style collection names (amongst others)
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #1688:
URL: https://github.com/apache/solr/pull/1688#issuecomment-1597365359
I will commit this tomorrow hopefully...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] Willdotwhite commented on pull request #1688: SOLR-16820: Allow semVer style collection names (amongst others)
Posted by "Willdotwhite (via GitHub)" <gi...@apache.org>.
Willdotwhite commented on PR #1688:
URL: https://github.com/apache/solr/pull/1688#issuecomment-1601496528
Thanks both, your input has been amazing. What else does this PR need before it's ready to go?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] Willdotwhite commented on pull request #1688: SOLR-16820: Allow semVer style collection names (amongst others)
Posted by "Willdotwhite (via GitHub)" <gi...@apache.org>.
Willdotwhite commented on PR #1688:
URL: https://github.com/apache/solr/pull/1688#issuecomment-1590637737
Sorry @epugh - I've learned two things since my last comment:
- One is that I don't get email notifications from this PR, sorry for the radio silence!
- My previous OS was getting increasingly unstable, so there's been a bit of a gap while I've had to start again from scratch; running the tests for Solr (among other non-controversial tasks) would frequently crash my computer!
I should be good to get started on this again tonight as it happens, so hopefully I'll have a first pass at BATS tests within 12 hours 🤞🏻
Sorry again for the lack of an update, I'll try and sort my notification rules for this repo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #1688: SOLR-16820: Allow semVer style collection names (amongst others)
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #1688:
URL: https://github.com/apache/solr/pull/1688#issuecomment-1592154572
@Willdotwhite I'd be happy to test out your Bats tests for you.. If you get something down, even if it's rough, I can probably get it over the finish line.
On an interesting side note, I am in the opposite situation! I have two PR's that change the Solr CLI code, and I need to get them tested on Windows. I'll tag you on those issues if you want to give them a test ;-).
This PR is a nice fix, so let's make sure that challenges in testing don't derail getting it merged soon ;-).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1688: SOLR-16820: Allow semVer style collection names (amongst others)
Posted by "risdenk (via GitHub)" <gi...@apache.org>.
risdenk commented on PR #1688:
URL: https://github.com/apache/solr/pull/1688#issuecomment-1601186274
Crave is expected to fail since it can't handle brach merges.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh merged pull request #1688: SOLR-16820: Allow semVer style collection names (amongst others)
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh merged PR #1688:
URL: https://github.com/apache/solr/pull/1688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on a diff in pull request #1688: SOLR-16820: Allow semVer style collection names (amongst others)
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on code in PR #1688:
URL: https://github.com/apache/solr/pull/1688#discussion_r1237045031
##########
solr/packaging/test/test_packages.bats:
##########
@@ -40,9 +40,29 @@ teardown() {
run solr package
refute_output --partial "No Solr nodes are running."
- run solr package -help
+ run solr package help
assert_output --partial "Add a repository to Solr"
run solr package list-available
assert_output --partial "Available packages:"
}
+
+@test "deploying and undeploying of packages" {
+ run solr start -c -Denable.packages=true
+
+ run solr package
+ refute_output --partial "No Solr nodes are running."
+
+ run solr package help
+ assert_output --partial "Bootstraps a previously installed package"
+ assert_output --partial "Undeploys a package from specified collection(s)"
+
+ # Deploy package - the package doesn't need to exist before the collection validation kicks in
+ run solr package deploy PACKAGE_NAME -collections foo-1.2
+ # assert_output --partial "Deployment successful"
Review Comment:
okay, taking a looksee now...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org