You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/10/27 00:04:00 UTC
[GitHub] [dubbo] pinxiong opened a new pull request #9138: [Feature] Support the global registry center in unit tests
pinxiong opened a new pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138
## What is the purpose of the change
see #9137
## Brief changelog
Support the global registry center in unit tests
## Verifying this change
1. Remove all imported zookeeper instances
2. Implementation the started and finished event to manange zookeeper instance when run unit tests
3. Filter unnecessary package name to avoid to start and stop zookeeper instances in unit tests
<!-- Follow this checklist to help us incorporate your contribution quickly and easily: -->
## Checklist
- [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
- [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature.
- [x] GitHub Actions works fine on your own branch.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952441180
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9138](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bd43971) into [3.0](https://codecov.io/gh/apache/dubbo/commit/cd221993aa07391419a255cb39f02ad7366922e7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cd22199) will **decrease** coverage by `0.37%`.
> The diff coverage is `8.96%`.
[](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9138 +/- ##
============================================
- Coverage 64.94% 64.57% -0.38%
- Complexity 315 327 +12
============================================
Files 1177 1185 +8
Lines 50918 51022 +104
Branches 7578 7569 -9
============================================
- Hits 33069 32946 -123
- Misses 14260 14474 +214
- Partials 3589 3602 +13
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dubbo/test/check/exception/DubboTestException.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL2V4Y2VwdGlvbi9EdWJib1Rlc3RFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...est/check/registrycenter/MockedRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL01vY2tlZFJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...gistrycenter/initializer/ZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...istrycenter/processor/ResetZookeeperProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9SZXNldFpvb2tlZXBlclByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nter/processor/StartZookeeperCommandProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlckNvbW1hbmRQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...enter/processor/StopZookeeperCommandProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdG9wWm9va2VlcGVyQ29tbWFuZFByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [56 more](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cd22199...bd43971](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952441180
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9138](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8fc4768) into [3.0](https://codecov.io/gh/apache/dubbo/commit/94e26b4c4a2379ec01fa29ee2d9daf0baad41dcc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94e26b4) will **decrease** coverage by `0.38%`.
> The diff coverage is `5.92%`.
[](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9138 +/- ##
============================================
- Coverage 65.38% 64.99% -0.39%
- Complexity 313 327 +14
============================================
Files 1188 1203 +15
Lines 51448 51731 +283
Branches 7690 7718 +28
============================================
- Hits 33638 33622 -16
- Misses 14189 14484 +295
- Partials 3621 3625 +4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dubbo/test/check/exception/DubboTestException.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL2V4Y2VwdGlvbi9EdWJib1Rlc3RFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...est/check/registrycenter/MockedRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL01vY2tlZFJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...egistrycenter/context/ZookeeperWindowsContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyV2luZG93c0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...gistrycenter/initializer/ZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...istrycenter/processor/FindPidWindowsProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9GaW5kUGlkV2luZG93c1Byb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [37 more](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [94e26b4...8fc4768](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#discussion_r743653313
##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/MockedRegistryCenter.java
##########
@@ -21,6 +21,16 @@
*/
public class MockedRegistryCenter {
+ /**
+ * The first global zookeeper address
+ */
+ public static final String ZOOKEEPER_ADDRESS1 = "zookeeper://127.0.0.1:2181";
Review comment:
The global zookeeper address configs should not mixed with embedded zk server, extract them into a outer class.
Furthermore, I thank it's better to append the zk server address and port configs to system props, such as:
```
zookeeper.address=zookeeper://127.0.0.1:2181
zookeeper.port=2181
zookeeper.address.1=zookeeper://127.0.0.1:2181
zookeeper.port.1=2181
zookeeper.address.2=zookeeper://127.0.0.1:2181
zookeeper.port.2=2181
```
So we can use them in Spring application.properties/yaml:
```
dubbo.registry.address=${zookeeper.address}
dubbo.registries.second-registry.address=${zookeeper.address.2}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#discussion_r737149224
##########
File path: dubbo-test/dubbo-test-check/src/main/resources/META-INF/services/org.junit.platform.launcher.TestExecutionListener
##########
@@ -1 +1,5 @@
+# DubboRegistryCenterStarted should be the first one because of the startup of zookeeper
+org.apache.dubbo.test.check.RegistryCenterStarted
Review comment:
`RegistryCenterStarted` and `RegistryCenterFinished` can merge into single `TestExecutionListener`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] pinxiong commented on a change in pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
pinxiong commented on a change in pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#discussion_r743421794
##########
File path: dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/integration/multiple/exportmetadata/MultipleRegistryCenterExportMetadataIntegrationTest.java
##########
@@ -99,13 +91,9 @@ public void setUp() throws Exception {
DubboBootstrap.getInstance()
.application(new ApplicationConfig(PROVIDER_APPLICATION_NAME))
.protocol(new ProtocolConfig(PROTOCOL_NAME))
- .service(serviceConfig);
- for (RegistryCenter.Instance instance : registryCenter.getRegistryCenterInstance()) {
- DubboBootstrap.getInstance().registry(new RegistryConfig(String.format("%s://%s:%s",
- instance.getType(),
- instance.getHostname(),
- instance.getPort())));
- }
+ .service(serviceConfig)
+ .registry(new RegistryConfig("zookeeper://127.0.0.1:2181"))
+ .registry(new RegistryConfig("zookeeper://127.0.0.1:2182"));
Review comment:
That's a good seggustion! However, all local `zooKeeper connection strings` aren't displayed clearly, especially using Spring configuration or annotation.
But I've supported this feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952441180
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9138](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8fc4768) into [3.0](https://codecov.io/gh/apache/dubbo/commit/94e26b4c4a2379ec01fa29ee2d9daf0baad41dcc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94e26b4) will **decrease** coverage by `0.35%`.
> The diff coverage is `5.92%`.
[](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9138 +/- ##
============================================
- Coverage 65.38% 65.03% -0.36%
- Complexity 313 328 +15
============================================
Files 1188 1203 +15
Lines 51448 51731 +283
Branches 7690 7718 +28
============================================
+ Hits 33638 33641 +3
- Misses 14189 14468 +279
- Partials 3621 3622 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dubbo/test/check/exception/DubboTestException.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL2V4Y2VwdGlvbi9EdWJib1Rlc3RFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...est/check/registrycenter/MockedRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL01vY2tlZFJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...egistrycenter/context/ZookeeperWindowsContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyV2luZG93c0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...gistrycenter/initializer/ZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...istrycenter/processor/FindPidWindowsProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9GaW5kUGlkV2luZG93c1Byb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [35 more](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [94e26b4...8fc4768](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952441180
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9138](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (08e2c30) into [3.0](https://codecov.io/gh/apache/dubbo/commit/295f2a767f1a2dd812e955bff8c5efb0eb97fd3f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (295f2a7) will **decrease** coverage by `0.31%`.
> The diff coverage is `5.99%`.
[](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9138 +/- ##
============================================
- Coverage 65.16% 64.84% -0.32%
- Complexity 313 329 +16
============================================
Files 1188 1203 +15
Lines 51424 51727 +303
Branches 7684 7719 +35
============================================
+ Hits 33509 33544 +35
- Misses 14296 14568 +272
+ Partials 3619 3615 -4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dubbo/test/check/exception/DubboTestException.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL2V4Y2VwdGlvbi9EdWJib1Rlc3RFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...est/check/registrycenter/MockedRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL01vY2tlZFJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...egistrycenter/context/ZookeeperWindowsContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyV2luZG93c0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...gistrycenter/initializer/ZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...istrycenter/processor/FindPidWindowsProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9GaW5kUGlkV2luZG93c1Byb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [37 more](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [295f2a7...08e2c30](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#discussion_r743410711
##########
File path: dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/integration/multiple/exportmetadata/MultipleRegistryCenterExportMetadataIntegrationTest.java
##########
@@ -99,13 +91,9 @@ public void setUp() throws Exception {
DubboBootstrap.getInstance()
.application(new ApplicationConfig(PROVIDER_APPLICATION_NAME))
.protocol(new ProtocolConfig(PROTOCOL_NAME))
- .service(serviceConfig);
- for (RegistryCenter.Instance instance : registryCenter.getRegistryCenterInstance()) {
- DubboBootstrap.getInstance().registry(new RegistryConfig(String.format("%s://%s:%s",
- instance.getType(),
- instance.getHostname(),
- instance.getPort())));
- }
+ .service(serviceConfig)
+ .registry(new RegistryConfig("zookeeper://127.0.0.1:2181"))
+ .registry(new RegistryConfig("zookeeper://127.0.0.1:2182"));
Review comment:
Is it possible to define global zk server port/address variables and then quote them in test? It is better not to use the port 2181 by default to avoid port conflicts on the zk server. Just a suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] pinxiong commented on a change in pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
pinxiong commented on a change in pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#discussion_r743423904
##########
File path: dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/integration/multiple/exportmetadata/MultipleRegistryCenterExportMetadataIntegrationTest.java
##########
@@ -99,13 +91,9 @@ public void setUp() throws Exception {
DubboBootstrap.getInstance()
.application(new ApplicationConfig(PROVIDER_APPLICATION_NAME))
.protocol(new ProtocolConfig(PROTOCOL_NAME))
- .service(serviceConfig);
- for (RegistryCenter.Instance instance : registryCenter.getRegistryCenterInstance()) {
- DubboBootstrap.getInstance().registry(new RegistryConfig(String.format("%s://%s:%s",
- instance.getType(),
- instance.getHostname(),
- instance.getPort())));
- }
+ .service(serviceConfig)
+ .registry(new RegistryConfig("zookeeper://127.0.0.1:2181"))
+ .registry(new RegistryConfig("zookeeper://127.0.0.1:2182"));
Review comment:
The best way is to define two client ports (which might not be `2181` and `2182`) and quote them when using. However, there are so many hard code in unit test. So, it's very diffcult to change anywhere.
such as some zookeeper connection string in properties file
```java
dubbo.registry.address=zookeeper://127.0.0.1:2181?registry-type=service
biz.group=greeting
biz.group2=group2
dubbo.call-timeout=2000
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#discussion_r738145984
##########
File path: dubbo-test/dubbo-test-check/src/main/resources/META-INF/services/org.junit.platform.launcher.TestExecutionListener
##########
@@ -1 +1,5 @@
+# DubboRegistryCenterStarted should be the first one because of the startup of zookeeper
+org.apache.dubbo.test.check.RegistryCenterStarted
Review comment:
When enable thread checking by `-DcheckThreads=true`, `DubboTestChecker` will dump threads after finished each test class. The embedded zk server will also create some threads, such as creating a new netty thread when establishing a connection, which will interfere with the thread check of dubbo test. Is it possible to start zk server in a separate process?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] pinxiong commented on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
pinxiong commented on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952643584
> Did you clean up the data in the registry center after executing each test method? No related processing found.
That's a good idea! I'll support it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952441180
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9138](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d3e2618) into [3.0](https://codecov.io/gh/apache/dubbo/commit/cd221993aa07391419a255cb39f02ad7366922e7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cd22199) will **decrease** coverage by `0.23%`.
> The diff coverage is `8.51%`.
[](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9138 +/- ##
============================================
- Coverage 64.94% 64.70% -0.24%
- Complexity 315 327 +12
============================================
Files 1177 1185 +8
Lines 50918 51061 +143
Branches 7578 7600 +22
============================================
- Hits 33069 33041 -28
- Misses 14260 14419 +159
- Partials 3589 3601 +12
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dubbo/test/check/exception/DubboTestException.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL2V4Y2VwdGlvbi9EdWJib1Rlc3RFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...est/check/registrycenter/MockedRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL01vY2tlZFJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...gistrycenter/initializer/ZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...istrycenter/processor/ResetZookeeperProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9SZXNldFpvb2tlZXBlclByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nter/processor/StartZookeeperCommandProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlckNvbW1hbmRQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...enter/processor/StopZookeeperCommandProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdG9wWm9va2VlcGVyQ29tbWFuZFByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [40 more](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cd22199...d3e2618](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952441180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] pinxiong commented on a change in pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
pinxiong commented on a change in pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#discussion_r743412001
##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/processor/KillProcessWindowsProcessor.java
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dubbo.test.check.registrycenter.processor;
+
+import org.apache.commons.exec.CommandLine;
+import org.apache.commons.exec.DefaultExecutor;
+import org.apache.commons.exec.Executor;
+import org.apache.commons.exec.PumpStreamHandler;
+import org.apache.dubbo.common.logger.Logger;
+import org.apache.dubbo.common.logger.LoggerFactory;
+import org.apache.dubbo.test.check.exception.DubboTestException;
+import org.apache.dubbo.test.check.registrycenter.context.ZookeeperWindowsContext;
+
+import java.io.IOException;
+
+/**
+ * Create a {@link org.apache.dubbo.test.check.registrycenter.Processor} to kill pid on Windows OS.
+ */
+public class KillProcessWindowsProcessor extends ZookeeperWindowsProcessor {
+
+ private static final Logger logger = LoggerFactory.getLogger(KillProcessWindowsProcessor.class);
+
+ @Override
+ protected void doProcess(ZookeeperWindowsContext context) throws DubboTestException {
+ for (int clientPort : context.getClientPorts()) {
+ Integer pid = context.getPid(clientPort);
Review comment:
OK, I've removed the killed pid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952441180
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9138](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7325139) into [3.0](https://codecov.io/gh/apache/dubbo/commit/94e26b4c4a2379ec01fa29ee2d9daf0baad41dcc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94e26b4) will **decrease** coverage by `0.38%`.
> The diff coverage is `5.41%`.
[](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9138 +/- ##
============================================
- Coverage 65.38% 64.99% -0.39%
- Complexity 313 328 +15
============================================
Files 1188 1206 +18
Lines 51448 51775 +327
Branches 7690 7721 +31
============================================
+ Hits 33638 33653 +15
- Misses 14189 14497 +308
- Partials 3621 3625 +4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dubbo/test/check/exception/DubboTestException.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL2V4Y2VwdGlvbi9EdWJib1Rlc3RFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...apache/dubbo/test/check/registrycenter/Config.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL0NvbmZpZy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...est/check/registrycenter/GlobalRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL0dsb2JhbFJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...eck/registrycenter/GlobalRegistryCenterConfig.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL0dsb2JhbFJlZ2lzdHJ5Q2VudGVyQ29uZmlnLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...t/check/registrycenter/config/ZookeeperConfig.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbmZpZy9ab29rZWVwZXJDb25maWcuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...egistrycenter/context/ZookeeperWindowsContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyV2luZG93c0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [37 more](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [94e26b4...7325139](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] pinxiong commented on a change in pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
pinxiong commented on a change in pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#discussion_r743359356
##########
File path: dubbo-test/dubbo-test-check/src/main/resources/META-INF/services/org.junit.platform.launcher.TestExecutionListener
##########
@@ -1 +1,5 @@
+# DubboRegistryCenterStarted should be the first one because of the startup of zookeeper
+org.apache.dubbo.test.check.RegistryCenterStarted
Review comment:
> Pls add JVM arg to disable embedded zk server, allow users to use external zk server.
It's done.
##########
File path: dubbo-test/dubbo-test-check/src/main/resources/META-INF/services/org.junit.platform.launcher.TestExecutionListener
##########
@@ -1 +1,5 @@
+# DubboRegistryCenterStarted should be the first one because of the startup of zookeeper
+org.apache.dubbo.test.check.RegistryCenterStarted
Review comment:
> When enable thread checking by `-DcheckThreads=true`, `DubboTestChecker` will dump threads after finished each test class. The embedded zk server will also create some threads, such as creating a new netty thread when establishing a connection, which will interfere with the thread check of dubbo test. Is it possible to start zk server in a separate process?
Now, it can use a dependent process to start zookeeper server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952441180
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9138](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6ab1fec) into [3.0](https://codecov.io/gh/apache/dubbo/commit/cd221993aa07391419a255cb39f02ad7366922e7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cd22199) will **decrease** coverage by `0.32%`.
> The diff coverage is `6.02%`.
[](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9138 +/- ##
============================================
- Coverage 64.94% 64.62% -0.33%
- Complexity 315 326 +11
============================================
Files 1177 1203 +26
Lines 50918 51686 +768
Branches 7578 7681 +103
============================================
+ Hits 33069 33402 +333
- Misses 14260 14647 +387
- Partials 3589 3637 +48
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dubbo/test/check/exception/DubboTestException.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL2V4Y2VwdGlvbi9EdWJib1Rlc3RFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...est/check/registrycenter/MockedRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL01vY2tlZFJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...egistrycenter/context/ZookeeperWindowsContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyV2luZG93c0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...gistrycenter/initializer/ZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...istrycenter/processor/FindPidWindowsProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9GaW5kUGlkV2luZG93c1Byb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [101 more](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cd22199...6ab1fec](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] pinxiong commented on a change in pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
pinxiong commented on a change in pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#discussion_r744059965
##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/MockedRegistryCenter.java
##########
@@ -21,6 +21,16 @@
*/
public class MockedRegistryCenter {
+ /**
+ * The first global zookeeper address
+ */
+ public static final String ZOOKEEPER_ADDRESS1 = "zookeeper://127.0.0.1:2181";
Review comment:
`zookeeper.address` has been used as zookeeper's host. I define a new properties key `zookeeper.connection.address`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952441180
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9138](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7325139) into [3.0](https://codecov.io/gh/apache/dubbo/commit/94e26b4c4a2379ec01fa29ee2d9daf0baad41dcc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94e26b4) will **decrease** coverage by `0.43%`.
> The diff coverage is `5.41%`.
[](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9138 +/- ##
============================================
- Coverage 65.38% 64.94% -0.44%
- Complexity 313 328 +15
============================================
Files 1188 1206 +18
Lines 51448 51739 +291
Branches 7690 7688 -2
============================================
- Hits 33638 33603 -35
- Misses 14189 14502 +313
- Partials 3621 3634 +13
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dubbo/test/check/exception/DubboTestException.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL2V4Y2VwdGlvbi9EdWJib1Rlc3RFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...apache/dubbo/test/check/registrycenter/Config.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL0NvbmZpZy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...est/check/registrycenter/GlobalRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL0dsb2JhbFJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...eck/registrycenter/GlobalRegistryCenterConfig.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL0dsb2JhbFJlZ2lzdHJ5Q2VudGVyQ29uZmlnLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...t/check/registrycenter/config/ZookeeperConfig.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbmZpZy9ab29rZWVwZXJDb25maWcuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...egistrycenter/context/ZookeeperWindowsContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyV2luZG93c0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [63 more](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [94e26b4...7325139](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952441180
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9138](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8b44590) into [3.0](https://codecov.io/gh/apache/dubbo/commit/94e26b4c4a2379ec01fa29ee2d9daf0baad41dcc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94e26b4) will **decrease** coverage by `0.44%`.
> The diff coverage is `5.41%`.
[](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9138 +/- ##
============================================
- Coverage 65.38% 64.93% -0.45%
- Complexity 313 328 +15
============================================
Files 1188 1206 +18
Lines 51448 51775 +327
Branches 7690 7721 +31
============================================
- Hits 33638 33619 -19
- Misses 14189 14524 +335
- Partials 3621 3632 +11
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dubbo/test/check/exception/DubboTestException.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL2V4Y2VwdGlvbi9EdWJib1Rlc3RFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...apache/dubbo/test/check/registrycenter/Config.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL0NvbmZpZy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...est/check/registrycenter/GlobalRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL0dsb2JhbFJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...t/check/registrycenter/config/ZookeeperConfig.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbmZpZy9ab29rZWVwZXJDb25maWcuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...rycenter/config/ZookeeperRegistryCenterConfig.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbmZpZy9ab29rZWVwZXJSZWdpc3RyeUNlbnRlckNvbmZpZy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...egistrycenter/context/ZookeeperWindowsContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyV2luZG93c0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [40 more](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [94e26b4...8b44590](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952441180
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9138](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bd43971) into [3.0](https://codecov.io/gh/apache/dubbo/commit/cd221993aa07391419a255cb39f02ad7366922e7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cd22199) will **decrease** coverage by `0.32%`.
> The diff coverage is `8.96%`.
[](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9138 +/- ##
============================================
- Coverage 64.94% 64.62% -0.33%
- Complexity 315 327 +12
============================================
Files 1177 1185 +8
Lines 50918 51058 +140
Branches 7578 7598 +20
============================================
- Hits 33069 32996 -73
- Misses 14260 14469 +209
- Partials 3589 3593 +4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dubbo/test/check/exception/DubboTestException.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL2V4Y2VwdGlvbi9EdWJib1Rlc3RFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...est/check/registrycenter/MockedRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL01vY2tlZFJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...gistrycenter/initializer/ZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...istrycenter/processor/ResetZookeeperProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9SZXNldFpvb2tlZXBlclByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nter/processor/StartZookeeperCommandProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlckNvbW1hbmRQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...enter/processor/StopZookeeperCommandProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdG9wWm9va2VlcGVyQ29tbWFuZFByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [27 more](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cd22199...bd43971](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952441180
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9138](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (59a9421) into [3.0](https://codecov.io/gh/apache/dubbo/commit/94e26b4c4a2379ec01fa29ee2d9daf0baad41dcc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94e26b4) will **decrease** coverage by `0.44%`.
> The diff coverage is `5.93%`.
> :exclamation: Current head 59a9421 differs from pull request most recent head d1eb7af. Consider uploading reports for the commit d1eb7af to get more accurate results
[](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9138 +/- ##
============================================
- Coverage 65.38% 64.94% -0.45%
- Complexity 313 330 +17
============================================
Files 1188 1203 +15
Lines 51448 51695 +247
Branches 7690 7685 -5
============================================
- Hits 33638 33572 -66
- Misses 14189 14488 +299
- Partials 3621 3635 +14
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dubbo/test/check/exception/DubboTestException.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL2V4Y2VwdGlvbi9EdWJib1Rlc3RFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...est/check/registrycenter/MockedRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL01vY2tlZFJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...egistrycenter/context/ZookeeperWindowsContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyV2luZG93c0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...gistrycenter/initializer/ZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...istrycenter/processor/FindPidWindowsProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9GaW5kUGlkV2luZG93c1Byb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [65 more](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [94e26b4...d1eb7af](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#discussion_r743653313
##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/MockedRegistryCenter.java
##########
@@ -21,6 +21,16 @@
*/
public class MockedRegistryCenter {
+ /**
+ * The first global zookeeper address
+ */
+ public static final String ZOOKEEPER_ADDRESS1 = "zookeeper://127.0.0.1:2181";
Review comment:
The global zookeeper address configs should not mixed with embedded zk server, extract them into a outer class.
Furthermore, I thank it's better to append the zk server address and port configs to system props, such as:
```
zookeeper.address=zookeeper://127.0.0.1:2181
zookeeper.port=2181
zookeeper.address.1=zookeeper://127.0.0.1:2181
zookeeper.port.1=2181
zookeeper.address.2=zookeeper://127.0.0.1:2182
zookeeper.port.2=2182
```
So we can use them in Spring application.properties/yaml:
```
dubbo.registry.address=${zookeeper.address}
dubbo.registries.second-registry.address=${zookeeper.address.2}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952441180
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9138](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a83d42c) into [3.0](https://codecov.io/gh/apache/dubbo/commit/cd221993aa07391419a255cb39f02ad7366922e7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cd22199) will **decrease** coverage by `0.24%`.
> The diff coverage is `7.16%`.
[](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9138 +/- ##
============================================
- Coverage 64.94% 64.70% -0.25%
- Complexity 315 325 +10
============================================
Files 1177 1201 +24
Lines 50918 51572 +654
Branches 7578 7664 +86
============================================
+ Hits 33069 33369 +300
- Misses 14260 14564 +304
- Partials 3589 3639 +50
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dubbo/test/check/exception/DubboTestException.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL2V4Y2VwdGlvbi9EdWJib1Rlc3RFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...est/check/registrycenter/MockedRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL01vY2tlZFJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...egistrycenter/context/ZookeeperWindowsContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyV2luZG93c0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...gistrycenter/initializer/ZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...istrycenter/processor/ResetZookeeperProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9SZXNldFpvb2tlZXBlclByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [109 more](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cd22199...a83d42c](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952441180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952441180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs edited a comment on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
kylixs edited a comment on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952612445
Did you clean up the data in the registry center after executing each test method? No related processing found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952441180
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9138](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d3e2618) into [3.0](https://codecov.io/gh/apache/dubbo/commit/cd221993aa07391419a255cb39f02ad7366922e7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cd22199) will **decrease** coverage by `0.38%`.
> The diff coverage is `8.51%`.
[](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9138 +/- ##
============================================
- Coverage 64.94% 64.55% -0.39%
- Complexity 315 326 +11
============================================
Files 1177 1185 +8
Lines 50918 51025 +107
Branches 7578 7571 -7
============================================
- Hits 33069 32941 -128
- Misses 14260 14481 +221
- Partials 3589 3603 +14
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dubbo/test/check/exception/DubboTestException.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL2V4Y2VwdGlvbi9EdWJib1Rlc3RFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...est/check/registrycenter/MockedRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL01vY2tlZFJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...gistrycenter/initializer/ZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...istrycenter/processor/ResetZookeeperProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9SZXNldFpvb2tlZXBlclByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nter/processor/StartZookeeperCommandProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlckNvbW1hbmRQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...enter/processor/StopZookeeperCommandProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdG9wWm9va2VlcGVyQ29tbWFuZFByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [55 more](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cd22199...d3e2618](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952441180
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9138](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8fc4768) into [3.0](https://codecov.io/gh/apache/dubbo/commit/94e26b4c4a2379ec01fa29ee2d9daf0baad41dcc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94e26b4) will **decrease** coverage by `0.31%`.
> The diff coverage is `5.92%`.
[](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9138 +/- ##
============================================
- Coverage 65.38% 65.06% -0.32%
- Complexity 313 328 +15
============================================
Files 1188 1203 +15
Lines 51448 51731 +283
Branches 7690 7718 +28
============================================
+ Hits 33638 33661 +23
- Misses 14189 14447 +258
- Partials 3621 3623 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dubbo/test/check/exception/DubboTestException.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL2V4Y2VwdGlvbi9EdWJib1Rlc3RFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...est/check/registrycenter/MockedRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL01vY2tlZFJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...egistrycenter/context/ZookeeperWindowsContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyV2luZG93c0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...gistrycenter/initializer/ZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...istrycenter/processor/FindPidWindowsProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9GaW5kUGlkV2luZG93c1Byb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [33 more](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [94e26b4...8fc4768](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] pinxiong commented on a change in pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
pinxiong commented on a change in pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#discussion_r743359356
##########
File path: dubbo-test/dubbo-test-check/src/main/resources/META-INF/services/org.junit.platform.launcher.TestExecutionListener
##########
@@ -1 +1,5 @@
+# DubboRegistryCenterStarted should be the first one because of the startup of zookeeper
+org.apache.dubbo.test.check.RegistryCenterStarted
Review comment:
> Pls add JVM arg to disable embedded zk server, allow users to use external zk server.
It's done.
##########
File path: dubbo-test/dubbo-test-check/src/main/resources/META-INF/services/org.junit.platform.launcher.TestExecutionListener
##########
@@ -1 +1,5 @@
+# DubboRegistryCenterStarted should be the first one because of the startup of zookeeper
+org.apache.dubbo.test.check.RegistryCenterStarted
Review comment:
> When enable thread checking by `-DcheckThreads=true`, `DubboTestChecker` will dump threads after finished each test class. The embedded zk server will also create some threads, such as creating a new netty thread when establishing a connection, which will interfere with the thread check of dubbo test. Is it possible to start zk server in a separate process?
Now, it can use a dependent process to start zookeeper server.
##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/processor/KillProcessWindowsProcessor.java
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dubbo.test.check.registrycenter.processor;
+
+import org.apache.commons.exec.CommandLine;
+import org.apache.commons.exec.DefaultExecutor;
+import org.apache.commons.exec.Executor;
+import org.apache.commons.exec.PumpStreamHandler;
+import org.apache.dubbo.common.logger.Logger;
+import org.apache.dubbo.common.logger.LoggerFactory;
+import org.apache.dubbo.test.check.exception.DubboTestException;
+import org.apache.dubbo.test.check.registrycenter.context.ZookeeperWindowsContext;
+
+import java.io.IOException;
+
+/**
+ * Create a {@link org.apache.dubbo.test.check.registrycenter.Processor} to kill pid on Windows OS.
+ */
+public class KillProcessWindowsProcessor extends ZookeeperWindowsProcessor {
+
+ private static final Logger logger = LoggerFactory.getLogger(KillProcessWindowsProcessor.class);
+
+ @Override
+ protected void doProcess(ZookeeperWindowsContext context) throws DubboTestException {
+ for (int clientPort : context.getClientPorts()) {
+ Integer pid = context.getPid(clientPort);
Review comment:
OK, I've removed the killed pid.
##########
File path: dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/integration/multiple/exportmetadata/MultipleRegistryCenterExportMetadataIntegrationTest.java
##########
@@ -99,13 +91,9 @@ public void setUp() throws Exception {
DubboBootstrap.getInstance()
.application(new ApplicationConfig(PROVIDER_APPLICATION_NAME))
.protocol(new ProtocolConfig(PROTOCOL_NAME))
- .service(serviceConfig);
- for (RegistryCenter.Instance instance : registryCenter.getRegistryCenterInstance()) {
- DubboBootstrap.getInstance().registry(new RegistryConfig(String.format("%s://%s:%s",
- instance.getType(),
- instance.getHostname(),
- instance.getPort())));
- }
+ .service(serviceConfig)
+ .registry(new RegistryConfig("zookeeper://127.0.0.1:2181"))
+ .registry(new RegistryConfig("zookeeper://127.0.0.1:2182"));
Review comment:
That's a good seggustion! However, all local `zooKeeper connection strings` aren't displayed clearly, especially using Spring configuration or annotation.
But I've supported this feature.
##########
File path: dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/integration/multiple/exportmetadata/MultipleRegistryCenterExportMetadataIntegrationTest.java
##########
@@ -99,13 +91,9 @@ public void setUp() throws Exception {
DubboBootstrap.getInstance()
.application(new ApplicationConfig(PROVIDER_APPLICATION_NAME))
.protocol(new ProtocolConfig(PROTOCOL_NAME))
- .service(serviceConfig);
- for (RegistryCenter.Instance instance : registryCenter.getRegistryCenterInstance()) {
- DubboBootstrap.getInstance().registry(new RegistryConfig(String.format("%s://%s:%s",
- instance.getType(),
- instance.getHostname(),
- instance.getPort())));
- }
+ .service(serviceConfig)
+ .registry(new RegistryConfig("zookeeper://127.0.0.1:2181"))
+ .registry(new RegistryConfig("zookeeper://127.0.0.1:2182"));
Review comment:
The best way is to define two client ports (which might not be `2181` and `2182`) and quote them when using. However, there are so many hard code in unit test. So, it's very diffcult to change anywhere.
such as some zookeeper connection string in properties file
```java
dubbo.registry.address=zookeeper://127.0.0.1:2181?registry-type=service
biz.group=greeting
biz.group2=group2
dubbo.call-timeout=2000
```
##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/MockedRegistryCenter.java
##########
@@ -21,6 +21,16 @@
*/
public class MockedRegistryCenter {
+ /**
+ * The first global zookeeper address
+ */
+ public static final String ZOOKEEPER_ADDRESS1 = "zookeeper://127.0.0.1:2181";
Review comment:
> The global zookeeper address configs should not mixed with embedded zk server, extract them into a outer class. Furthermore, I thank it's better to append the zk server address and port configs to system props, such as:
>
> ```
> zookeeper.address=zookeeper://127.0.0.1:2181
> zookeeper.port=2181
> zookeeper.address.1=zookeeper://127.0.0.1:2181
> zookeeper.port.1=2181
> zookeeper.address.2=zookeeper://127.0.0.1:2182
> zookeeper.port.2=2182
> ```
>
> So we can use them in Spring application.properties/yaml:
>
> ```
> dubbo.registry.address=${zookeeper.address}
> dubbo.registries.second-registry.address=${zookeeper.address.2}
> ```
I think we need to support that make `zookeeper port` as system props, don't do that for `zookeeper.address`, because the `zookeeper.address` depend on `zookeeper.port`
For `zookeeper.address`, we can set the system props config after zookeeper instance started.
##########
File path: dubbo-test/dubbo-test-check/src/main/resources/META-INF/services/org.junit.platform.launcher.TestExecutionListener
##########
@@ -1 +1,5 @@
+# DubboRegistryCenterStarted should be the first one because of the startup of zookeeper
+org.apache.dubbo.test.check.RegistryCenterStarted
Review comment:
> Pls add JVM arg to disable embedded zk server, allow users to use external zk server.
It's done.
##########
File path: dubbo-test/dubbo-test-check/src/main/resources/META-INF/services/org.junit.platform.launcher.TestExecutionListener
##########
@@ -1 +1,5 @@
+# DubboRegistryCenterStarted should be the first one because of the startup of zookeeper
+org.apache.dubbo.test.check.RegistryCenterStarted
Review comment:
> When enable thread checking by `-DcheckThreads=true`, `DubboTestChecker` will dump threads after finished each test class. The embedded zk server will also create some threads, such as creating a new netty thread when establishing a connection, which will interfere with the thread check of dubbo test. Is it possible to start zk server in a separate process?
Now, it can use a dependent process to start zookeeper server.
##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/processor/KillProcessWindowsProcessor.java
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dubbo.test.check.registrycenter.processor;
+
+import org.apache.commons.exec.CommandLine;
+import org.apache.commons.exec.DefaultExecutor;
+import org.apache.commons.exec.Executor;
+import org.apache.commons.exec.PumpStreamHandler;
+import org.apache.dubbo.common.logger.Logger;
+import org.apache.dubbo.common.logger.LoggerFactory;
+import org.apache.dubbo.test.check.exception.DubboTestException;
+import org.apache.dubbo.test.check.registrycenter.context.ZookeeperWindowsContext;
+
+import java.io.IOException;
+
+/**
+ * Create a {@link org.apache.dubbo.test.check.registrycenter.Processor} to kill pid on Windows OS.
+ */
+public class KillProcessWindowsProcessor extends ZookeeperWindowsProcessor {
+
+ private static final Logger logger = LoggerFactory.getLogger(KillProcessWindowsProcessor.class);
+
+ @Override
+ protected void doProcess(ZookeeperWindowsContext context) throws DubboTestException {
+ for (int clientPort : context.getClientPorts()) {
+ Integer pid = context.getPid(clientPort);
Review comment:
OK, I've removed the killed pid.
##########
File path: dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/integration/multiple/exportmetadata/MultipleRegistryCenterExportMetadataIntegrationTest.java
##########
@@ -99,13 +91,9 @@ public void setUp() throws Exception {
DubboBootstrap.getInstance()
.application(new ApplicationConfig(PROVIDER_APPLICATION_NAME))
.protocol(new ProtocolConfig(PROTOCOL_NAME))
- .service(serviceConfig);
- for (RegistryCenter.Instance instance : registryCenter.getRegistryCenterInstance()) {
- DubboBootstrap.getInstance().registry(new RegistryConfig(String.format("%s://%s:%s",
- instance.getType(),
- instance.getHostname(),
- instance.getPort())));
- }
+ .service(serviceConfig)
+ .registry(new RegistryConfig("zookeeper://127.0.0.1:2181"))
+ .registry(new RegistryConfig("zookeeper://127.0.0.1:2182"));
Review comment:
That's a good seggustion! However, all local `zooKeeper connection strings` aren't displayed clearly, especially using Spring configuration or annotation.
But I've supported this feature.
##########
File path: dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/integration/multiple/exportmetadata/MultipleRegistryCenterExportMetadataIntegrationTest.java
##########
@@ -99,13 +91,9 @@ public void setUp() throws Exception {
DubboBootstrap.getInstance()
.application(new ApplicationConfig(PROVIDER_APPLICATION_NAME))
.protocol(new ProtocolConfig(PROTOCOL_NAME))
- .service(serviceConfig);
- for (RegistryCenter.Instance instance : registryCenter.getRegistryCenterInstance()) {
- DubboBootstrap.getInstance().registry(new RegistryConfig(String.format("%s://%s:%s",
- instance.getType(),
- instance.getHostname(),
- instance.getPort())));
- }
+ .service(serviceConfig)
+ .registry(new RegistryConfig("zookeeper://127.0.0.1:2181"))
+ .registry(new RegistryConfig("zookeeper://127.0.0.1:2182"));
Review comment:
The best way is to define two client ports (which might not be `2181` and `2182`) and quote them when using. However, there are so many hard code in unit test. So, it's very diffcult to change anywhere.
such as some zookeeper connection string in properties file
```java
dubbo.registry.address=zookeeper://127.0.0.1:2181?registry-type=service
biz.group=greeting
biz.group2=group2
dubbo.call-timeout=2000
```
##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/MockedRegistryCenter.java
##########
@@ -21,6 +21,16 @@
*/
public class MockedRegistryCenter {
+ /**
+ * The first global zookeeper address
+ */
+ public static final String ZOOKEEPER_ADDRESS1 = "zookeeper://127.0.0.1:2181";
Review comment:
> The global zookeeper address configs should not mixed with embedded zk server, extract them into a outer class. Furthermore, I thank it's better to append the zk server address and port configs to system props, such as:
>
> ```
> zookeeper.address=zookeeper://127.0.0.1:2181
> zookeeper.port=2181
> zookeeper.address.1=zookeeper://127.0.0.1:2181
> zookeeper.port.1=2181
> zookeeper.address.2=zookeeper://127.0.0.1:2182
> zookeeper.port.2=2182
> ```
>
> So we can use them in Spring application.properties/yaml:
>
> ```
> dubbo.registry.address=${zookeeper.address}
> dubbo.registries.second-registry.address=${zookeeper.address.2}
> ```
I think we need to support that make `zookeeper port` as system props, don't do that for `zookeeper.address`, because the `zookeeper.address` depend on `zookeeper.port`
For `zookeeper.address`, we can set the system props config after zookeeper instance started.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952441180
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9138](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7325139) into [3.0](https://codecov.io/gh/apache/dubbo/commit/94e26b4c4a2379ec01fa29ee2d9daf0baad41dcc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94e26b4) will **decrease** coverage by `0.39%`.
> The diff coverage is `5.41%`.
[](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9138 +/- ##
============================================
- Coverage 65.38% 64.98% -0.40%
- Complexity 313 328 +15
============================================
Files 1188 1206 +18
Lines 51448 51775 +327
Branches 7690 7721 +31
============================================
+ Hits 33638 33645 +7
- Misses 14189 14505 +316
- Partials 3621 3625 +4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dubbo/test/check/exception/DubboTestException.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL2V4Y2VwdGlvbi9EdWJib1Rlc3RFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...apache/dubbo/test/check/registrycenter/Config.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL0NvbmZpZy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...est/check/registrycenter/GlobalRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL0dsb2JhbFJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...eck/registrycenter/GlobalRegistryCenterConfig.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL0dsb2JhbFJlZ2lzdHJ5Q2VudGVyQ29uZmlnLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...t/check/registrycenter/config/ZookeeperConfig.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbmZpZy9ab29rZWVwZXJDb25maWcuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...egistrycenter/context/ZookeeperWindowsContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyV2luZG93c0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [38 more](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [94e26b4...7325139](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952441180
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9138](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8b44590) into [3.0](https://codecov.io/gh/apache/dubbo/commit/94e26b4c4a2379ec01fa29ee2d9daf0baad41dcc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94e26b4) will **decrease** coverage by `0.49%`.
> The diff coverage is `5.41%`.
[](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9138 +/- ##
============================================
- Coverage 65.38% 64.88% -0.50%
- Complexity 313 326 +13
============================================
Files 1188 1206 +18
Lines 51448 51775 +327
Branches 7690 7694 +4
============================================
- Hits 33638 33596 -42
- Misses 14189 14536 +347
- Partials 3621 3643 +22
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dubbo/test/check/exception/DubboTestException.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL2V4Y2VwdGlvbi9EdWJib1Rlc3RFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...apache/dubbo/test/check/registrycenter/Config.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL0NvbmZpZy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...est/check/registrycenter/GlobalRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL0dsb2JhbFJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...t/check/registrycenter/config/ZookeeperConfig.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbmZpZy9ab29rZWVwZXJDb25maWcuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...rycenter/config/ZookeeperRegistryCenterConfig.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbmZpZy9ab29rZWVwZXJSZWdpc3RyeUNlbnRlckNvbmZpZy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...egistrycenter/context/ZookeeperWindowsContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyV2luZG93c0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [54 more](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [94e26b4...8b44590](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952441180
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9138](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3d010c8) into [3.0](https://codecov.io/gh/apache/dubbo/commit/f45beca9521d4f91a885fd6c8895006482a20f1a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f45beca) will **increase** coverage by `0.05%`.
> The diff coverage is `39.21%`.
[](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9138 +/- ##
============================================
+ Coverage 64.72% 64.78% +0.05%
- Complexity 310 319 +9
============================================
Files 1178 1179 +1
Lines 50708 50672 -36
Branches 7550 7553 +3
============================================
+ Hits 32821 32826 +5
+ Misses 14317 14270 -47
- Partials 3570 3576 +6
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...t/check/registrycenter/AbstractRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL0Fic3RyYWN0UmVnaXN0cnlDZW50ZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...registrycenter/DefaultZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL0RlZmF1bHRab29rZWVwZXJSZWdpc3RyeUNlbnRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../registrycenter/MockedZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL01vY2tlZFpvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...pache/dubbo/test/check/RegistryCenterFinished.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL1JlZ2lzdHJ5Q2VudGVyRmluaXNoZWQuamF2YQ==) | `42.85% <42.85%> (ø)` | |
| [...apache/dubbo/test/check/RegistryCenterStarted.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL1JlZ2lzdHJ5Q2VudGVyU3RhcnRlZC5qYXZh) | `42.85% <42.85%> (ø)` | |
| [...k/AbstractRegistryCenterTestExecutionListener.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL0Fic3RyYWN0UmVnaXN0cnlDZW50ZXJUZXN0RXhlY3V0aW9uTGlzdGVuZXIuamF2YQ==) | `53.84% <53.84%> (ø)` | |
| [...he/dubbo/common/config/CompositeConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0NvbXBvc2l0ZUNvbmZpZ3VyYXRpb24uamF2YQ==) | `46.42% <0.00%> (-14.29%)` | :arrow_down: |
| [...ian2/dubbo/AbstractHessian2FactoryInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL2R1YmJvL0Fic3RyYWN0SGVzc2lhbjJGYWN0b3J5SW5pdGlhbGl6ZXIuamF2YQ==) | `50.00% <0.00%> (-11.12%)` | :arrow_down: |
| [...src/main/java/org/apache/dubbo/common/Version.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vVmVyc2lvbi5qYXZh) | `62.50% <0.00%> (-9.62%)` | :arrow_down: |
| ... and [19 more](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f45beca...3d010c8](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] chickenlj commented on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
chickenlj commented on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-953595991
I find there already have some unit test conflicts from the main repo. We'd better merge this patch ASAP if the direction of the change is right. @kylixs @pinxiong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#discussion_r743380638
##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/processor/KillProcessWindowsProcessor.java
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dubbo.test.check.registrycenter.processor;
+
+import org.apache.commons.exec.CommandLine;
+import org.apache.commons.exec.DefaultExecutor;
+import org.apache.commons.exec.Executor;
+import org.apache.commons.exec.PumpStreamHandler;
+import org.apache.dubbo.common.logger.Logger;
+import org.apache.dubbo.common.logger.LoggerFactory;
+import org.apache.dubbo.test.check.exception.DubboTestException;
+import org.apache.dubbo.test.check.registrycenter.context.ZookeeperWindowsContext;
+
+import java.io.IOException;
+
+/**
+ * Create a {@link org.apache.dubbo.test.check.registrycenter.Processor} to kill pid on Windows OS.
+ */
+public class KillProcessWindowsProcessor extends ZookeeperWindowsProcessor {
+
+ private static final Logger logger = LoggerFactory.getLogger(KillProcessWindowsProcessor.class);
+
+ @Override
+ protected void doProcess(ZookeeperWindowsContext context) throws DubboTestException {
+ for (int clientPort : context.getClientPorts()) {
+ Integer pid = context.getPid(clientPort);
Review comment:
The pid of client port should be clear immediately after kill it, os may reuse this pid when creating a new process later, and it cannot be killed next time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952441180
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9138](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8fc4768) into [3.0](https://codecov.io/gh/apache/dubbo/commit/94e26b4c4a2379ec01fa29ee2d9daf0baad41dcc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94e26b4) will **decrease** coverage by `0.46%`.
> The diff coverage is `5.92%`.
[](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9138 +/- ##
============================================
- Coverage 65.38% 64.92% -0.47%
- Complexity 313 326 +13
============================================
Files 1188 1203 +15
Lines 51448 51731 +283
Branches 7690 7691 +1
============================================
- Hits 33638 33584 -54
- Misses 14189 14512 +323
- Partials 3621 3635 +14
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dubbo/test/check/exception/DubboTestException.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL2V4Y2VwdGlvbi9EdWJib1Rlc3RFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...est/check/registrycenter/MockedRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL01vY2tlZFJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...egistrycenter/context/ZookeeperWindowsContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyV2luZG93c0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...gistrycenter/initializer/ZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...istrycenter/processor/FindPidWindowsProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9GaW5kUGlkV2luZG93c1Byb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [52 more](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [94e26b4...8fc4768](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952441180
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9138](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ca36c6b) into [3.0](https://codecov.io/gh/apache/dubbo/commit/295f2a767f1a2dd812e955bff8c5efb0eb97fd3f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (295f2a7) will **decrease** coverage by `0.38%`.
> The diff coverage is `5.63%`.
[](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9138 +/- ##
============================================
- Coverage 65.16% 64.77% -0.39%
- Complexity 313 325 +12
============================================
Files 1188 1203 +15
Lines 51424 51735 +311
Branches 7684 7721 +37
============================================
+ Hits 33509 33512 +3
- Misses 14296 14589 +293
- Partials 3619 3634 +15
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dubbo/test/check/exception/DubboTestException.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL2V4Y2VwdGlvbi9EdWJib1Rlc3RFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...est/check/registrycenter/MockedRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL01vY2tlZFJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...egistrycenter/context/ZookeeperWindowsContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyV2luZG93c0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...gistrycenter/initializer/ZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...istrycenter/processor/FindPidWindowsProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9GaW5kUGlkV2luZG93c1Byb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [35 more](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [295f2a7...ca36c6b](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952441180
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9138](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d1eb7af) into [3.0](https://codecov.io/gh/apache/dubbo/commit/94e26b4c4a2379ec01fa29ee2d9daf0baad41dcc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94e26b4) will **decrease** coverage by `0.54%`.
> The diff coverage is `5.93%`.
[](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9138 +/- ##
============================================
- Coverage 65.38% 64.83% -0.55%
- Complexity 313 329 +16
============================================
Files 1188 1203 +15
Lines 51448 51695 +247
Branches 7690 7685 -5
============================================
- Hits 33638 33517 -121
- Misses 14189 14550 +361
- Partials 3621 3628 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dubbo/test/check/exception/DubboTestException.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL2V4Y2VwdGlvbi9EdWJib1Rlc3RFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...est/check/registrycenter/MockedRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL01vY2tlZFJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...egistrycenter/context/ZookeeperWindowsContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyV2luZG93c0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...gistrycenter/initializer/ZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...istrycenter/processor/FindPidWindowsProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9GaW5kUGlkV2luZG93c1Byb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [71 more](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [94e26b4...d1eb7af](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952441180
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9138](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3d010c8) into [3.0](https://codecov.io/gh/apache/dubbo/commit/f45beca9521d4f91a885fd6c8895006482a20f1a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f45beca) will **increase** coverage by `0.02%`.
> The diff coverage is `39.21%`.
[](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9138 +/- ##
============================================
+ Coverage 64.72% 64.74% +0.02%
- Complexity 310 319 +9
============================================
Files 1178 1179 +1
Lines 50708 50672 -36
Branches 7550 7553 +3
============================================
- Hits 32821 32810 -11
+ Misses 14317 14283 -34
- Partials 3570 3579 +9
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...t/check/registrycenter/AbstractRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL0Fic3RyYWN0UmVnaXN0cnlDZW50ZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...registrycenter/DefaultZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL0RlZmF1bHRab29rZWVwZXJSZWdpc3RyeUNlbnRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../registrycenter/MockedZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL01vY2tlZFpvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...pache/dubbo/test/check/RegistryCenterFinished.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL1JlZ2lzdHJ5Q2VudGVyRmluaXNoZWQuamF2YQ==) | `42.85% <42.85%> (ø)` | |
| [...apache/dubbo/test/check/RegistryCenterStarted.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL1JlZ2lzdHJ5Q2VudGVyU3RhcnRlZC5qYXZh) | `42.85% <42.85%> (ø)` | |
| [...k/AbstractRegistryCenterTestExecutionListener.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL0Fic3RyYWN0UmVnaXN0cnlDZW50ZXJUZXN0RXhlY3V0aW9uTGlzdGVuZXIuamF2YQ==) | `53.84% <53.84%> (ø)` | |
| [...he/dubbo/common/config/CompositeConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0NvbXBvc2l0ZUNvbmZpZ3VyYXRpb24uamF2YQ==) | `46.42% <0.00%> (-14.29%)` | :arrow_down: |
| [...ian2/dubbo/AbstractHessian2FactoryInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL2R1YmJvL0Fic3RyYWN0SGVzc2lhbjJGYWN0b3J5SW5pdGlhbGl6ZXIuamF2YQ==) | `50.00% <0.00%> (-11.12%)` | :arrow_down: |
| [...src/main/java/org/apache/dubbo/common/Version.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vVmVyc2lvbi5qYXZh) | `62.50% <0.00%> (-9.62%)` | :arrow_down: |
| ... and [21 more](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f45beca...3d010c8](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#discussion_r738156497
##########
File path: dubbo-test/dubbo-test-check/src/main/resources/META-INF/services/org.junit.platform.launcher.TestExecutionListener
##########
@@ -1 +1,5 @@
+# DubboRegistryCenterStarted should be the first one because of the startup of zookeeper
+org.apache.dubbo.test.check.RegistryCenterStarted
Review comment:
Pls add JVM arg to disable embedded zk server, allow users to use external zk server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
kylixs commented on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952612445
Did you clean up the data in the registry after executing each test method? No related processing found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952441180
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9138](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d1eb7af) into [3.0](https://codecov.io/gh/apache/dubbo/commit/94e26b4c4a2379ec01fa29ee2d9daf0baad41dcc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94e26b4) will **decrease** coverage by `0.38%`.
> The diff coverage is `5.93%`.
[](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9138 +/- ##
============================================
- Coverage 65.38% 65.00% -0.39%
- Complexity 313 329 +16
============================================
Files 1188 1203 +15
Lines 51448 51731 +283
Branches 7690 7718 +28
============================================
- Hits 33638 33626 -12
- Misses 14189 14477 +288
- Partials 3621 3628 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dubbo/test/check/exception/DubboTestException.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL2V4Y2VwdGlvbi9EdWJib1Rlc3RFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...est/check/registrycenter/MockedRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL01vY2tlZFJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...egistrycenter/context/ZookeeperWindowsContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyV2luZG93c0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...gistrycenter/initializer/ZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...istrycenter/processor/FindPidWindowsProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9GaW5kUGlkV2luZG93c1Byb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [40 more](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [94e26b4...d1eb7af](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952441180
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9138](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d1eb7af) into [3.0](https://codecov.io/gh/apache/dubbo/commit/94e26b4c4a2379ec01fa29ee2d9daf0baad41dcc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94e26b4) will **decrease** coverage by `0.33%`.
> The diff coverage is `5.93%`.
[](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9138 +/- ##
============================================
- Coverage 65.38% 65.05% -0.34%
- Complexity 313 330 +17
============================================
Files 1188 1203 +15
Lines 51448 51731 +283
Branches 7690 7718 +28
============================================
+ Hits 33638 33652 +14
- Misses 14189 14454 +265
- Partials 3621 3625 +4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dubbo/test/check/exception/DubboTestException.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL2V4Y2VwdGlvbi9EdWJib1Rlc3RFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...est/check/registrycenter/MockedRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL01vY2tlZFJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...egistrycenter/context/ZookeeperWindowsContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyV2luZG93c0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...gistrycenter/initializer/ZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...istrycenter/processor/FindPidWindowsProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9GaW5kUGlkV2luZG93c1Byb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [35 more](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [94e26b4...d1eb7af](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952441180
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9138](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d1eb7af) into [3.0](https://codecov.io/gh/apache/dubbo/commit/94e26b4c4a2379ec01fa29ee2d9daf0baad41dcc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94e26b4) will **decrease** coverage by `0.33%`.
> The diff coverage is `5.93%`.
[](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9138 +/- ##
============================================
- Coverage 65.38% 65.04% -0.34%
- Complexity 313 330 +17
============================================
Files 1188 1203 +15
Lines 51448 51731 +283
Branches 7690 7718 +28
============================================
+ Hits 33638 33649 +11
- Misses 14189 14458 +269
- Partials 3621 3624 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dubbo/test/check/exception/DubboTestException.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL2V4Y2VwdGlvbi9EdWJib1Rlc3RFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...est/check/registrycenter/MockedRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL01vY2tlZFJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...egistrycenter/context/ZookeeperWindowsContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyV2luZG93c0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...gistrycenter/initializer/ZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...istrycenter/processor/FindPidWindowsProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9GaW5kUGlkV2luZG93c1Byb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [36 more](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [94e26b4...d1eb7af](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952441180
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9138](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (08e2c30) into [3.0](https://codecov.io/gh/apache/dubbo/commit/295f2a767f1a2dd812e955bff8c5efb0eb97fd3f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (295f2a7) will **decrease** coverage by `0.45%`.
> The diff coverage is `5.99%`.
[](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9138 +/- ##
============================================
- Coverage 65.16% 64.71% -0.46%
- Complexity 313 328 +15
============================================
Files 1188 1203 +15
Lines 51424 51691 +267
Branches 7684 7686 +2
============================================
- Hits 33509 33450 -59
- Misses 14296 14600 +304
- Partials 3619 3641 +22
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dubbo/test/check/exception/DubboTestException.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL2V4Y2VwdGlvbi9EdWJib1Rlc3RFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...est/check/registrycenter/MockedRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL01vY2tlZFJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...egistrycenter/context/ZookeeperWindowsContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyV2luZG93c0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...gistrycenter/initializer/ZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...istrycenter/processor/FindPidWindowsProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9GaW5kUGlkV2luZG93c1Byb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [64 more](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [295f2a7...08e2c30](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#discussion_r743379056
##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/processor/FindPidWindowsProcessor.java
##########
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dubbo.test.check.registrycenter.processor;
+
+import org.apache.commons.exec.CommandLine;
+import org.apache.commons.exec.DefaultExecutor;
+import org.apache.commons.exec.Executor;
+import org.apache.commons.exec.PumpStreamHandler;
+import org.apache.dubbo.common.logger.Logger;
+import org.apache.dubbo.common.logger.LoggerFactory;
+import org.apache.dubbo.common.utils.StringUtils;
+import org.apache.dubbo.test.check.exception.DubboTestException;
+import org.apache.dubbo.test.check.registrycenter.context.ZookeeperWindowsContext;
+
+import java.io.ByteArrayInputStream;
+import java.io.ByteArrayOutputStream;
+import java.io.IOException;
+
+
+/**
+ * Create a {@link org.apache.dubbo.test.check.registrycenter.Processor} to find pid on Windows OS.
+ */
+public class FindPidWindowsProcessor extends ZookeeperWindowsProcessor {
+
+ private static final Logger logger = LoggerFactory.getLogger(FindPidWindowsProcessor.class);
+
+ @Override
+ protected void doProcess(ZookeeperWindowsContext context) throws DubboTestException {
+ for (int clientPort : context.getClientPorts()) {
+ this.findPid(context, clientPort);
+ }
+ }
+
+ /**
+ * Find the pid of zookeeper instance.
+ *
+ * @param context the global context.
+ * @param clientPort the client port of zookeeper instance.
+ */
+ private void findPid(ZookeeperWindowsContext context, int clientPort) {
+ logger.info(String.format("Find the pid of the zookeeper with port %d", clientPort));
+ Executor executor = new DefaultExecutor();
+ executor.setExitValues(null);
+ ByteArrayOutputStream out = new ByteArrayOutputStream();
+ ByteArrayOutputStream ins = new ByteArrayOutputStream();
+ ByteArrayInputStream in = new ByteArrayInputStream(ins.toByteArray());
+ executor.setStreamHandler(new PumpStreamHandler(out, null, in));
+ CommandLine cmdLine = new CommandLine("cmd.exe");
+ cmdLine.addArgument("/c");
+ cmdLine.addArgument("netstat -ano | findstr " + clientPort);
+ try {
+ executor.execute(cmdLine);
+ String result = out.toString();
+ logger.info(String.format("Find result: %s", result));
+ if (StringUtils.isNotEmpty(result)) {
+ String[] values = result.split("\\r\\n");
+ if (values != null && values.length > 0) {
+ for (int i = 0; i < values.length; i++) {
+ String[] segments = values[i].split(" ");
Review comment:
Pls add a sample result as comment for readable. The second column is "Local Address", do not use the third column which is "Foreign Address".
##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/processor/KillProcessWindowsProcessor.java
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dubbo.test.check.registrycenter.processor;
+
+import org.apache.commons.exec.CommandLine;
+import org.apache.commons.exec.DefaultExecutor;
+import org.apache.commons.exec.Executor;
+import org.apache.commons.exec.PumpStreamHandler;
+import org.apache.dubbo.common.logger.Logger;
+import org.apache.dubbo.common.logger.LoggerFactory;
+import org.apache.dubbo.test.check.exception.DubboTestException;
+import org.apache.dubbo.test.check.registrycenter.context.ZookeeperWindowsContext;
+
+import java.io.IOException;
+
+/**
+ * Create a {@link org.apache.dubbo.test.check.registrycenter.Processor} to kill pid on Windows OS.
+ */
+public class KillProcessWindowsProcessor extends ZookeeperWindowsProcessor {
+
+ private static final Logger logger = LoggerFactory.getLogger(KillProcessWindowsProcessor.class);
+
+ @Override
+ protected void doProcess(ZookeeperWindowsContext context) throws DubboTestException {
+ for (int clientPort : context.getClientPorts()) {
+ Integer pid = context.getPid(clientPort);
Review comment:
The pid of client port should be clear immediately after kill it, os may reuse this pid when creating a new process later, and it cannot be killed next time.
##########
File path: dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/integration/multiple/exportmetadata/MultipleRegistryCenterExportMetadataIntegrationTest.java
##########
@@ -99,13 +91,9 @@ public void setUp() throws Exception {
DubboBootstrap.getInstance()
.application(new ApplicationConfig(PROVIDER_APPLICATION_NAME))
.protocol(new ProtocolConfig(PROTOCOL_NAME))
- .service(serviceConfig);
- for (RegistryCenter.Instance instance : registryCenter.getRegistryCenterInstance()) {
- DubboBootstrap.getInstance().registry(new RegistryConfig(String.format("%s://%s:%s",
- instance.getType(),
- instance.getHostname(),
- instance.getPort())));
- }
+ .service(serviceConfig)
+ .registry(new RegistryConfig("zookeeper://127.0.0.1:2181"))
+ .registry(new RegistryConfig("zookeeper://127.0.0.1:2182"));
Review comment:
Is it possible to define global zk server port/address variables and then quote them in test? It is better not to use the port 2181 by default to avoid port conflicts on the zk server. Just a suggestion.
##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/MockedRegistryCenter.java
##########
@@ -21,6 +21,16 @@
*/
public class MockedRegistryCenter {
Review comment:
It is not a mock register center, it is real. Better to rename it
##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/MockedRegistryCenter.java
##########
@@ -21,6 +21,16 @@
*/
public class MockedRegistryCenter {
+ /**
+ * The first global zookeeper address
+ */
+ public static final String ZOOKEEPER_ADDRESS1 = "zookeeper://127.0.0.1:2181";
Review comment:
The global zookeeper address configs should not mixed with embedded zk server, extract them into a outer class.
Furthermore, I thank it's better to append the zk server address and port configs to system props, such as:
```
zookeeper.address=zookeeper://127.0.0.1:2181
zookeeper.port=2181
zookeeper.address.1=zookeeper://127.0.0.1:2181
zookeeper.port.1=2181
zookeeper.address.2=zookeeper://127.0.0.1:2181
zookeeper.port.2=2181
```
So we can use them in Spring application.properties/yaml:
```
dubbo.registry.address=${zookeeper.address}
dubbo.registries.second-registry.address=${zookeeper.address.2}
```
##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/MockedRegistryCenter.java
##########
@@ -21,6 +21,16 @@
*/
public class MockedRegistryCenter {
+ /**
+ * The first global zookeeper address
+ */
+ public static final String ZOOKEEPER_ADDRESS1 = "zookeeper://127.0.0.1:2181";
Review comment:
The global zookeeper address configs should not mixed with embedded zk server, extract them into a outer class.
Furthermore, I thank it's better to append the zk server address and port configs to system props, such as:
```
zookeeper.address=zookeeper://127.0.0.1:2181
zookeeper.port=2181
zookeeper.address.1=zookeeper://127.0.0.1:2181
zookeeper.port.1=2181
zookeeper.address.2=zookeeper://127.0.0.1:2182
zookeeper.port.2=2182
```
So we can use them in Spring application.properties/yaml:
```
dubbo.registry.address=${zookeeper.address}
dubbo.registries.second-registry.address=${zookeeper.address.2}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] pinxiong commented on a change in pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
pinxiong commented on a change in pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#discussion_r737207901
##########
File path: dubbo-test/dubbo-test-check/src/main/resources/META-INF/services/org.junit.platform.launcher.TestExecutionListener
##########
@@ -1 +1,5 @@
+# DubboRegistryCenterStarted should be the first one because of the startup of zookeeper
+org.apache.dubbo.test.check.RegistryCenterStarted
Review comment:
All of implemenations of `TestExecutionListener` will be loaded, which are in `resources/META-INF/services/org.junit.platform.launcher.TestExecutionListener`. The order of loading implemenations is as listed in the configuration file.
+ The first implemenation is `RegistryCenterStarted`, which is to handle the startup of zookeeper
+ The second implemenation is `DubboTestChecker`, which is to destroy resources after ut finished
+ The last implemenation is `RegistryCenterFinished `, which is to handle the shutdown of zookeeper
The purpose of splitting into two implemenations is to make sure that `zookeeper` is started before all operations and destroyed after all operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] pinxiong commented on a change in pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
pinxiong commented on a change in pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#discussion_r743669802
##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/MockedRegistryCenter.java
##########
@@ -21,6 +21,16 @@
*/
public class MockedRegistryCenter {
+ /**
+ * The first global zookeeper address
+ */
+ public static final String ZOOKEEPER_ADDRESS1 = "zookeeper://127.0.0.1:2181";
Review comment:
> The global zookeeper address configs should not mixed with embedded zk server, extract them into a outer class. Furthermore, I thank it's better to append the zk server address and port configs to system props, such as:
>
> ```
> zookeeper.address=zookeeper://127.0.0.1:2181
> zookeeper.port=2181
> zookeeper.address.1=zookeeper://127.0.0.1:2181
> zookeeper.port.1=2181
> zookeeper.address.2=zookeeper://127.0.0.1:2182
> zookeeper.port.2=2182
> ```
>
> So we can use them in Spring application.properties/yaml:
>
> ```
> dubbo.registry.address=${zookeeper.address}
> dubbo.registries.second-registry.address=${zookeeper.address.2}
> ```
I think we need to support that make `zookeeper port` as system props, don't do that for `zookeeper.address`, because the `zookeeper.address` depend on `zookeeper.port`
For `zookeeper.address`, we can set the system props config after zookeeper instance started.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#discussion_r743644582
##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/MockedRegistryCenter.java
##########
@@ -21,6 +21,16 @@
*/
public class MockedRegistryCenter {
Review comment:
It is not a mock register center, it is real. Better to rename it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952441180
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9138](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (08e2c30) into [3.0](https://codecov.io/gh/apache/dubbo/commit/295f2a767f1a2dd812e955bff8c5efb0eb97fd3f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (295f2a7) will **decrease** coverage by `0.38%`.
> The diff coverage is `5.99%`.
[](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9138 +/- ##
============================================
- Coverage 65.16% 64.78% -0.39%
- Complexity 313 329 +16
============================================
Files 1188 1203 +15
Lines 51424 51727 +303
Branches 7684 7719 +35
============================================
Hits 33509 33509
- Misses 14296 14594 +298
- Partials 3619 3624 +5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dubbo/test/check/exception/DubboTestException.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL2V4Y2VwdGlvbi9EdWJib1Rlc3RFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...est/check/registrycenter/MockedRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL01vY2tlZFJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...egistrycenter/context/ZookeeperWindowsContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyV2luZG93c0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...gistrycenter/initializer/ZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...istrycenter/processor/FindPidWindowsProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9GaW5kUGlkV2luZG93c1Byb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [41 more](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [295f2a7...08e2c30](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#discussion_r743379056
##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/processor/FindPidWindowsProcessor.java
##########
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dubbo.test.check.registrycenter.processor;
+
+import org.apache.commons.exec.CommandLine;
+import org.apache.commons.exec.DefaultExecutor;
+import org.apache.commons.exec.Executor;
+import org.apache.commons.exec.PumpStreamHandler;
+import org.apache.dubbo.common.logger.Logger;
+import org.apache.dubbo.common.logger.LoggerFactory;
+import org.apache.dubbo.common.utils.StringUtils;
+import org.apache.dubbo.test.check.exception.DubboTestException;
+import org.apache.dubbo.test.check.registrycenter.context.ZookeeperWindowsContext;
+
+import java.io.ByteArrayInputStream;
+import java.io.ByteArrayOutputStream;
+import java.io.IOException;
+
+
+/**
+ * Create a {@link org.apache.dubbo.test.check.registrycenter.Processor} to find pid on Windows OS.
+ */
+public class FindPidWindowsProcessor extends ZookeeperWindowsProcessor {
+
+ private static final Logger logger = LoggerFactory.getLogger(FindPidWindowsProcessor.class);
+
+ @Override
+ protected void doProcess(ZookeeperWindowsContext context) throws DubboTestException {
+ for (int clientPort : context.getClientPorts()) {
+ this.findPid(context, clientPort);
+ }
+ }
+
+ /**
+ * Find the pid of zookeeper instance.
+ *
+ * @param context the global context.
+ * @param clientPort the client port of zookeeper instance.
+ */
+ private void findPid(ZookeeperWindowsContext context, int clientPort) {
+ logger.info(String.format("Find the pid of the zookeeper with port %d", clientPort));
+ Executor executor = new DefaultExecutor();
+ executor.setExitValues(null);
+ ByteArrayOutputStream out = new ByteArrayOutputStream();
+ ByteArrayOutputStream ins = new ByteArrayOutputStream();
+ ByteArrayInputStream in = new ByteArrayInputStream(ins.toByteArray());
+ executor.setStreamHandler(new PumpStreamHandler(out, null, in));
+ CommandLine cmdLine = new CommandLine("cmd.exe");
+ cmdLine.addArgument("/c");
+ cmdLine.addArgument("netstat -ano | findstr " + clientPort);
+ try {
+ executor.execute(cmdLine);
+ String result = out.toString();
+ logger.info(String.format("Find result: %s", result));
+ if (StringUtils.isNotEmpty(result)) {
+ String[] values = result.split("\\r\\n");
+ if (values != null && values.length > 0) {
+ for (int i = 0; i < values.length; i++) {
+ String[] segments = values[i].split(" ");
Review comment:
Pls add a sample result as comment for readable. The second column is "Local Address", do not use the third column which is "Foreign Address".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952441180
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9138](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7325139) into [3.0](https://codecov.io/gh/apache/dubbo/commit/94e26b4c4a2379ec01fa29ee2d9daf0baad41dcc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94e26b4) will **decrease** coverage by `0.48%`.
> The diff coverage is `5.41%`.
[](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9138 +/- ##
============================================
- Coverage 65.38% 64.90% -0.49%
- Complexity 313 328 +15
============================================
Files 1188 1206 +18
Lines 51448 51739 +291
Branches 7690 7688 -2
============================================
- Hits 33638 33579 -59
- Misses 14189 14518 +329
- Partials 3621 3642 +21
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dubbo/test/check/exception/DubboTestException.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL2V4Y2VwdGlvbi9EdWJib1Rlc3RFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...apache/dubbo/test/check/registrycenter/Config.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL0NvbmZpZy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...est/check/registrycenter/GlobalRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL0dsb2JhbFJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...eck/registrycenter/GlobalRegistryCenterConfig.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL0dsb2JhbFJlZ2lzdHJ5Q2VudGVyQ29uZmlnLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...t/check/registrycenter/config/ZookeeperConfig.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbmZpZy9ab29rZWVwZXJDb25maWcuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...egistrycenter/context/ZookeeperWindowsContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyV2luZG93c0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [67 more](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [94e26b4...7325139](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#discussion_r743379056
##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/processor/FindPidWindowsProcessor.java
##########
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dubbo.test.check.registrycenter.processor;
+
+import org.apache.commons.exec.CommandLine;
+import org.apache.commons.exec.DefaultExecutor;
+import org.apache.commons.exec.Executor;
+import org.apache.commons.exec.PumpStreamHandler;
+import org.apache.dubbo.common.logger.Logger;
+import org.apache.dubbo.common.logger.LoggerFactory;
+import org.apache.dubbo.common.utils.StringUtils;
+import org.apache.dubbo.test.check.exception.DubboTestException;
+import org.apache.dubbo.test.check.registrycenter.context.ZookeeperWindowsContext;
+
+import java.io.ByteArrayInputStream;
+import java.io.ByteArrayOutputStream;
+import java.io.IOException;
+
+
+/**
+ * Create a {@link org.apache.dubbo.test.check.registrycenter.Processor} to find pid on Windows OS.
+ */
+public class FindPidWindowsProcessor extends ZookeeperWindowsProcessor {
+
+ private static final Logger logger = LoggerFactory.getLogger(FindPidWindowsProcessor.class);
+
+ @Override
+ protected void doProcess(ZookeeperWindowsContext context) throws DubboTestException {
+ for (int clientPort : context.getClientPorts()) {
+ this.findPid(context, clientPort);
+ }
+ }
+
+ /**
+ * Find the pid of zookeeper instance.
+ *
+ * @param context the global context.
+ * @param clientPort the client port of zookeeper instance.
+ */
+ private void findPid(ZookeeperWindowsContext context, int clientPort) {
+ logger.info(String.format("Find the pid of the zookeeper with port %d", clientPort));
+ Executor executor = new DefaultExecutor();
+ executor.setExitValues(null);
+ ByteArrayOutputStream out = new ByteArrayOutputStream();
+ ByteArrayOutputStream ins = new ByteArrayOutputStream();
+ ByteArrayInputStream in = new ByteArrayInputStream(ins.toByteArray());
+ executor.setStreamHandler(new PumpStreamHandler(out, null, in));
+ CommandLine cmdLine = new CommandLine("cmd.exe");
+ cmdLine.addArgument("/c");
+ cmdLine.addArgument("netstat -ano | findstr " + clientPort);
+ try {
+ executor.execute(cmdLine);
+ String result = out.toString();
+ logger.info(String.format("Find result: %s", result));
+ if (StringUtils.isNotEmpty(result)) {
+ String[] values = result.split("\\r\\n");
+ if (values != null && values.length > 0) {
+ for (int i = 0; i < values.length; i++) {
+ String[] segments = values[i].split(" ");
Review comment:
Pls add a sample result as comment for readable. The second column is "Local Address", do not use the third column which is "Foreign Address".
##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/processor/KillProcessWindowsProcessor.java
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dubbo.test.check.registrycenter.processor;
+
+import org.apache.commons.exec.CommandLine;
+import org.apache.commons.exec.DefaultExecutor;
+import org.apache.commons.exec.Executor;
+import org.apache.commons.exec.PumpStreamHandler;
+import org.apache.dubbo.common.logger.Logger;
+import org.apache.dubbo.common.logger.LoggerFactory;
+import org.apache.dubbo.test.check.exception.DubboTestException;
+import org.apache.dubbo.test.check.registrycenter.context.ZookeeperWindowsContext;
+
+import java.io.IOException;
+
+/**
+ * Create a {@link org.apache.dubbo.test.check.registrycenter.Processor} to kill pid on Windows OS.
+ */
+public class KillProcessWindowsProcessor extends ZookeeperWindowsProcessor {
+
+ private static final Logger logger = LoggerFactory.getLogger(KillProcessWindowsProcessor.class);
+
+ @Override
+ protected void doProcess(ZookeeperWindowsContext context) throws DubboTestException {
+ for (int clientPort : context.getClientPorts()) {
+ Integer pid = context.getPid(clientPort);
Review comment:
The pid of client port should be clear immediately after kill it, os may reuse this pid when creating a new process later, and it cannot be killed next time.
##########
File path: dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/integration/multiple/exportmetadata/MultipleRegistryCenterExportMetadataIntegrationTest.java
##########
@@ -99,13 +91,9 @@ public void setUp() throws Exception {
DubboBootstrap.getInstance()
.application(new ApplicationConfig(PROVIDER_APPLICATION_NAME))
.protocol(new ProtocolConfig(PROTOCOL_NAME))
- .service(serviceConfig);
- for (RegistryCenter.Instance instance : registryCenter.getRegistryCenterInstance()) {
- DubboBootstrap.getInstance().registry(new RegistryConfig(String.format("%s://%s:%s",
- instance.getType(),
- instance.getHostname(),
- instance.getPort())));
- }
+ .service(serviceConfig)
+ .registry(new RegistryConfig("zookeeper://127.0.0.1:2181"))
+ .registry(new RegistryConfig("zookeeper://127.0.0.1:2182"));
Review comment:
Is it possible to define global zk server port/address variables and then quote them in test? It is better not to use the port 2181 by default to avoid port conflicts on the zk server. Just a suggestion.
##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/MockedRegistryCenter.java
##########
@@ -21,6 +21,16 @@
*/
public class MockedRegistryCenter {
Review comment:
It is not a mock register center, it is real. Better to rename it
##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/MockedRegistryCenter.java
##########
@@ -21,6 +21,16 @@
*/
public class MockedRegistryCenter {
+ /**
+ * The first global zookeeper address
+ */
+ public static final String ZOOKEEPER_ADDRESS1 = "zookeeper://127.0.0.1:2181";
Review comment:
The global zookeeper address configs should not mixed with embedded zk server, extract them into a outer class.
Furthermore, I thank it's better to append the zk server address and port configs to system props, such as:
```
zookeeper.address=zookeeper://127.0.0.1:2181
zookeeper.port=2181
zookeeper.address.1=zookeeper://127.0.0.1:2181
zookeeper.port.1=2181
zookeeper.address.2=zookeeper://127.0.0.1:2181
zookeeper.port.2=2181
```
So we can use them in Spring application.properties/yaml:
```
dubbo.registry.address=${zookeeper.address}
dubbo.registries.second-registry.address=${zookeeper.address.2}
```
##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/MockedRegistryCenter.java
##########
@@ -21,6 +21,16 @@
*/
public class MockedRegistryCenter {
+ /**
+ * The first global zookeeper address
+ */
+ public static final String ZOOKEEPER_ADDRESS1 = "zookeeper://127.0.0.1:2181";
Review comment:
The global zookeeper address configs should not mixed with embedded zk server, extract them into a outer class.
Furthermore, I thank it's better to append the zk server address and port configs to system props, such as:
```
zookeeper.address=zookeeper://127.0.0.1:2181
zookeeper.port=2181
zookeeper.address.1=zookeeper://127.0.0.1:2181
zookeeper.port.1=2181
zookeeper.address.2=zookeeper://127.0.0.1:2182
zookeeper.port.2=2182
```
So we can use them in Spring application.properties/yaml:
```
dubbo.registry.address=${zookeeper.address}
dubbo.registries.second-registry.address=${zookeeper.address.2}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952441180
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9138](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8b44590) into [3.0](https://codecov.io/gh/apache/dubbo/commit/94e26b4c4a2379ec01fa29ee2d9daf0baad41dcc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94e26b4) will **decrease** coverage by `0.39%`.
> The diff coverage is `5.41%`.
[](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9138 +/- ##
============================================
- Coverage 65.38% 64.98% -0.40%
- Complexity 313 329 +16
============================================
Files 1188 1206 +18
Lines 51448 51775 +327
Branches 7690 7721 +31
============================================
+ Hits 33638 33646 +8
- Misses 14189 14500 +311
- Partials 3621 3629 +8
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dubbo/test/check/exception/DubboTestException.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL2V4Y2VwdGlvbi9EdWJib1Rlc3RFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...apache/dubbo/test/check/registrycenter/Config.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL0NvbmZpZy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...est/check/registrycenter/GlobalRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL0dsb2JhbFJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...t/check/registrycenter/config/ZookeeperConfig.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbmZpZy9ab29rZWVwZXJDb25maWcuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...rycenter/config/ZookeeperRegistryCenterConfig.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbmZpZy9ab29rZWVwZXJSZWdpc3RyeUNlbnRlckNvbmZpZy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...egistrycenter/context/ZookeeperWindowsContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyV2luZG93c0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [35 more](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [94e26b4...8b44590](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#issuecomment-952441180
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9138](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8b44590) into [3.0](https://codecov.io/gh/apache/dubbo/commit/94e26b4c4a2379ec01fa29ee2d9daf0baad41dcc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94e26b4) will **decrease** coverage by `0.41%`.
> The diff coverage is `5.41%`.
[](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9138 +/- ##
============================================
- Coverage 65.38% 64.97% -0.42%
- Complexity 313 329 +16
============================================
Files 1188 1206 +18
Lines 51448 51775 +327
Branches 7690 7721 +31
============================================
+ Hits 33638 33639 +1
- Misses 14189 14508 +319
- Partials 3621 3628 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dubbo/test/check/exception/DubboTestException.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL2V4Y2VwdGlvbi9EdWJib1Rlc3RFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...apache/dubbo/test/check/registrycenter/Config.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL0NvbmZpZy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...est/check/registrycenter/GlobalRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL0dsb2JhbFJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...t/check/registrycenter/config/ZookeeperConfig.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbmZpZy9ab29rZWVwZXJDb25maWcuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...rycenter/config/ZookeeperRegistryCenterConfig.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbmZpZy9ab29rZWVwZXJSZWdpc3RyeUNlbnRlckNvbmZpZy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...egistrycenter/context/ZookeeperWindowsContext.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyV2luZG93c0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [36 more](https://codecov.io/gh/apache/dubbo/pull/9138/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [94e26b4...8b44590](https://codecov.io/gh/apache/dubbo/pull/9138?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs merged pull request #9138: [Feature] Support the global registry center in unit tests
Posted by GitBox <gi...@apache.org>.
kylixs merged pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org