You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Nico Kruber (JIRA)" <ji...@apache.org> on 2017/08/07 12:26:00 UTC
[jira] [Commented] (FLINK-2032) Migrate integration tests from temp
output files to collect()
[ https://issues.apache.org/jira/browse/FLINK-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116515#comment-16116515 ]
Nico Kruber commented on FLINK-2032:
------------------------------------
Hi [~heytitle],
it would be great if you can work on this and from the list you gave, it makes sense to create a subtask for the remaining Java and Scala tests, each. Further grouping only makes sense if the implemented changes differ too much of if you'd like to group them by module. But it seems that it is not really worth grouping further here.
> Migrate integration tests from temp output files to collect()
> -------------------------------------------------------------
>
> Key: FLINK-2032
> URL: https://issues.apache.org/jira/browse/FLINK-2032
> Project: Flink
> Issue Type: Task
> Components: Tests
> Affects Versions: 0.9
> Reporter: Fabian Hueske
> Assignee: Pattarawat Chormai
> Priority: Minor
> Labels: starter
>
> Most of Flink's integration tests that execute full Flink programs and check their results are implemented by writing results to temporary output file and comparing the content of the file to a provided set of expected Strings. Flink's test utils make this quite comfortable and hide a lot of the complexity of this approach. Nonetheless, this approach has a few drawbacks:
> - increased latency by going through disk
> - comparison is on String representation of objects
> - depends on the file system
> Since Flink's {{collect()}} feature was added, the temp file approach is not the best approach anymore. Instead, tests can collect the result of a Flink program directly as objects and compare these against a set of expected objects.
> It would be good to migrate the existing test base to use {{collect()}} instead of temporary output files.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)