[jira] [Commented] (KAFKA-3010) include error code when logging an error when ack = 0

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-3010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15067937#comment-15067937 ] 

ASF GitHub Bot commented on KAFKA-3010:
---------------------------------------

GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/709

    KAFKA-3010; Include error in log when ack 0

    I verified this by trying to produce to __consumer_offsets and the logged message looks like:
    
    [2015-12-22 10:34:40,897] INFO [KafkaApi-0] Closing connection due to error during produce request with correlation id 1 from client id console-producer with ack=0
    Topic and partition to exceptions: [__consumer_offsets,43] -> kafka.common.InvalidTopicException (kafka.server.KafkaApis)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka kafka-3010-include-error-in-log-when-ack-0

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/709.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #709
    
----
commit 9e794eef6f207b7a1beb102a868d4ccd1fedcced
Author: Ismael Juma <is...@juma.me.uk>
Date:   2015-12-19T16:32:36Z

    Include error code when logging an error when ack = 0

commit 5e60620d5007af85e4f123e02846d026855402be
Author: Ismael Juma <is...@juma.me.uk>
Date:   2015-12-22T10:39:59Z

    Remove redundant and inaccurate comment

----


> include error code when logging an error when ack = 0
> -----------------------------------------------------
>
>                 Key: KAFKA-3010
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3010
>             Project: Kafka
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.9.0.0
>            Reporter: Jun Rao
>            Assignee: Ismael Juma
>
> In handleProducerRequest.produceResponseCallback(), we have the following logging.
>              "Close connection due to error handling produce request with correlation id %d from client id %s with ack=0".format(
> We should log the error code or exception as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)