You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/30 11:36:32 UTC
[GitHub] [airflow] turbaszek opened a new pull request #12717: Remove duplicated volume mount for git sync in scheduler template
turbaszek opened a new pull request #12717:
URL: https://github.com/apache/airflow/pull/12717
closes: #12716
Before:
```
➜ helm install airflow . --namespace airflow --set executor=CeleryExecutor --set airflow_dags_mount_path=/airflow/dags \
--set dags.persistence.enabled=true \
--set dags.gitSync.enabled=true \
--set dags.gitSync.repo=https://github.com/turbaszek/vigilant-giggle \
--set dags.gitSync.subPath=dags \
--set defaultAirflowTag=master-python3.7
Error: Deployment.apps "airflow-scheduler" is invalid: spec.template.spec.containers[0].volumeMounts[4].mountPath: Invalid value: "/opt/airflow/dags": must be unique
```
After:
```
➜ helm install airflow . --namespace airflow --set executor=CeleryExecutor --set airflow_dags_mount_path=/airflow/dags \
--set dags.persistence.enabled=true \
--set dags.gitSync.enabled=true \
--set dags.gitSync.repo=https://github.com/turbaszek/vigilant-giggle \
--set defaultAirflowTag=master-python3.7
NAME: airflow
LAST DEPLOYED: Mon Nov 30 12:24:30 2020
NAMESPACE: airflow
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
Thank you for installing Airflow!
Your release is named airflow.
You can now access your dashboard(s) by executing the following command(s) and visiting the corresponding port at localhost in your browser:
Airflow dashboard: kubectl port-forward svc/airflow-webserver 8080:8080 --namespace airflow
Flower dashboard: kubectl port-forward svc/airflow-flower 5555:5555 --namespace airflow
```
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #12717: Remove duplicated volume mount for git sync in scheduler template
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #12717:
URL: https://github.com/apache/airflow/pull/12717#discussion_r532608196
##########
File path: chart/values.yaml
##########
@@ -715,9 +715,9 @@ dags:
# If using a custom storageClass, pass name here
storageClassName:
# access mode of the persistent volume
- accessMode: ReadWriteMany
+ accessMode: ReadWriteOnce
## the name of an existing PVC to use
- existingClaim: ~
Review comment:
In this way we can deploy just like that - no need to specify anything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #12717: Remove duplicated volume mount for git sync in scheduler template
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #12717:
URL: https://github.com/apache/airflow/pull/12717#issuecomment-735743337
> Can you add tests please?
Will do, once I figure more change to make it work as there are other problems with PVC
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #12717: Remove duplicated volume mount for git sync in scheduler template
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #12717:
URL: https://github.com/apache/airflow/pull/12717#discussion_r532610293
##########
File path: chart/values.yaml
##########
@@ -715,9 +715,9 @@ dags:
# If using a custom storageClass, pass name here
storageClassName:
# access mode of the persistent volume
- accessMode: ReadWriteMany
+ accessMode: ReadWriteOnce
## the name of an existing PVC to use
- existingClaim: ~
+ existingClaim:
Review comment:
In this way we can deploy just like that - no need to specify anything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #12717: Remove duplicated volume mount for git sync in scheduler template
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #12717:
URL: https://github.com/apache/airflow/pull/12717#issuecomment-735742756
Can you add tests please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #12717: Remove duplicated volume mount for git sync in scheduler template
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #12717:
URL: https://github.com/apache/airflow/pull/12717#discussion_r532609494
##########
File path: chart/templates/dags-persistent-volume-claim.yaml
##########
@@ -19,7 +19,7 @@
kind: PersistentVolumeClaim
apiVersion: v1
metadata:
- name: {{ .Release.Name }}-dags
+ name: {{ template "airflow_dags_volume_claim" . }}
Review comment:
Because:
https://github.com/apache/airflow/blob/5e13c372860a28256bf6e572bf7349f3dd6b8b0c/chart/templates/scheduler/scheduler-deployment.yaml#L203-L207
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman merged pull request #12717: Remove duplicated volume mount for git sync in scheduler template
Posted by GitBox <gi...@apache.org>.
dimberman merged pull request #12717:
URL: https://github.com/apache/airflow/pull/12717
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org