svn commit: r952825 - /myfaces/core/trunk/api/src/main/javascript/META-INF/resources/myfaces/_impl/core/_Runtime.js

[we...@apache.org]

Author: werpu
Date: Tue Jun  8 21:14:17 2010
New Revision: 952825

URL: http://svn.apache.org/viewvc?rev=952825&view=rev
Log:
https://issues.apache.org/jira/browse/MYFACES-2745
merging the "null" null conversion in, because other codeparts may rely on getting a valid null
instead of "null"
the issue is with what htmlunit induces here:

if("null") returns true
if(null) returns false
if (ret != null) returns true in case of ret == "null"
if (ret !== null) returns false due to the type comparison...

(Yes javascript really is such a mess)

so it is better not to mess with a "null" value around which cannot happen under non htmlunit conditions anyway since
windows.execScript cannot return anything or in case of ie, just returns null (which also per definition is wrong).



Modified:
    myfaces/core/trunk/api/src/main/javascript/META-INF/resources/myfaces/_impl/core/_Runtime.js

Modified: myfaces/core/trunk/api/src/main/javascript/META-INF/resources/myfaces/_impl/core/_Runtime.js
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/javascript/META-INF/resources/myfaces/_impl/core/_Runtime.js?rev=952825&r1=952824&r2=952825&view=diff
==============================================================================
--- myfaces/core/trunk/api/src/main/javascript/META-INF/resources/myfaces/_impl/core/_Runtime.js (original)
+++ myfaces/core/trunk/api/src/main/javascript/META-INF/resources/myfaces/_impl/core/_Runtime.js Tue Jun  8 21:14:17 2010
@@ -122,7 +122,7 @@ if (!myfaces._impl.core._Runtime) {
 
             } catch (e) {/*wanted*/
             }
-            //ie fallback path because it cannot eval namespaces
+            //ie fallback for some ie versions path because it cannot eval namespaces
             //ie in any version does not like that particularily
             //we do it the hard way now
             if ('undefined' != typeof ret && null != ret) {