[GitHub] [geode] jinmeiliao opened pull request #3936: GEODE-6945: no need to expand the refid attributes in the xml

["jinmeiliao (GitHub)" <gi...@apache.org>]

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3936 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on pull request #3936: GEODE-6945: expand the type to related xml attributes

["jinmeiliao (GitHub)" <gi...@apache.org>]

remove these methods for now, we don't need them. And we might change these types anyway.

[ Full content available at: https://github.com/apache/geode/pull/3936 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #3936: GEODE-6945: expand the type to related xml attributes

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

I like these new "is" methods but add javadocs to make clear that it returns true if the type is any of the types that are proxies/partitioned/replicate.
In the past on the core apis we had some confusion on methods like these since a method like isReplicate could mean "it is the REPLICATE type" instead of "it is one of the replication types".

[ Full content available at: https://github.com/apache/geode/pull/3936 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on issue #3936: GEODE-6945: expand the type to related xml attributes

["jinmeiliao (GitHub)" <gi...@apache.org>]

@dschneider-pivotal please re-review. I changed the approach: instead of not expanding the attributes in `CreateRegionCommand`, I chose to expand it everywhere, including the `RegionConverter`. This is because I found the subsequent code kind of relying on the DataPolicy being set all the time in xml configuration objects. If we don't do this, we get NPE everywhere, so it's easier just to expand it.

[ Full content available at: https://github.com/apache/geode/pull/3936 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #3936: GEODE-6945: expand the type to related xml attributes

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

If is not clear to me how valuable this test is. It seems like we just duplicate everything that is in our management code that defines a type into the RegionConverterTest.xml. The xml sets both the refid and the nested region attributes.
Maybe this is worth testing.
But what seems more valuable, and what is not tested, is that the attributes returned from "createRegionAttributesByType" and the same as what the core defines for each RegionShortcut. 

[ Full content available at: https://github.com/apache/geode/pull/3936 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on pull request #3936: GEODE-6945: expand the type to related xml attributes

["jinmeiliao (GitHub)" <gi...@apache.org>]

this xml was originally created by using the method in cache and saved as a master xml.

[ Full content available at: https://github.com/apache/geode/pull/3936 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao closed pull request #3936: GEODE-6945: expand the type to related xml attributes

["jinmeiliao (GitHub)" <gi...@apache.org>]

[ pull request closed by jinmeiliao ]

[ Full content available at: https://github.com/apache/geode/pull/3936 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org