You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/03/24 02:53:28 UTC
[GitHub] [servicecomb-java-chassis] develpoerX opened a new pull request #2747: #Support AZ information and IP grouping strategy
develpoerX opened a new pull request #2747:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2747
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] develpoerX commented on a change in pull request #2747: [SCB-2361] Support AZ information and IP grouping strategy
Posted by GitBox <gi...@apache.org>.
develpoerX commented on a change in pull request #2747:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2747#discussion_r833958542
##########
File path: service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/refresh/ClassificationAddress.java
##########
@@ -180,7 +182,7 @@ private DataCenterInfo findRegion(List<CacheEndpoint> CacheEndpoints) {
return cacheEndpoint.getInstance().getDataCenterInfo();
}
}
- return null;
+ return myself.getDataCenterInfo();
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #2747: [SCB-2361] Support AZ information and IP grouping strategy
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2747:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2747#issuecomment-1077028837
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2747?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2747](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2747?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b548f26) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/9d06d75e2fe0a50a294cb6a130d11558a4b43d44?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9d06d75) will **increase** coverage by `0.00%`.
> The diff coverage is `60.00%`.
```diff
@@ Coverage Diff @@
## master #2747 +/- ##
=========================================
Coverage 77.26% 77.26%
Complexity 1417 1417
=========================================
Files 1614 1614
Lines 43234 43234
Branches 3666 3666
=========================================
+ Hits 33404 33405 +1
+ Misses 8298 8296 -2
- Partials 1532 1533 +1
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2747?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/servicecomb/serviceregistry/api/Const.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2747/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2FwaS9Db25zdC5qYXZh) | `36.73% <ø> (ø)` | |
| [...serviceregistry/refresh/ClassificationAddress.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2747/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L3JlZnJlc2gvQ2xhc3NpZmljYXRpb25BZGRyZXNzLmphdmE=) | `54.21% <60.00%> (+4.81%)` | :arrow_up: |
| [...ache/servicecomb/foundation/common/net/IpPort.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2747/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL25ldC9JcFBvcnQuamF2YQ==) | `83.33% <0.00%> (-3.34%)` | :arrow_down: |
| [...he/servicecomb/foundation/common/net/NetUtils.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2747/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL25ldC9OZXRVdGlscy5qYXZh) | `62.99% <0.00%> (-1.58%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2747?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2747?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9d06d75...b548f26](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2747?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-commenter edited a comment on pull request #2747: [SCB-2361] Support AZ information and IP grouping strategy
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2747:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2747#issuecomment-1077028837
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2747?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2747](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2747?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05969b1) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/9d06d75e2fe0a50a294cb6a130d11558a4b43d44?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9d06d75) will **increase** coverage by `0.00%`.
> The diff coverage is `75.00%`.
```diff
@@ Coverage Diff @@
## master #2747 +/- ##
=========================================
Coverage 77.26% 77.27%
Complexity 1417 1417
=========================================
Files 1614 1614
Lines 43234 43234
Branches 3666 3665 -1
=========================================
+ Hits 33404 33407 +3
+ Misses 8298 8294 -4
- Partials 1532 1533 +1
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2747?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/servicecomb/serviceregistry/api/Const.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2747/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2FwaS9Db25zdC5qYXZh) | `36.73% <ø> (ø)` | |
| [...serviceregistry/refresh/ClassificationAddress.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2747/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L3JlZnJlc2gvQ2xhc3NpZmljYXRpb25BZGRyZXNzLmphdmE=) | `54.21% <75.00%> (+4.81%)` | :arrow_up: |
| [...he/servicecomb/foundation/common/net/NetUtils.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2747/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL25ldC9OZXRVdGlscy5qYXZh) | `62.99% <0.00%> (-1.58%)` | :arrow_down: |
| [...mb/config/ConfigCenterConfigurationSourceImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2747/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHluYW1pYy1jb25maWcvY29uZmlnLWNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb25maWcvQ29uZmlnQ2VudGVyQ29uZmlndXJhdGlvblNvdXJjZUltcGwuamF2YQ==) | `10.86% <0.00%> (+1.08%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2747?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2747?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9d06d75...05969b1](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2747?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #2747: [SCB-2361] Support AZ information and IP grouping strategy
Posted by GitBox <gi...@apache.org>.
liubao68 merged pull request #2747:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2747: [SCB-2361] Support AZ information and IP grouping strategy
Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #2747:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2747#discussion_r833891249
##########
File path: service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/refresh/ClassificationAddress.java
##########
@@ -180,7 +182,7 @@ private DataCenterInfo findRegion(List<CacheEndpoint> CacheEndpoints) {
return cacheEndpoint.getInstance().getDataCenterInfo();
}
}
- return null;
+ return myself.getDataCenterInfo();
Review comment:
```
if (myself.getDataCenterInfo() == null) {
return null;
}
```
the check is in a wrong position.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org