You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/23 22:27:22 UTC
[GitHub] [superset] codyml opened a new pull request, #22212: [WIP] fix(dashboard): Fix filter card positioning for horizontal native filters
codyml opened a new pull request, #22212:
URL: https://github.com/apache/superset/pull/22212
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR is based on #22169 and fixes positioning of filter cards for horizontal and horizontal overflow native filters.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
Before:
<img width="461" alt="Screen Shot 2022-11-23 at 3 24 20 PM" src="https://user-images.githubusercontent.com/13007381/203656367-43210982-9ae9-454a-8f55-58e44e48937e.png">
<img width="578" alt="Screen Shot 2022-11-23 at 3 24 25 PM" src="https://user-images.githubusercontent.com/13007381/203656383-1a3c8163-0acf-49ec-97df-1edf62bf0e60.png">
After:
<img width="351" alt="Screen Shot 2022-11-23 at 3 25 32 PM" src="https://user-images.githubusercontent.com/13007381/203656403-f9866c60-250c-45da-ba74-853d8d883941.png">
<img width="519" alt="Screen Shot 2022-11-23 at 3 25 38 PM" src="https://user-images.githubusercontent.com/13007381/203656415-6f94b6cf-5cea-4428-b2c9-173550b25c16.png">
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
- Confirm that horizontal and horizontal overflow filter cards don't overlap the items they're describing.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [x] Required feature flags: `HORIZONTAL_FILTER_BAR`
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #22212: fix(dashboard): Fix filter card positioning for horizontal native filters
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #22212:
URL: https://github.com/apache/superset/pull/22212#issuecomment-1325762022
# [Codecov](https://codecov.io/gh/apache/superset/pull/22212?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22212](https://codecov.io/gh/apache/superset/pull/22212?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (428da96) into [master](https://codecov.io/gh/apache/superset/commit/3bc0865d9071cdf32d268ee8fee4c4ad93680429?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3bc0865) will **decrease** coverage by `0.00%`.
> The diff coverage is `58.78%`.
```diff
@@ Coverage Diff @@
## master #22212 +/- ##
==========================================
- Coverage 66.92% 66.91% -0.01%
==========================================
Files 1835 1840 +5
Lines 69988 70081 +93
Branches 7612 7636 +24
==========================================
+ Hits 46839 46896 +57
- Misses 21183 21218 +35
- Partials 1966 1967 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.76% <58.78%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/22212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rontend/src/components/DropdownContainer/index.tsx](https://codecov.io/gh/apache/superset/pull/22212/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRHJvcGRvd25Db250YWluZXIvaW5kZXgudHN4) | `80.00% <ø> (ø)` | |
| [...ts/nativeFilters/FilterBar/ActionButtons/index.tsx](https://codecov.io/gh/apache/superset/pull/22212/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0FjdGlvbkJ1dHRvbnMvaW5kZXgudHN4) | `78.57% <ø> (ø)` | |
| [.../components/nativeFilters/FilterBar/Horizontal.tsx](https://codecov.io/gh/apache/superset/pull/22212/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0hvcml6b250YWwudHN4) | `100.00% <ø> (ø)` | |
| [...oard/components/nativeFilters/FilterCard/index.tsx](https://codecov.io/gh/apache/superset/pull/22212/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ2FyZC9pbmRleC50c3g=) | `10.00% <ø> (ø)` | |
| [superset-frontend/src/dashboard/styles.ts](https://codecov.io/gh/apache/superset/pull/22212/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9zdHlsZXMudHM=) | `100.00% <ø> (ø)` | |
| [...veFilters/FilterBar/FilterControls/FilterValue.tsx](https://codecov.io/gh/apache/superset/pull/22212/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlclZhbHVlLnRzeA==) | `6.31% <20.00%> (-0.28%)` | :arrow_down: |
| [...s/FilterBar/FiltersOutOfScopeCollapsible/index.tsx](https://codecov.io/gh/apache/superset/pull/22212/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlcnNPdXRPZlNjb3BlQ29sbGFwc2libGUvaW5kZXgudHN4) | `20.00% <20.00%> (ø)` | |
| [...Filters/FilterBar/FiltersDropdownContent/index.tsx](https://codecov.io/gh/apache/superset/pull/22212/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlcnNEcm9wZG93bkNvbnRlbnQvaW5kZXgudHN4) | `25.00% <25.00%> (ø)` | |
| [...Filters/FilterBar/FilterControls/FilterControl.tsx](https://codecov.io/gh/apache/superset/pull/22212/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2wudHN4) | `29.03% <36.84%> (ø)` | |
| [...c/hooks/useTruncation/useChildElementTruncation.ts](https://codecov.io/gh/apache/superset/pull/22212/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2hvb2tzL3VzZVRydW5jYXRpb24vdXNlQ2hpbGRFbGVtZW50VHJ1bmNhdGlvbi50cw==) | `44.73% <44.73%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/superset/pull/22212/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje merged pull request #22212: fix(dashboard): Fix filter card positioning for horizontal native filters
Posted by GitBox <gi...@apache.org>.
kgabryje merged PR #22212:
URL: https://github.com/apache/superset/pull/22212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org