You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/12/08 12:19:51 UTC
[GitHub] [ozone] GlenGeng opened a new pull request #1676: HDDS-4560: Add ReadWriteLock into PipelineStateManagerV2Impl to protect contentions between RaftServer and PipelineManager
GlenGeng opened a new pull request #1676:
URL: https://github.com/apache/ozone/pull/1676
## What changes were proposed in this pull request?
Add ReadWriteLock into PipelineStateManagerV2Impl to protect contentions between RaftServer and PipelineManager.
If current leader SCM (as leader of term N) steps down while there are on-going transactions, there might be read/write contentions that new leader SCM (as leader of term N+1) has replicated some raft log entries encapsulating method addPipeline()/removePipeline()/updatePipelineState() to the underlying RaftServer that are being applied by StateMachineUpdater, and at the same time PipelineManager is calling getPipelines().
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4560
## How was this patch tested?
CI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] runzhiwang commented on pull request #1676: HDDS-4560: Add ReadWriteLock into PipelineStateManagerV2Impl to protect contentions between RaftServer and PipelineManager
Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #1676:
URL: https://github.com/apache/ozone/pull/1676#issuecomment-742936019
@GlenGeng Is it possible to make all the data structure thread safe ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] GlenGeng commented on pull request #1676: HDDS-4560: Add ReadWriteLock into PipelineStateManagerV2Impl to protect contentions between RaftServer and PipelineManager
Posted by GitBox <gi...@apache.org>.
GlenGeng commented on pull request #1676:
URL: https://github.com/apache/ozone/pull/1676#issuecomment-742945670
> s it possible to make all the data structure thread safe ?
The key point here is synchronize the access to underlying container/pipeline state to ensure the causality, which will be broken by the thread safe data structure..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] GlenGeng commented on pull request #1676: HDDS-4560: Add ReadWriteLock into PipelineStateManagerV2Impl to protect contentions between RaftServer and PipelineManager
Posted by GitBox <gi...@apache.org>.
GlenGeng commented on pull request #1676:
URL: https://github.com/apache/ozone/pull/1676#issuecomment-741489589
@ChenSammi @nandakumar131 @runzhiwang Please take a look! Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] runzhiwang edited a comment on pull request #1676: HDDS-4560: Add ReadWriteLock into PipelineStateManagerV2Impl to protect contentions between RaftServer and PipelineManager
Posted by GitBox <gi...@apache.org>.
runzhiwang edited a comment on pull request #1676:
URL: https://github.com/apache/ozone/pull/1676#issuecomment-742925394
@GlenGeng Thanks the patch. I have one question, if without this patch, what will happen ? exception threw ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] runzhiwang commented on pull request #1676: HDDS-4560: Add ReadWriteLock into PipelineStateManagerV2Impl to protect contentions between RaftServer and PipelineManager
Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #1676:
URL: https://github.com/apache/ozone/pull/1676#issuecomment-742925394
without this patch, what will happen ? exception threw ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] GlenGeng commented on pull request #1676: HDDS-4560: Add ReadWriteLock into PipelineStateManagerV2Impl to protect contentions between RaftServer and PipelineManager
Posted by GitBox <gi...@apache.org>.
GlenGeng commented on pull request #1676:
URL: https://github.com/apache/ozone/pull/1676#issuecomment-742930631
Yes, since there is no concurrency control.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] GlenGeng edited a comment on pull request #1676: HDDS-4560: Add ReadWriteLock into PipelineStateManagerV2Impl to protect contentions between RaftServer and PipelineManager
Posted by GitBox <gi...@apache.org>.
GlenGeng edited a comment on pull request #1676:
URL: https://github.com/apache/ozone/pull/1676#issuecomment-742945670
> Is it possible to make all the data structure thread safe ?
The key point here is synchronizing the access to underlying container/pipeline state to ensure the causality, which will be broken by the thread safe data structure..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] nandakumar131 merged pull request #1676: HDDS-4560: Add ReadWriteLock into PipelineStateManagerV2Impl to protect contentions between RaftServer and PipelineManager
Posted by GitBox <gi...@apache.org>.
nandakumar131 merged pull request #1676:
URL: https://github.com/apache/ozone/pull/1676
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org