You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/01/25 22:43:55 UTC
[GitHub] [buildstream] jjardon opened a new pull request #1577: Let me use riscv architecture options.
jjardon opened a new pull request #1577:
URL: https://github.com/apache/buildstream/pull/1577
This change adds riscv32 and riscv64 to the list of possible values
for the architecture option type.
Originally submitted at https://gitlab.com/BuildStream/buildstream/-/merge_requests/2087
This is blocking freedesktop-sdk to be compiled in RISC-V (works ok with bst-1): https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/jobs/2012261945
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on pull request #1577: Let me use riscv architecture options.
Posted by GitBox <gi...@apache.org>.
gtristan commented on pull request #1577:
URL: https://github.com/apache/buildstream/pull/1577#issuecomment-1021858362
As I understand the buildstream platform definitions are modeled after the standard remote execution platform properties, should we not be patching https://github.com/bazelbuild/remote-apis/blob/main/build/bazel/remote/execution/v2/platform.md first ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on pull request #1577: Let me use riscv architecture options.
Posted by GitBox <gi...@apache.org>.
gtristan commented on pull request #1577:
URL: https://github.com/apache/buildstream/pull/1577#issuecomment-1021953235
> As I understand the buildstream platform definitions are modeled after the standard remote execution platform properties, should we not be patching https://github.com/bazelbuild/remote-apis/blob/main/build/bazel/remote/execution/v2/platform.md first ?
@juergbi ping, can you sign off on this change in advance up upstreaming the new keyword to the spec ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] jjardon commented on pull request #1577: Let me use riscv architecture options.
Posted by GitBox <gi...@apache.org>.
jjardon commented on pull request #1577:
URL: https://github.com/apache/buildstream/pull/1577#issuecomment-1085029996
> > As I understand the buildstream platform definitions are modeled after the standard remote execution platform properties, should we not be patching https://github.com/bazelbuild/remote-apis/blob/main/build/bazel/remote/execution/v2/platform.md first ?
>
> @juergbi ping, can you sign off on this change in advance up upstreaming the new keyword to the spec ?
the old PR is here: https://github.com/bazelbuild/remote-apis/pull/176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on a change in pull request #1577: Let me use riscv architecture options.
Posted by GitBox <gi...@apache.org>.
nanonyme commented on a change in pull request #1577:
URL: https://github.com/apache/buildstream/pull/1577#discussion_r792710614
##########
File path: src/buildstream/_platform/platform.py
##########
@@ -111,6 +111,8 @@ def canonicalize_arch(arch):
"powerpc64le": "power-isa-le", # Used in GCC/LLVM
"ppc64": "power-isa-be",
"ppc64le": "power-isa-le",
+ "riscv32": "riscv32",
Review comment:
The latter values iirc need to be RV32I and RV64I respectively based on remote execution API feedback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org