You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by darchons <gi...@git.apache.org> on 2018/08/16 03:57:00 UTC
[GitHub] guacamole-manual pull request #93: GUACAMOLE-565: Document terminal-type par...
GitHub user darchons opened a pull request:
https://github.com/apache/guacamole-manual/pull/93
GUACAMOLE-565: Document terminal-type parameter for SSH and Telnet
Document the new terminal-type parameter for SSH and Telnet connections.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/darchons/guacamole-manual guac-565-add-terminal-type-parameter
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/guacamole-manual/pull/93.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #93
----
commit 344980b8c15bec04602759f475e02ef7c2961d60
Author: Jim Chen <nc...@...>
Date: 2018-08-16T03:51:34Z
GUACAMOLE-565: Document terminal-type parameter for SSH and Telnet
Document the new terminal-type parameter for SSH and Telnet connections.
----
---
[GitHub] guacamole-manual pull request #93: GUACAMOLE-565: Document terminal-type par...
Posted by necouchman <gi...@git.apache.org>.
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-manual/pull/93#discussion_r210526644
--- Diff: src/chapters/configuring.xml ---
@@ -3142,6 +3142,24 @@ ed272546-87bd-4db9-acba-e36e1a9ca20a
sends ASCII code 127 (Delete) if this option is not set.</para>
</entry>
</row>
+ <row>
+ <entry><parameter>terminal-type</parameter></entry>
+ <entry>
+ <para><indexterm>
+ <primary>SSH</primary>
+ <secondary>terminal-type</secondary>
+ </indexterm>This parameter sets the terminal emulator type
+ string that is passed to the SSH server. Possible values
--- End diff --
I'm not sure it's worth listing out all of the possible values, here. Since this is being documented for the Guacamole Client interface the values are in a drop-down box and the user will be able to see them. It should be sufficient just to document the purpose and what happens if you don't specify it, and leave the list off.
---
[GitHub] guacamole-manual pull request #93: GUACAMOLE-565: Document terminal-type par...
Posted by darchons <gi...@git.apache.org>.
Github user darchons commented on a diff in the pull request:
https://github.com/apache/guacamole-manual/pull/93#discussion_r211478272
--- Diff: src/chapters/configuring.xml ---
@@ -3142,6 +3142,24 @@ ed272546-87bd-4db9-acba-e36e1a9ca20a
sends ASCII code 127 (Delete) if this option is not set.</para>
</entry>
</row>
+ <row>
+ <entry><parameter>terminal-type</parameter></entry>
+ <entry>
+ <para><indexterm>
+ <primary>SSH</primary>
+ <secondary>terminal-type</secondary>
+ </indexterm>This parameter sets the terminal emulator type
+ string that is passed to the SSH server. Possible values
--- End diff --
Fixed
---
[GitHub] guacamole-manual pull request #93: GUACAMOLE-565: Document terminal-type par...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/guacamole-manual/pull/93
---