You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@unomi.apache.org by GitBox <gi...@apache.org> on 2021/10/13 15:09:33 UTC
[GitHub] [unomi] jsinovassin commented on a change in pull request #353: UNOMI-486 JSON Schema integration
jsinovassin commented on a change in pull request #353:
URL: https://github.com/apache/unomi/pull/353#discussion_r728167964
##########
File path: services/src/main/resources/META-INF/cxs/schemas/event.json
##########
@@ -0,0 +1,29 @@
+{
+ "$id": "https://unomi.apache.org/schemas/json/event.json",
+ "$schema": "https://json-schema.org/draft/2019-09/schema",
+ "title": "Event",
+ "type": "object",
+ "allOf": [{ "$ref": "https://unomi.apache.org/schemas/json/timestampeditem.json" }],
+ "properties" : {
+ "eventType" : {
+ "type" : "string",
+ "pattern" : "^(\\w|[-_@\\.]){0,50}$"
+ },
+ "profileId" : {
+ "type" : [ "null", "string"],
+ "pattern" : "^(\\w|[-_@\\.]){0,50}$"
Review comment:
Can you change the limit to 60 characters as in https://github.com/apache/unomi/pull/350 please?
##########
File path: services/src/main/resources/META-INF/cxs/schemas/event.json
##########
@@ -0,0 +1,29 @@
+{
+ "$id": "https://unomi.apache.org/schemas/json/event.json",
+ "$schema": "https://json-schema.org/draft/2019-09/schema",
+ "title": "Event",
+ "type": "object",
+ "allOf": [{ "$ref": "https://unomi.apache.org/schemas/json/timestampeditem.json" }],
+ "properties" : {
+ "eventType" : {
+ "type" : "string",
+ "pattern" : "^(\\w|[-_@\\.]){0,50}$"
+ },
+ "profileId" : {
+ "type" : [ "null", "string"],
+ "pattern" : "^(\\w|[-_@\\.]){0,50}$"
+ },
+ "sessionId" : {
+ "type" : [ "null", "string"],
+ "pattern" : "^(\\w|[-_@\\.]){0,50}$"
Review comment:
Same comment as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org