You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "kaka11chen (via GitHub)" <gi...@apache.org> on 2023/04/03 01:59:23 UTC
[GitHub] [doris] kaka11chen opened a new pull request, #18324: [Fix](orc-reader) Fix the scale of decimal column is incorrect when query orc tables.
kaka11chen opened a new pull request, #18324:
URL: https://github.com/apache/doris/pull/18324
# Proposed changes
Issue Number: close #18323
## Problem summary
The scale of decimal column is incorrect when query orc tables.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18324: [Fix](orc-reader) Fix the scale of decimal column is incorrect when query orc tables.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18324:
URL: https://github.com/apache/doris/pull/18324#issuecomment-1494235133
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #18324: [Fix](orc-reader) Fix the scale of decimal column is incorrect when query orc tables.
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #18324:
URL: https://github.com/apache/doris/pull/18324#issuecomment-1494234220
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18324: [Fix](orc-reader) Fix the scale of decimal column is incorrect when query orc tables.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18324:
URL: https://github.com/apache/doris/pull/18324#issuecomment-1493533005
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18324: [Fix](orc-reader) Fix the scale of decimal column is incorrect when query orc tables.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18324:
URL: https://github.com/apache/doris/pull/18324#issuecomment-1494235056
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #18324: [Fix](orc-reader) Fix the scale of decimal column is incorrect when query orc tables.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #18324:
URL: https://github.com/apache/doris/pull/18324#discussion_r1155768368
##########
be/src/vec/exec/format/orc/vorc_reader.h:
##########
@@ -147,13 +147,19 @@ class OrcReader : public GenericReader {
Status _decode_explicit_decimal_column(const std::string& col_name,
const MutableColumnPtr& data_column,
const DataTypePtr& data_type,
- DecimalScaleParams& scale_params,
orc::ColumnVectorBatch* cvb, size_t num_values) {
OrcColumnType* data = dynamic_cast<OrcColumnType*>(cvb);
if (data == nullptr) {
return Status::InternalError("Wrong data type for colum '{}'", col_name);
}
- _init_decimal_converter<DecimalPrimitiveType>(data_type, scale_params, data->scale);
+ if (_decimal_scale_params_index >= _decimal_scale_params.size()) {
+ DecimalScaleParams temp_scale_params;
+ _init_decimal_converter<DecimalPrimitiveType>(data_type, temp_scale_params,
+ data->scale);
+ _decimal_scale_params.emplace_back(std::move(temp_scale_params));
Review Comment:
warning: std::move of the variable 'temp_scale_params' of the trivially-copyable type 'doris::vectorized::DecimalScaleParams' has no effect; remove std::move() [performance-move-const-arg]
```suggestion
_decimal_scale_params.emplace_back(temp_scale_params);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #18324: [Fix](orc-reader) Fix the scale of decimal column is incorrect when query orc tables.
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #18324:
URL: https://github.com/apache/doris/pull/18324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org