You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@storm.apache.org by rz...@apache.org on 2025/07/24 11:11:13 UTC
(storm) branch drop-url-and-user-from-version-info created (now f644fb87f)
This is an automated email from the ASF dual-hosted git repository.
rzo1 pushed a change to branch drop-url-and-user-from-version-info
in repository https://gitbox.apache.org/repos/asf/storm.git
at f644fb87f Drop User & URL from VersionInfo
This branch includes the following new commits:
new f644fb87f Drop User & URL from VersionInfo
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
(storm) 01/01: Drop User & URL from VersionInfo
Posted by rz...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
rzo1 pushed a commit to branch drop-url-and-user-from-version-info
in repository https://gitbox.apache.org/repos/asf/storm.git
commit f644fb87fc01580c16142bbaa63ccbc1cdea99c9
Author: Richard Zowalla <rz...@apache.org>
AuthorDate: Thu Jul 24 13:11:02 2025 +0200
Drop User & URL from VersionInfo
---
.../jvm/org/apache/storm/utils/IVersionInfo.java | 12 ---------
.../jvm/org/apache/storm/utils/VersionInfo.java | 29 ----------------------
.../resources/storm-client-version-info.properties | 2 --
.../resources/storm-core-version-info.properties | 2 --
.../java/org/apache/storm/daemon/ui/UIHelpers.java | 2 --
5 files changed, 47 deletions(-)
diff --git a/storm-client/src/jvm/org/apache/storm/utils/IVersionInfo.java b/storm-client/src/jvm/org/apache/storm/utils/IVersionInfo.java
index b25547ff9..35f274117 100644
--- a/storm-client/src/jvm/org/apache/storm/utils/IVersionInfo.java
+++ b/storm-client/src/jvm/org/apache/storm/utils/IVersionInfo.java
@@ -46,18 +46,6 @@ public interface IVersionInfo {
*/
String getDate();
- /**
- * Get the name of the user that did the build.
- * @return the name of the user that did the build.
- */
- String getUser();
-
- /**
- * Get the full SCM URL for the build.
- * @return the SCM URL of the build.
- */
- String getUrl();
-
/**
* Get the checksum of the source.
* @return the checksum of the source.
diff --git a/storm-client/src/jvm/org/apache/storm/utils/VersionInfo.java b/storm-client/src/jvm/org/apache/storm/utils/VersionInfo.java
index 759f347b7..8dad52c3d 100644
--- a/storm-client/src/jvm/org/apache/storm/utils/VersionInfo.java
+++ b/storm-client/src/jvm/org/apache/storm/utils/VersionInfo.java
@@ -85,16 +85,6 @@ public final class VersionInfo {
return info.getProperty("date", "Unknown");
}
- @Override
- public String getUser() {
- return info.getProperty("user", "Unknown");
- }
-
- @Override
- public String getUrl() {
- return info.getProperty("url", "Unknown");
- }
-
@Override
public String getSrcChecksum() {
return info.getProperty("srcChecksum", "Unknown");
@@ -104,7 +94,6 @@ public final class VersionInfo {
public String getBuildVersion() {
return this.getVersion()
+ " from " + getRevision()
- + " by " + getUser()
+ " source checksum " + getSrcChecksum();
}
}
@@ -223,22 +212,6 @@ public final class VersionInfo {
return OUR_FULL_VERSION.getDate();
}
- /**
- * Get the name of the user that did the build.
- * @return the name of the user that did the build.
- */
- public static String getUser() {
- return OUR_FULL_VERSION.getUser();
- }
-
- /**
- * Get the full SCM URL for the build.
- * @return the SCM URL of the build.
- */
- public static String getUrl() {
- return OUR_FULL_VERSION.getUrl();
- }
-
/**
* Get the checksum of the source.
* @return the checksum of the source.
@@ -257,9 +230,7 @@ public final class VersionInfo {
public static void main(String[] args) {
System.out.println("Storm " + getVersion());
- System.out.println("URL " + getUrl() + " -r " + getRevision());
System.out.println("Branch " + getBranch());
- System.out.println("Compiled by " + getUser() + " on " + getDate());
System.out.println("From source with checksum " + getSrcChecksum());
}
}
diff --git a/storm-client/src/resources/storm-client-version-info.properties b/storm-client/src/resources/storm-client-version-info.properties
index 7ae3130b2..b92dfcef6 100644
--- a/storm-client/src/resources/storm-client-version-info.properties
+++ b/storm-client/src/resources/storm-client-version-info.properties
@@ -18,7 +18,5 @@
version=${pom.version}
revision=${version-info.scm.commit}
branch=${version-info.scm.branch}
-user=${user.name}
date=${version-info.build.time}
-url=${version-info.scm.uri}
srcChecksum=${version-info.source.md5}
diff --git a/storm-core/src/resources/storm-core-version-info.properties b/storm-core/src/resources/storm-core-version-info.properties
index 7ae3130b2..b92dfcef6 100644
--- a/storm-core/src/resources/storm-core-version-info.properties
+++ b/storm-core/src/resources/storm-core-version-info.properties
@@ -18,7 +18,5 @@
version=${pom.version}
revision=${version-info.scm.commit}
branch=${version-info.scm.branch}
-user=${user.name}
date=${version-info.build.time}
-url=${version-info.scm.uri}
srcChecksum=${version-info.source.md5}
diff --git a/storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java b/storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java
index b07f01519..971e5454f 100644
--- a/storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java
+++ b/storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java
@@ -538,8 +538,6 @@ public class UIHelpers {
ret.put("revision", info.getRevision());
ret.put("branch", info.getBranch());
ret.put("date", info.getDate());
- ret.put("user", info.getUser());
- ret.put("url", info.getUrl());
ret.put("srcChecksum", info.getSrcChecksum());
return ret;
}