[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #4722: Dynamic information_schema configuration and port more tests

[GitBox <gi...@apache.org>]

alamb commented on code in PR #4722:
URL: https://github.com/apache/arrow-datafusion/pull/4722#discussion_r1056681111


##########
datafusion/core/src/execution/context.rs:
##########
@@ -1546,17 +1550,10 @@ impl SessionState {
 
             Self::register_default_schema(&config, &runtime, &default_catalog);
 
-            let default_catalog: Arc<dyn CatalogProvider> = if config.information_schema()
-            {
-                Arc::new(CatalogWithInformationSchema::new(
-                    Arc::downgrade(&catalog_list),
-                    Arc::new(default_catalog),
-                ))
-            } else {
-                Arc::new(default_catalog)
-            };
-            catalog_list
-                .register_catalog(config.default_catalog.clone(), default_catalog);
+            catalog_list.register_catalog(

Review Comment:
   The InformationSchema changes are now handed in `update_information_schema`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org