[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #16236: [improve][java-client] Replace ScheduledExecutor to improve performance of message consumption

[GitBox <gi...@apache.org>]

michaeljmarshall commented on code in PR #16236:
URL: https://github.com/apache/pulsar/pull/16236#discussion_r908049474


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java:
##########
@@ -193,6 +196,8 @@ private PulsarClientImpl(ClientConfigurationData conf, EventLoopGroup eventLoopG
                     new ExecutorProvider(conf.getNumListenerThreads(), "pulsar-external-listener");
             this.internalExecutorProvider = internalExecutorProvider != null ? internalExecutorProvider :
                     new ExecutorProvider(conf.getNumIoThreads(), "pulsar-client-internal");
+            this.scheduledExecutorProvider = new ScheduledExecutorProvider(conf.getNumIoThreads(),

Review Comment:
   @codelipenghui - I think we might want to provide a way for end users (and brokers) to supply this `ScheduledExecutorProvider`. We do that in the broker for the `externalExecutorProvider` and the `internalExecutorProvider` on the lines above to limit the resources required for multiple clients that run within the broker.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org