[GitHub] [trafficserver] maskit commented on pull request #7039: Avoid unnecessary copying of STL map for QUICTPConfigQCP class.

[GitBox <gi...@apache.org>]

maskit commented on pull request #7039:
URL: https://github.com/apache/trafficserver/pull/7039#issuecomment-664726956


   @scw00 Thanks for taking care of QUIC related PRs. I should have clarified how we maintain QUIC code.
   
   I think this PR is fine (we can land this on master), since it's cleanup and not a new stuff. I'm going to merge master to quic-latest to catchup these changes later.
   
   The master and 9.0.x branch are currently based on QUIC draft-27, so adding something new based on the latest spec may break the -27 support. However, it doesn't mean we shouldn't change any code for QUIC on master or 9.0.x. The code for -27 should be maintained. So I'm fine with making fixes like this on master. Some of them may conflict with changes on quic-latest but I can manage, I might change my mind  if the fix was huge though.
   
   I should probably send this on dev@ but here's my proposal for how we maintain QUIC code on the three branches
   master: All fixes for -27 would be made here
   9.0.x: Some of fixes for -27 would be cherry-picked from master
   quic-latest: All changes for -29 or later would be made here
   
   I'd make a PR for master if I found a bug while I'm working on the latest spec and the bug exists on -27 support as well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org