[GitHub] [inlong] fuweng11 commented on a diff in pull request #6489: [INLONG-6487][Manager] Add API to force delete the stream source

[GitBox <gi...@apache.org>]

fuweng11 commented on code in PR #6489:
URL: https://github.com/apache/inlong/pull/6489#discussion_r1017803398


##########
inlong-manager/manager-dao/src/main/resources/mappers/StreamSourceEntityMapper.xml:
##########
@@ -271,6 +271,18 @@
         </where>
     </select>
 
+    <update id="updateByGroupIdAndStreamId">
+        update stream_source
+        <set>
+            is_deleted = id,
+            previous_status = status,
+            status = #{status, jdbcType=INTEGER},

Review Comment:
   It is recommended to modify the `version` to prevent the deleted source from being updated during concurrent modification.



##########
inlong-manager/manager-dao/src/main/resources/mappers/StreamSourceEntityMapper.xml:
##########
@@ -271,6 +271,18 @@
         </where>
     </select>
 
+    <update id="updateByGroupIdAndStreamId">

Review Comment:
   It is recommended to modify the method name, indicating that this method is a delete operation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org